From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8761DEB64D7 for ; Tue, 13 Jun 2023 22:16:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB5C98E0005; Tue, 13 Jun 2023 18:16:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3EB78E0002; Tue, 13 Jun 2023 18:16:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDF558E0005; Tue, 13 Jun 2023 18:16:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BBA998E0002 for ; Tue, 13 Jun 2023 18:16:26 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7CACD120654 for ; Tue, 13 Jun 2023 22:16:26 +0000 (UTC) X-FDA: 80899134372.14.F64366F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id AC8C2180003 for ; Tue, 13 Jun 2023 22:16:24 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KvuDR5kb; spf=pass (imf06.hostedemail.com: domain of dinguyen@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dinguyen@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686694584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YwZ4DFdqHDRvVB14WnVES60mGbXMUBES447BZodDdpY=; b=h9sTPyVmb9FHALEFwMnT9Asdi5PufL2XNR1BtmLe0za+hw8rXWEsyP0sV9f1Bl2tnUd23j 9uneKqQoLCPuGEmKUBIYFIr2Robbg92wgTDvxm0a7z7KqBBdTs9QcIQF4XkANh5cvYpJhf nHvNKTWaj/3KbRxWnebsHBcEUWbRojo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686694584; a=rsa-sha256; cv=none; b=MjvLQGGpjF7JmpzMqUBKqHHwB8fl3xJ7lqjsqjKB86z8x00x0d1IYylpBijeaHmux8xm3C frbCmWvQevoy/40Pr3H5p60fVprZQTip7MO8Tpb+sBsTfi3YJx8vd7BfShZdYgwTG1bM1w FJT7FpcaBEJY3XHd2b88BZ23QkwXOwM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KvuDR5kb; spf=pass (imf06.hostedemail.com: domain of dinguyen@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dinguyen@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E99E62F32; Tue, 13 Jun 2023 22:16:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E27C1C433C0; Tue, 13 Jun 2023 22:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686694582; bh=+WIGytSpx4hFIJZtH+suKZCZHkq5JBHItki5+7BFPsc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KvuDR5kbBMLh2VXVzw7NO5wtSshJHEiPMI72MOW96V4/U71ZPwOvtZcgx4igXxMM9 em+vyycTpMJAdlxzRDVkQnWhkW0lpSv1w5OfUlveeKzndjtlhfIAlz6KkyJhYm9vAL YeOSX6iUcPzAZQxfDfXnUCMYGVKsXS4ueWqr5sAFUnmWDNkxen775E7afX9ThgAUDG /zY+Rb3OkZn0TBkz1JEvYtOijN22lxlf2MhOYND5RFEYMsncR0Ru0UtWG3QgShOTYr rTOglNLVYb9iCLUk1lIGArlo4nilYPoAaYiuRtfBAW2VjixrTzTJsPA6zdb5t+Q6uZ QAuDp1N4POaTw== Message-ID: <032f8239-bb82-e20e-e42b-e7a54754298b@kernel.org> Date: Tue, 13 Jun 2023 17:16:18 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 01/13] nios2: define virtual address space for modules Content-Language: en-US To: Mike Rapoport , linux-kernel@vger.kernel.org Cc: Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org References: <20230601101257.530867-1-rppt@kernel.org> <20230601101257.530867-2-rppt@kernel.org> From: Dinh Nguyen In-Reply-To: <20230601101257.530867-2-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AC8C2180003 X-Rspam-User: X-Stat-Signature: 6iejimdxxpspbrq86omz8wyjgp97h3a1 X-Rspamd-Server: rspam03 X-HE-Tag: 1686694584-682996 X-HE-Meta: U2FsdGVkX19B2KGEutBSoPGKoL2AuceBr4M8xyWFIkpsyuU84LpgSgSDBpSSUB/1MEDtiFruoznTEtENCkW1YRUY2EzIBpWmkFKryYtUWL/etdCn2vdjf1jM17Deb6p6p00o85S6t7QjleWWxu457rKGqQNwI109z0tCgQqmH89FXNNPPZZgQucKpyiYsD+6Ht+Q2uMVXSHnlCTgaHwOeVgrlwBlWKmG5q/S25KVZN3kJv3JueodOYDAA7AaeejVrROdYdImG0LlCeB6ZvhjkGHFXks3U9pSstJHT+CJH/wQrTWi7jzZOTNMSMkfqyYKkRMR1bkkmoVQYxpCBH+A3ZJmjsWzF6VDubdwLt13BnlkP3bzxEunyLbcPi26rIzz5dpUULPTDcPr41X6tF0ZIPJhf8YaV3xeF733mC4+EDiLvTNCmXM1BI4lIMIqzq1tna5LvNWIGMrtWAmIjVPeA4wQNGTRwyCZImJOYt9GP8518wjQt5Adc8qvNdGYq7LcG0th8/F9l5gXcOnYdzoomjCv4rzCLgxSY82f7JPGWsKtZlzh1MbkOfCGr+tc9PHmbJx0e0adAqZ4uQwD2ksr95QiBnzXWbOOL9/BjrTpkyK75wM19B1BK4yWKhf1aK9DEd9mwmF/zjK8hYi8IPEdQrEXPprFp2sybIWEkwh7jpqOyu3cmknHUUGV6H2BSo0YK8zj0U4wWGHlpLerGs2rS0ORmK540YyzENIaZauUySVdkgKxzx0RFI5og+29Kp4evbvU0ZTCd+kV5kcU1/BywNHChoRMQSLXJ04Jl4jovK65toI/IRaTM9SCaJW27WiNjytni4YqihkkCXyazEH6wV6mtXXmr28veZcqxHPourQpqYpRUlZWxerKzuqVhWBxnxPrgJND/WdzVIKr0J4RQwcvc2LqN86k/Wg40/XadS5qpGLEKYNPXEdVY8pOgGyRhfIVj4lj2zgteENulo5 AImpX2Np 7Eh06y4uib8R70uMGmFb6mlQD+ikzBoH8qmHd5bEaJUTHXLKaxTZc1ika2yHr+Je0utXjBolsdh/QBUXMV7znKYb8dXyOdkTWVu47/tzVVenNiEM4ZECvTnLKQBBSMEjT249igWmiyoWM96lJ8xGph3nKwxKlxd8ax2nvpbb7mny67dN70FzOhoGbNAQ7Hs6ZvU/aJL63NP7IK1U3OW3OAyHTMp26nv3Yi/F2SmcrmmAZvPI/NMOwzCNUiY32871y/MGuv4s/tD4Zz0lnkjD9dfgVdSLT+NoHKQYDjdEKonjdAEDQQx2DqmdtrvHWne8weklEvMV9lIKjmMMEhf9/29tVI2WNNLRaLyocbHFABhmYIdI3cTOCpeuECN7ne/Dc1epiYalOXVPW+zo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/1/23 05:12, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > nios2 uses kmalloc() to implement module_alloc() because CALL26/PCREL26 > cannot reach all of vmalloc address space. > > Define module space as 32MiB below the kernel base and switch nios2 to > use vmalloc for module allocations. > > Suggested-by: Thomas Gleixner > Signed-off-by: Mike Rapoport (IBM) > --- > arch/nios2/include/asm/pgtable.h | 5 ++++- > arch/nios2/kernel/module.c | 19 ++++--------------- > 2 files changed, 8 insertions(+), 16 deletions(-) > > diff --git a/arch/nios2/include/asm/pgtable.h b/arch/nios2/include/asm/pgtable.h > index 0f5c2564e9f5..0073b289c6a4 100644 > --- a/arch/nios2/include/asm/pgtable.h > +++ b/arch/nios2/include/asm/pgtable.h > @@ -25,7 +25,10 @@ > #include > > #define VMALLOC_START CONFIG_NIOS2_KERNEL_MMU_REGION_BASE > -#define VMALLOC_END (CONFIG_NIOS2_KERNEL_REGION_BASE - 1) > +#define VMALLOC_END (CONFIG_NIOS2_KERNEL_REGION_BASE - SZ_32M - 1) > + > +#define MODULES_VADDR (CONFIG_NIOS2_KERNEL_REGION_BASE - SZ_32M) > +#define MODULES_END (CONFIG_NIOS2_KERNEL_REGION_BASE - 1) > > struct mm_struct; > > diff --git a/arch/nios2/kernel/module.c b/arch/nios2/kernel/module.c > index 76e0a42d6e36..9c97b7513853 100644 > --- a/arch/nios2/kernel/module.c > +++ b/arch/nios2/kernel/module.c > @@ -21,23 +21,12 @@ > > #include > > -/* > - * Modules should NOT be allocated with kmalloc for (obvious) reasons. > - * But we do it for now to avoid relocation issues. CALL26/PCREL26 cannot reach > - * from 0x80000000 (vmalloc area) to 0xc00000000 (kernel) (kmalloc returns > - * addresses in 0xc0000000) > - */ > void *module_alloc(unsigned long size) > { > - if (size == 0) > - return NULL; > - return kmalloc(size, GFP_KERNEL); > -} > - > -/* Free memory returned from module_alloc */ > -void module_memfree(void *module_region) > -{ > - kfree(module_region); > + return __vmalloc_node_range(size, 1, MODULES_VADDR, MODULES_END, > + GFP_KERNEL, PAGE_KERNEL_EXEC, > + VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, > + __builtin_return_address(0)); > } > > int apply_relocate_add(Elf32_Shdr *sechdrs, const char *strtab, Acked-by: Dinh Nguyen