From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7048FC433F5 for ; Wed, 19 Jan 2022 15:19:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 011A36B0072; Wed, 19 Jan 2022 10:19:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDBA16B0073; Wed, 19 Jan 2022 10:19:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D55616B0074; Wed, 19 Jan 2022 10:19:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id C50886B0072 for ; Wed, 19 Jan 2022 10:19:23 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7E38596F0A for ; Wed, 19 Jan 2022 15:19:23 +0000 (UTC) X-FDA: 79047395406.11.FB597DB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 59D76140019 for ; Wed, 19 Jan 2022 15:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642605560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N2Kx/KmSGjwFhe88nJ+Zwktzmmd9oPiPrRk8BrjbT0k=; b=CsFeeIoW6OsABLBjIq+wugJ3RPQjr9KS5vB/cb/j3SL+/HtlOvdxACC33Bl4bn1j3o2R6B aMbPI+/9IgtBRjPZEhfBzbiYaaFn/3mXuZ5kAwpjjDlHfqe7iiFBED9VG7+X8np5k1GPob yBY9uhqg0FB6Fo5pcrGUEgs++wwfktY= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-290-hyx11KoZP5G6A9ll64x2sA-1; Wed, 19 Jan 2022 10:19:19 -0500 X-MC-Unique: hyx11KoZP5G6A9ll64x2sA-1 Received: by mail-ed1-f69.google.com with SMTP id h21-20020aa7c955000000b0040390b2bfc5so2790848edt.15 for ; Wed, 19 Jan 2022 07:19:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:organization:in-reply-to :content-transfer-encoding; bh=N2Kx/KmSGjwFhe88nJ+Zwktzmmd9oPiPrRk8BrjbT0k=; b=hhKh2H2Y4XfHfmiaWQILzO7UnuaZOfJ/7puvbissZz9+Um+z8mh6aWKdzVNMfJ98fn EPNYueEZ9vBlxMKwn4VWzKPtVdOm8QUcodMHhHT6w2lG8GI6bHkr/VSS7YoWwsR8Tb+U 6rg5Dbl6IA57DmDPF7kziSfjVva2HAsnwOj6+FGC1HITSJO78EeMBTbOUIxNlMCokKP4 S6/aRg3W3QCPnAADAz7fZbGHdwvS0qdcvC+UHWy8xANCuijKWm4+CY+RaOlwFhD6I2Rp akWCTRs5mreiEfxxL3wJgBLJairFK7k2fT8wlEV5NOBcx44n5J/PC8414s2TX18RK6rd VMeQ== X-Gm-Message-State: AOAM5308yMyF2aU6qgCdn2lbqloIfa2WkUdkIfQqpKpMiFmLcIYTB9H+ DH5+/xZlvi5xsIgBloDd9i89xHjvGTMKMUI3Vyuwf910GVoJ7JJWeDqbL5N+Py6uQfQtAGwsoce X4gW0MWYmxZo= X-Received: by 2002:a05:6402:4244:: with SMTP id g4mr8245394edb.271.1642605557936; Wed, 19 Jan 2022 07:19:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxwEg/siCN/Fuz2RHHae7nJJb1hw18MrJypanl3R30CSy8Wu4eUatazRDYz27Q4bdB8Qssimg== X-Received: by 2002:a05:6402:4244:: with SMTP id g4mr8245380edb.271.1642605557772; Wed, 19 Jan 2022 07:19:17 -0800 (PST) Received: from ?IPV6:2003:cb:c705:fb00:c6c0:1fe6:bfa1:e868? (p200300cbc705fb00c6c01fe6bfa1e868.dip0.t-ipconnect.de. [2003:cb:c705:fb00:c6c0:1fe6:bfa1:e868]) by smtp.gmail.com with ESMTPSA id rv9sm9351ejb.216.2022.01.19.07.19.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jan 2022 07:19:17 -0800 (PST) Message-ID: <035dc6b1-28cb-0563-c712-bf57ebbc91e8@redhat.com> Date: Wed, 19 Jan 2022 16:19:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v1] proc/vmcore: fix false positive lockdep warning From: David Hildenbrand To: Boqun Feng Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Baoquan He , Andrew Morton , Vivek Goyal , Dave Young , "Paul E. McKenney" , Josh Triplett , Peter Zijlstra References: <20220119113702.102567-1-david@redhat.com> Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CsFeeIoW; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf23.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: jgratzcxad1p9csa9bp6y9nw94rwg858 X-Rspamd-Queue-Id: 59D76140019 X-Rspamd-Server: rspam12 X-HE-Tag: 1642605560-848345 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.01.22 16:15, David Hildenbrand wrote: > On 19.01.22 16:08, Boqun Feng wrote: >> Hi, >> >> On Wed, Jan 19, 2022 at 12:37:02PM +0100, David Hildenbrand wrote: >>> Lockdep complains that we do during mmap of the vmcore: >>> down_write(mmap_lock); >>> down_read(vmcore_cb_rwsem); >>> And during read of the vmcore: >>> down_read(vmcore_cb_rwsem); >>> down_read(mmap_lock); >>> >>> We cannot possibly deadlock when only taking vmcore_cb_rwsem in read >>> mode, however, it's hard to teach that to lockdep. >>> >> >> Lockdep warned about the above sequences because rw_semaphore is a fair >> read-write lock, and the following can cause a deadlock: >> >> TASK 1 TASK 2 TASK 3 >> ====== ====== ====== >> down_write(mmap_lock); >> down_read(vmcore_cb_rwsem) >> down_write(vmcore_cb_rwsem); // blocked >> down_read(vmcore_cb_rwsem); // cannot get the lock because of the fairness >> down_read(mmap_lock); // blocked >> >> IOW, a reader can block another read if there is a writer queued by the >> second reader and the lock is fair. >> >> So there is a deadlock possiblity. > > Task 3 will never take the mmap_lock before doing a > down_write(vmcore_cb_rwsem). > > How would this happen? Ah, I get it, nevermind. I'll adjust the patch description. Thanks! -- Thanks, David / dhildenb