From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: 'Vlastimil Babka' <vbabka@suse.cz>,
'Mel Gorman' <mgorman@techsingularity.net>,
'Ganapatrao Kulkarni' <gpkulkarni@gmail.com>
Cc: 'Michal Hocko' <mhocko@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC 4/4] mm, page_alloc: fix premature OOM when racing with cpuset mems update
Date: Wed, 18 Jan 2017 15:12:27 +0800 [thread overview]
Message-ID: <036e01d2715a$3a227de0$ae6779a0$@alibaba-inc.com> (raw)
In-Reply-To: <20170117221610.22505-5-vbabka@suse.cz>
On Wednesday, January 18, 2017 6:16 AM Vlastimil Babka wrote:
>
> @@ -3802,13 +3811,8 @@ __alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order,
> * Also recalculate the starting point for the zonelist iterator or
> * we could end up iterating over non-eligible zones endlessly.
> */
Is the newly added comment still needed?
> - if (unlikely(ac.nodemask != nodemask)) {
> -no_zone:
> + if (unlikely(ac.nodemask != nodemask))
> ac.nodemask = nodemask;
> - ac.preferred_zoneref = first_zones_zonelist(ac.zonelist,
> - ac.high_zoneidx, ac.nodemask);
> - /* If we have NULL preferred zone, slowpath wll handle that */
> - }
>
> page = __alloc_pages_slowpath(alloc_mask, order, &ac);
>
> --
> 2.11.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-18 7:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 22:16 [RFC 0/4] fix premature OOM due to cpuset races Vlastimil Babka
2017-01-17 22:16 ` [RFC 1/4] mm, page_alloc: fix check for NULL preferred_zone Vlastimil Babka
2017-01-18 9:31 ` Michal Hocko
2017-01-18 9:45 ` Vlastimil Babka
2017-01-18 9:53 ` Michal Hocko
2017-01-18 9:45 ` Mel Gorman
2017-01-17 22:16 ` [RFC 2/4] mm, page_alloc: fix fast-path race with cpuset update or removal Vlastimil Babka
2017-01-18 9:34 ` Michal Hocko
2017-01-18 9:46 ` Mel Gorman
2017-01-17 22:16 ` [RFC 3/4] mm, page_alloc: move cpuset seqcount checking to slowpath Vlastimil Babka
2017-01-18 7:22 ` Hillf Danton
2017-01-18 9:26 ` Vlastimil Babka
2017-01-18 9:40 ` Michal Hocko
2017-01-18 9:48 ` Vlastimil Babka
2017-01-18 9:55 ` Michal Hocko
2017-01-18 10:03 ` Mel Gorman
2017-01-17 22:16 ` [RFC 4/4] mm, page_alloc: fix premature OOM when racing with cpuset mems update Vlastimil Babka
2017-01-18 7:12 ` Hillf Danton [this message]
2017-01-18 9:32 ` Vlastimil Babka
2017-01-18 10:08 ` Mel Gorman
2017-01-18 9:19 ` [RFC 0/4] fix premature OOM due to cpuset races Michal Hocko
2017-01-18 16:20 ` [RFC 5/4] mm, page_alloc: fix premature OOM due to vma mempolicy update Vlastimil Babka
2017-01-18 16:23 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='036e01d2715a$3a227de0$ae6779a0$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=gpkulkarni@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).