From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by kanga.kvack.org (Postfix) with ESMTP id 152B86B0003 for ; Fri, 12 Oct 2018 15:11:50 -0400 (EDT) Received: by mail-wm1-f72.google.com with SMTP id j124-v6so7687168wmd.4 for ; Fri, 12 Oct 2018 12:11:50 -0700 (PDT) Received: from mout.web.de (mout.web.de. [212.227.17.11]) by mx.google.com with ESMTPS id l127-v6si1748328wmf.75.2018.10.12.12.11.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Oct 2018 12:11:48 -0700 (PDT) Subject: Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions References: <20181012013756.11285-1-joel@joelfernandes.org> From: SF Markus Elfring Message-ID: <03b524f3-5f3a-baa0-2254-9c588103d2d6@users.sourceforge.net> Date: Fri, 12 Oct 2018 20:51:45 +0200 MIME-Version: 1.0 In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Joel Fernandes , kernel-janitors@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Michal Hocko , Julia Lawall , Andrey Ryabinin , Andy Lutomirski , Borislav Petkov , Catalin Marinas , Chris Zankel , Daniel Colascione , Dave Hansen , "David S. Miller" , Fenghua Yu , Geert Uytterhoeven , Guan Xuetao , Helge Deller , Hugh Dickins , Ingo Molnar , "James E. J. Bottomley" , Jeff Dike , Jonas Bonn , kasan-dev@googlegroups.com, kvmarm@lists.cs.columbia.edu, Ley Foon Tan , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, pantin@google.com, Lokesh Gidra , Max Filippov , Minchan Kim , nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, Peter Zijlstra , Richard Weinberger , Rich Felker , Sam Creasey , sparclinux@vger.kernel.org, Stafford Horne , Stefan Kristiansson , Thomas Gleixner , Tony Luck , Will Deacon , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Yoshinori Sato , "Kirill A. Shutemov" , Andrew Morton > The changes were obtained by applying the following Coccinelle script. A bit of clarification happened for its implementation details. https://systeme.lip6.fr/pipermail/cocci/2018-October/005374.html I have taken also another look at the following SmPL code. > identifier fn =~ > "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$"; I suggest to adjust the regular expression for this constraint and in subsequent SmPL rules. "^(?:pte_alloc(?:_one(?:_kernel)?)?|__pte_alloc(?:_kernel)?)$"; > ( > - T3 fn(T1 E1, T2 E2); > + T3 fn(T1 E1); > | > - T3 fn(T1 E1, T2 E2, T4 E4); > + T3 fn(T1 E1, T2 E2); > ) I propose to take an other SmPL disjunction into account here. T3 fn(T1 E1, ( - T2 E2 | T2 E2, - T4 E4 ) ); > ( > - #define fn(a, b, c)@p e > + #define fn(a, b) e > | > - #define fn(a, b)@p e > + #define fn(a) e > ) How do you think about to omit the metavariable a??position pa?? here? Regards, Markus