From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06113C4361A for ; Fri, 4 Dec 2020 13:02:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8315E22AAD for ; Fri, 4 Dec 2020 13:02:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8315E22AAD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CA6976B0068; Fri, 4 Dec 2020 08:02:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C56B96B006C; Fri, 4 Dec 2020 08:02:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B45396B006E; Fri, 4 Dec 2020 08:02:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 9C2B36B0068 for ; Fri, 4 Dec 2020 08:02:30 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5F52D3642 for ; Fri, 4 Dec 2020 13:02:30 +0000 (UTC) X-FDA: 77555613660.18.smoke64_1b174ef273c4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 2CEAE100EC667 for ; Fri, 4 Dec 2020 13:02:30 +0000 (UTC) X-HE-Tag: smoke64_1b174ef273c4 X-Filterd-Recvd-Size: 3830 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Dec 2020 13:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607086948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/zIV3oPkorhPuCufKlQSWXHaXpz4JjWCxdN0XzgD18E=; b=UjlZmtz+egxeLM4Oyf9OdtuKxQkaWLp8z4tnli2u9tTWL9RUkzlG7Mo+pvGalkXGYDNPCW 5N1qTSJNewp4jJrozPfy1R1gsLUcD5V+RGtyw2OVelahm2QqP6bJdnckYh7SNfTOey81Xp h0V+ug2NiMZ6JEIFRZSNJ4BTV46pFGg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-nXDD9H5gPQO5cpihgaXCmw-1; Fri, 04 Dec 2020 08:02:26 -0500 X-MC-Unique: nXDD9H5gPQO5cpihgaXCmw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1359DAFA81; Fri, 4 Dec 2020 13:02:25 +0000 (UTC) Received: from [10.36.114.254] (ovpn-114-254.ams2.redhat.com [10.36.114.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0DE2460C5C; Fri, 4 Dec 2020 13:02:23 +0000 (UTC) Subject: Re: [PATCH] mm: migrate: remove unused parameter in migrate_vma_insert_page() To: Lee Bruce , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <03b7c070-f23e-cfb0-3252-e85c3140d3f0@redhat.com> Date: Fri, 4 Dec 2020 14:02:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.12.20 12:54, Lee Bruce wrote: > From 810f69c5438c66aafccf18ba8f43b99b64b85237 Mon Sep 17 00:00:00 2001 > From: Stephen Zhang > > Date: Fri, 4 Dec 2020 16:32:38 +0800 > Subject: [PATCH] mm: migrate: remove unused parameter in > =C2=A0migrate_vma_insert_page() >=20 > "dst" parameter to migrate_vma_insert_page() is not used anymore. >=20 > Signed-off-by: Stephen Zhang > > --- > =C2=A0mm/migrate.c | 6 ++---- > =C2=A01 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/mm/migrate.c b/mm/migrate.c > index 4385f2f..ee5e612 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2894,8 +2894,7 @@ int migrate_vma_setup(struct migrate_vma *args) > =C2=A0static void migrate_vma_insert_page(struct migrate_vma *migrate, > =C2=A0 =C2=A0 =C2=A0unsigned long addr, > =C2=A0 =C2=A0 =C2=A0struct page *page, > - =C2=A0 =C2=A0unsigned long *src, > - =C2=A0 =C2=A0unsigned long *dst) > + =C2=A0 =C2=A0unsigned long *src) > =C2=A0{ > =C2=A0 struct vm_area_struct *vma =3D migrate->vma; > =C2=A0 struct mm_struct *mm =3D vma->vm_mm; > @@ -3056,8 +3055,7 @@ void migrate_vma_pages(struct migrate_vma *migrat= e) > =C2=A0 mmu_notifier_invalidate_range_start(&range); > =C2=A0 } > =C2=A0 migrate_vma_insert_page(migrate, addr, newpage, > - &migrate->src[i], > - &migrate->dst[i]); > + &migrate->src[i]); > =C2=A0 continue; > =C2=A0 } > =C2=A0 > --=20 > 1.8.3.1 >=20 Reviewed-by: David Hildenbrand --=20 Thanks, David / dhildenb