linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Matthew Wilcox <willy@infradead.org>,
	Vitaly Wool <vitaly.wool@konsulko.se>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, Igor Belousov <igor.b@beldev.am>
Subject: Re: [PATCH] mm/zswap: export zswap API to modules
Date: Mon, 23 Jun 2025 21:33:14 +0200	[thread overview]
Message-ID: <04013158-841d-48cc-9687-6c6e75fe65d1@redhat.com> (raw)
In-Reply-To: <aFW6xI4m15JepI8Y@casper.infradead.org>

On 20.06.25 21:47, Matthew Wilcox wrote:
> On Fri, Jun 20, 2025 at 09:35:52PM +0200, Vitaly Wool wrote:
>> There is no reason to not let modules use zswap capabilies to
>> densely store unused pages in RAM. This will allow to remove some
>> homebrew solutions for e.g. GPU drivers in favor of plainly using
>> zswap pool.
> 
> I really think these should be _GPL exports.  And I'm not sure why the
> GPU drivers are using "homebrew solutions" instead of using the shmem
> APIs which work whether zswap is configured in or not.

In particular, because zswap is tightly glued to actual swap code (e.g., 
swap_writeout()), and we should review first if any such GPU user should 
really be talking to zswap directly.

-- 
Cheers,

David / dhildenb



  parent reply	other threads:[~2025-06-23 19:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-20 19:35 [PATCH] mm/zswap: export zswap API to modules Vitaly Wool
2025-06-20 19:47 ` Matthew Wilcox
2025-06-23 10:10   ` Vitaly Wool
2025-06-23 19:33   ` David Hildenbrand [this message]
2025-06-23  5:11 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04013158-841d-48cc-9687-6c6e75fe65d1@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=igor.b@beldev.am \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vitaly.wool@konsulko.se \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).