From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F9DC4708F for ; Tue, 1 Jun 2021 07:08:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B954F61370 for ; Tue, 1 Jun 2021 07:08:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B954F61370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 232BD8D0002; Tue, 1 Jun 2021 03:08:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E3246B006E; Tue, 1 Jun 2021 03:08:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 035AD8D0002; Tue, 1 Jun 2021 03:08:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id BFE126B006C for ; Tue, 1 Jun 2021 03:08:54 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5689A8249980 for ; Tue, 1 Jun 2021 07:08:54 +0000 (UTC) X-FDA: 78204277788.30.0D9F6EB Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf26.hostedemail.com (Postfix) with ESMTP id B64E24202A19 for ; Tue, 1 Jun 2021 07:08:47 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id 22-20020a17090a0c16b0290164a5354ad0so879117pjs.2 for ; Tue, 01 Jun 2021 00:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WR3r+ydE1Ns9ygBtsSiaRQAr3k4CSXyTaNQimiETYP8=; b=rADtEdgmCPtVLRAUh7JzJ/+vJ/3a3Z1925ItFXCUt1JdcoRqbluar+SxAJkeNGME3G r6qIdWLJWEpE6Jn78SyAM9FWY4GMw2aAKDiSCKOsgLvQ01hF8cGqRW3/6w4dS6ytehw5 b1PAfiIQPxR0pX9Hg6YhWqwhvVeChw36xrZe51unywzExo1yYu2u3129udOQbNftNXyF z6fbrGXM3H15zKCJmj4Mzf9ivA6KOvhTHQZeMkZQqZDFh0jHVfBC+C8RCDVM/2Tx1+Hk ugIXoiMbg2Jvj1KoRVFlrVToos5TjOrXYb6ZmVj8O/gd+49Cj/uxfF2JkiOjcvUFWtuS D1rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WR3r+ydE1Ns9ygBtsSiaRQAr3k4CSXyTaNQimiETYP8=; b=p/svh3cMyZUxdd4g+tEkhFd1icAbspD6nbB7Qz7Saq4qgUVAz+4fT16SP17XzkYpjC TW8FNveA8Ut+e6NE3pUhyUlumuhs2f67OA3fg9OQeWIYXmeouVcX8HC8LDLT1TJA1Wpu hX77GQtUtORJiZnpKtkrh2VanpwKvTCBT24YAZjclhX2Ero92r+/M//oEpYkF7b68Ksv 6DX1JFzw6c0XEGiCqd0LRV/2/Vg6yulwFKFmxeoDdhz/S1MhXnDQdvSq69cxb1PFEeE4 bM/Udu9yZmijvDaNwWX33hJPnNUYcXP/r2ctjLDqCsKf9I2iSxdtpPhAa7IRNKxRrBR5 arqg== X-Gm-Message-State: AOAM5303VDE9FTfIrhj0pofou+187+H2ArpaNmB7D1nHPB8rFgGbjMz7 DoKxvTtIOxbUsLEpOr+70ME= X-Google-Smtp-Source: ABdhPJwbCQbRSU0axncpTGKphEGrkgWYCFiPVSqT5pqBfkUKonjSx+vS+tQcrPNfFPwsjvuYEyNPKA== X-Received: by 2002:a17:90a:8991:: with SMTP id v17mr3327483pjn.132.1622531332783; Tue, 01 Jun 2021 00:08:52 -0700 (PDT) Received: from [192.168.0.15] (c-73-158-171-241.hsd1.ca.comcast.net. [73.158.171.241]) by smtp.gmail.com with ESMTPSA id c128sm12728998pfa.189.2021.06.01.00.08.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 00:08:51 -0700 (PDT) Subject: Re: Sealed memfd & no-fault mmap To: Linus Torvalds Cc: Hugh Dickins , Simon Ser , Peter Xu , "Kirill A. Shutemov" , Matthew Wilcox , Dan Williams , "Kirill A. Shutemov" , Will Deacon , Linux Kernel Mailing List , David Herrmann , "linux-mm@kvack.org" , Greg Kroah-Hartman , "tytso@mit.edu" References: <7718ec5b-0a9e-ffa6-16f2-bc0b6afbd9ab@gmail.com> <80c87e6b-6050-bf23-2185-ded408df4d0f@gmail.com> <36fc2485-11f1-5252-904d-f26b63a6cd58@gmail.com> From: Ming Lin Message-ID: <0464f8dd-d082-b246-83ff-609f0f48de59@gmail.com> Date: Tue, 1 Jun 2021 00:08:48 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B64E24202A19 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=rADtEdgm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of minggr@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=minggr@gmail.com X-Rspamd-Server: rspam03 X-Stat-Signature: od9qmapjfsqatmg5swzdaqzoqmerkhsa X-HE-Tag: 1622531327-384359 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/31/2021 11:24 PM, Linus Torvalds wrote: > On Mon, May 31, 2021 at 11:13 AM Ming Lin wrote: >> >> OK, I borrowed code from filemap_xip.c and implemented this behavior. > > I think that "unmap page" is too complicated and fragile. > > The only page that could possibly validly be unmapped is a stale zero > page, but that code in shmem_unmap_nofault_page() seems to try to > handle other cases too (ie that whole page_remove_rmap() - afaik a > zero page has no rmap). > > I get the feeling that the simpler thing to do is to just say "if you > use MAP_NOSIGBUS, and you access pages that don't have a backing > store, you will get zero pages, and they will NOT BE SYNCHRONIZED with > the backing store possibly later being updated". > > IOW, just document the fact that a MAP_NOSIGBUS mapping isn't coherent > wrt shmem contents that are expanded and filled in later. > > Don't try to "fix" it - because any user that uses MAP_NOSIGBUS had > better just accept that it's not compatible with expanding the shmem > backing store later. > > Keep it simple and stupid. Hmm? Simon, Is this "simple" solution good enough for Wayland compositor use case?