From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1920C38A02 for ; Sat, 29 Oct 2022 04:47:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FE8F6B0073; Sat, 29 Oct 2022 00:47:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 388876B0074; Sat, 29 Oct 2022 00:47:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22A298E0001; Sat, 29 Oct 2022 00:47:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0DF396B0073 for ; Sat, 29 Oct 2022 00:47:12 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DB6184029C for ; Sat, 29 Oct 2022 04:47:11 +0000 (UTC) X-FDA: 80072752662.03.98366A4 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id 7303840003 for ; Sat, 29 Oct 2022 04:47:11 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6E907B82C9A; Sat, 29 Oct 2022 04:47:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D26DC433C1; Sat, 29 Oct 2022 04:47:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667018828; bh=30H2uNbMFKcPAqFuShUf03uMolLK4p541xhuBs+CXnI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gfP7Tdy8pIqM0v1DJqaGNtauH+2lb48dJX1fYQaIymUJ+CLtqqb7q9wwRAcGy2DSs BdOmbwNbY5OZr2xEEYKKwU2aU+9GuTOSo4R6ns36zTSUIcjAcfVL/VlZzpDeZpKME8 JwsNjTbmlK+V7B2zgQZey1WW23pzhAP58MPZ23igfVckJhNckDLUxy6puVSkrGCoRK f7eGMud7OL+mzoMFyvpYEH0blFGHNsjz3+hc1IYbpOYbQAJIjaOJ/GfqfVcPe35zvS TRnDS1nX8jY4iti+jV9+pW0OWxMZ12yvdyJjPO1eQOSLk6K/9vEZaUEfj2WxQfgeHF 1akF8W1Dj6/Qg== Message-ID: <04bf9d52-e12d-f11b-558e-a6b358e4b564@kernel.org> Date: Sat, 29 Oct 2022 12:47:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [f2fs-dev] [PATCH v3 12/23] f2fs: Convert f2fs_flush_inline_data() to use filemap_get_folios_tag() Content-Language: en-US To: "Vishal Moola (Oracle)" , linux-fsdevel@vger.kernel.org Cc: linux-cifs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org References: <20221017202451.4951-1-vishal.moola@gmail.com> <20221017202451.4951-13-vishal.moola@gmail.com> From: Chao Yu In-Reply-To: <20221017202451.4951-13-vishal.moola@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667018831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wzZjotK7+5OIJiKDi3Xz+q73wmrkLvQEzzD6ct2pAXc=; b=dwtm7mHRCaErpPEoJisFAr6drK3hWqVMYmb04jnIxMysSx4ES9zC6lv48oagjQeLa5rcgU FskBFJtWPw+LtMtuGsYmVdMgLyPbqSE9kv3xIsnGYN3SOJYIFYVsQU707+ovNDn5pCIjmx sxNfjIuBr3WXX1bMMnz2RAnqWlv7s3A= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gfP7Tdy8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of chao@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=chao@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667018831; a=rsa-sha256; cv=none; b=bzjqZGnFIYKVLg9aFFRWeYULIjkZB8i7uN7/HhuMqAfrQynH15bwRyfnYsUn+SVp0sZKxU N7/wt1CQu+0GuEQ3KE7/RNSJV/BZq2XiY3VOc0s5lMpT0VYSNADmQBUw2q0ZlbloPywkUc ZVu/a+YKnTX4y9Qdnq9xUOkmLCZf7Bk= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7303840003 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gfP7Tdy8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of chao@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=chao@kernel.org X-Stat-Signature: 44sbk6duinst8dske935f83nwe7gh6hs X-Rspam-User: X-HE-Tag: 1667018831-117743 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/10/18 4:24, Vishal Moola (Oracle) wrote: > Convert function to use a folio_batch instead of pagevec. This is in > preparation for the removal of find_get_pages_tag(). > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Chao Yu Thanks, > --- > fs/f2fs/node.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index e8b72336c096..a2f477cc48c7 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1887,17 +1887,18 @@ static bool flush_dirty_inode(struct page *page) > void f2fs_flush_inline_data(struct f2fs_sb_info *sbi) > { > pgoff_t index = 0; > - struct pagevec pvec; > - int nr_pages; > + struct folio_batch fbatch; > + int nr_folios; > > - pagevec_init(&pvec); > + folio_batch_init(&fbatch); > > - while ((nr_pages = pagevec_lookup_tag(&pvec, > - NODE_MAPPING(sbi), &index, PAGECACHE_TAG_DIRTY))) { > + while ((nr_folios = filemap_get_folios_tag(NODE_MAPPING(sbi), &index, > + (pgoff_t)-1, PAGECACHE_TAG_DIRTY, > + &fbatch))) { > int i; > > - for (i = 0; i < nr_pages; i++) { > - struct page *page = pvec.pages[i]; > + for (i = 0; i < nr_folios; i++) { > + struct page *page = &fbatch.folios[i]->page; > > if (!IS_DNODE(page)) > continue; > @@ -1924,7 +1925,7 @@ void f2fs_flush_inline_data(struct f2fs_sb_info *sbi) > } > unlock_page(page); > } > - pagevec_release(&pvec); > + folio_batch_release(&fbatch); > cond_resched(); > } > }