From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC74EB64DD for ; Fri, 21 Jul 2023 17:52:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D8DE8D0002; Fri, 21 Jul 2023 13:52:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 289068D0001; Fri, 21 Jul 2023 13:52:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 150F98D0002; Fri, 21 Jul 2023 13:52:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 088BA8D0001 for ; Fri, 21 Jul 2023 13:52:00 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B5916A039E for ; Fri, 21 Jul 2023 17:51:59 +0000 (UTC) X-FDA: 81036362358.20.9F9652C Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf26.hostedemail.com (Postfix) with ESMTP id C49D214000E for ; Fri, 21 Jul 2023 17:51:57 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="hb/3Tmml"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf26.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689961917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yxtYMtq6ACgccRQC2ibdYAFFiBesYyrba/9Zk6JcoJo=; b=w65oogwhTjheKUbWEMVaUo74zX/clg9UqJxpF4xsA7CbinQ8hTrDfib7wXvhJXxmPkPcr2 64RaCBF4onhBAauaIHf2z9jFKN8836kePUy24Et1qzpm8rZZSXjNZ9dJHYXDKUo3LdGT8S X4qmDpZvsdipGMmUD+1x2pLN+3A4sLw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="hb/3Tmml"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf26.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689961917; a=rsa-sha256; cv=none; b=wRYdvWCa8+bp7/VZnEOet4Bg1Zs7xCl/KK51WRS8K+MMeE4EnUiA7R0nT8D5sLNYfq0i4T 8DyVP/QxcVxptAkyFMA/++rfA0kJ7YkZhwMvOn9Vkj8gwPyxvqZUDIRkRcz4YV0FsRSvmq y+TQUi4jhQFpAty5eH+EEql3sL4E1a0= Received: from [192.168.10.12] (unknown [39.45.151.35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 35C69660709D; Fri, 21 Jul 2023 18:51:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1689961916; bh=DDoWRz+yUmRlcHh/cA8RW2LvkPV43c8fzdbwlgOqXBw=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=hb/3Tmml0TudHA0SnrngZDAV7m9FDd2UZ1ziQ1dY9CToxHBzlNqg1sf4BUQ2pMXe3 DZYC7IWdLwAhwS8jS2QqqmmyhgNOem6p6MSZ+rBQH+ucZG4tqBWbP0rntrri4to3Y4 3MjSAjGzGKNbf3to9oalMh9VH+wJ+2vOdQVN2zaFtMqb1IFUqxj6UyhkcK4Ze8y9JT XUjI1sncjMt8/sXvVbsw6uwEDh16us2s5s6T8+OAA3oi6AiSASvNnLsUG/4znoSrKM J5xb7TQjkFyrIw+3OnCIA6wZ2poYcI9wXDzOsCLmFqH15rMNYhKixhc8/MA5hDEtq5 hZ9wnODa0VsRw== Message-ID: <04e76ff6-3cc0-4ad3-a39b-1f39107e5f3f@collabora.com> Date: Fri, 21 Jul 2023 22:51:44 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Cc: Muhammad Usama Anjum , Andrei Vagin , Danylo Mocherniuk , Alex Sierra , Alexander Viro , Andrew Morton , Axel Rasmussen , Christian Brauner , Cyrill Gorcunov , Dan Williams , David Hildenbrand , Greg KH , "Gustavo A . R . Silva" , "Liam R . Howlett" , Matthew Wilcox , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Mike Rapoport , Nadav Amit , Pasha Tatashin , Paul Gofman , Peter Xu , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Yang Shi , Yun Zhou , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, kernel@collabora.com Subject: Re: fs/proc/task_mmu: Implement IOCTL for efficient page table scanning Content-Language: en-US To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= References: <20230713101415.108875-6-usama.anjum@collabora.com> <7eedf953-7cf6-c342-8fa8-b7626d69ab63@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C49D214000E X-Stat-Signature: d5pjk4w49cus3yedmepm4m1bgdue66x9 X-HE-Tag: 1689961917-297899 X-HE-Meta: U2FsdGVkX19BYLuv30Pxpp4oZHj7Y6jn3GNOW7Qx1Vw74ICP9QuL58X1KUwpMX7HuRcAA6m6MIn0ByIutGS0PJGvT0X4xvB79jdi7XyNAX2QL6eNllqn9URGDBNH7gonsDlTDKnl3fHJuH3xaW8msRLmrtSltKXAfJ9KIZbN5H1iLuJXxvhYIV3uGk51JG9d6BI9Afvm+YsEY/fLSrK9xDQqL7hD2QWKYxpreGmDll8JoTuJAMEYuWCVljvz9gd8f3EtY1hQC6K1UVaW/I5DFgmj84O761FGQ62Au+iODlGAXzPSbqT0oWX6M4dNhVUjtN+Z81wivzeuLu8xXYInP5o/+oTqKqCPWTnuDkbd57WGktj7yyfijm7InBE7Jravm0jp0Ifc2WAehvTt/0ejQOFaa/BaJ4lPUsPCStSz80gO/4AuyjenAj1O8fP4oteZrq69TTogenUfW+F2PdlD4VIMudvCw86JETHyNOnyqh0Wq38QtzpcqaQpoSSkZEcVTO5M9unsNGGOpeV6Yk78/Bf2EBquBxooRbUf8g63XsU0tAnItpJvaTSEHwKqJO2GCUArH+kluGDWhiTO2s4LC+EibXymIuga+wndd9szfOLcSMhZNmmqGSO0p/jRCQT+HP84wAa5WyRqEml0fAF741v/6KITHFbzPelsdxt/lfqRCo+O3Ia7YKTAQlZoYDRTMvde2uqWwwk2LVZ4apIqiurxzKxYgZ8IcTPxZRMUtDwk3plvOhsplfxUC6zjqaxqHiVcblqTomiRDZJEcwJswyIWN3c2F92gJAEJkG/egK3DKOX4m/JYfhqZUHpi0C0+jGe2zSdFaFHA7ylf17pVBesBPh2FQTN2fr9k4rogV89tieW5Wu6VElSrKn9K2bbXvTWK3cRDUiBffBrsUJ3LdkPSI2fc0vc0MMWdk0Tl2TdwgX7GpVcKrR637wVdo+aFRWaa70h1rb0cjnLGCsR El4tpK+5 02bO8YoDNHCyQiEUKufgPtQhfiSJOQ511VEmkVzCOnwdrJk0Nx5aIALVwqCQJN/o4EyIfl9ruWevorp5QwbArN7cHswb3WdEKYL5X9dn/F1fYHtLJjg82PEPJeRQXHWG6Cj0UH/trSARY0XC6PA+JVl3nBMIulYJtdftXXe51OcF9290arsOUHvnf2AUu/c3FgLuaNTBp8ul78YECwAnWBHl8oL8fjqHnpz94RrYluEX0g4pwc9VFPwIQPM8NIOSuIa5y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/21/23 4:29 PM, Michał Mirosław wrote: > On Fri, Jul 21, 2023 at 03:48:22PM +0500, Muhammad Usama Anjum wrote: >> On 7/21/23 12:28 AM, Michał Mirosław wrote: >>> This is a massaged version of patch by Muhammad Usama Anjum [1] >>> to illustrate my review comments and hopefully push the implementation >>> efforts closer to conclusion. The changes are: >> Thank you so much for this effort. I also want to reach conclusion. I'll >> agree with all the changes which don't affect me. But some requirements >> aren't being fulfilled with this current design. > [...] >> #define PAGE_IS_WPASYNC (1 << 0) >> #define PAGE_IS_WRITTEN (1 << 1) >> You have another new flag PAGE_IS_WPASYNC. But there is no application of >> PAGE_IS_WPASYNC. We must not add a flag which don't have any user. > > BTW, I'm not sure I got the PAGE_IS_WPASYNC naming right - this is to > designate pages that can be write-protected (are UFFD-registered I believe). PAGE_IS_UFFDWP_REGISTERED or PAGE_IS_WP_REG? > > Best Regards > Michał Mirosław -- BR, Muhammad Usama Anjum