From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A499FC5AE59 for ; Tue, 3 Jun 2025 07:58:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40F9A6B03CF; Tue, 3 Jun 2025 03:58:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E74E6B03D0; Tue, 3 Jun 2025 03:58:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FDAA6B03D1; Tue, 3 Jun 2025 03:58:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 127236B03CF for ; Tue, 3 Jun 2025 03:58:44 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A94C21208FD for ; Tue, 3 Jun 2025 07:58:43 +0000 (UTC) X-FDA: 83513337726.14.29843EF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 3AE8B20006 for ; Tue, 3 Jun 2025 07:58:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gWechPIa; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748937521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CU0N6UgF0Wu801mnXgPiaSIy9UpUp1v4ajkhrRpQ1f8=; b=3ukQmr2wO418byixGwC5Lel7dBRJkVvBEY8iyyepEKOJQQae+SNlifI962bP8aCUTBxYbi zgrP+3KmVFPB77xBLXPZR5NHRmD1zecqq8yWY6qW27JKbMhTTcx0Fd7bRnulnA/NlAuWFJ iHzHIaZU6vjeoEY8cmSUynbi72BNU14= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gWechPIa; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748937521; a=rsa-sha256; cv=none; b=p9V0gHOJczDAifyOVF5+uR3ITzCGTLdnxeV7w5MYNsM4vMXU0+0iB7T5UbXvVXjfGNy/ko Wx44pCp+lvry00CW9I+a+UneLXsE4TMpUfb9+BTURpVQHHfQlML67Mo8PpiHszFqYNZzLo kpMPBUABX5rxDw8ovK9Kcz945OKo26M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748937520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CU0N6UgF0Wu801mnXgPiaSIy9UpUp1v4ajkhrRpQ1f8=; b=gWechPIaKg3cfG4Aw1SwO+HjAchk8QLcqDTiepGPsuJ3UIzDaeTsz/pREmYWnwJiSxbi7t jKvIIn3HuETuA9Ieff4wetHhpwpdAWoMjQuXqqnA64DEumVgl1nSZ1Z1JZkOEqLQXbkBEK FOVj8ySqg1kh4OcWPeOCFnIIN7kJ2Oc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-10iS_ZGiPEqc0pdlyGT-jw-1; Tue, 03 Jun 2025 03:58:37 -0400 X-MC-Unique: 10iS_ZGiPEqc0pdlyGT-jw-1 X-Mimecast-MFC-AGG-ID: 10iS_ZGiPEqc0pdlyGT-jw_1748937516 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4517abcba41so17458715e9.0 for ; Tue, 03 Jun 2025 00:58:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748937516; x=1749542316; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CU0N6UgF0Wu801mnXgPiaSIy9UpUp1v4ajkhrRpQ1f8=; b=cfaWJ24sqRnBClpqhbs1qFXdmHksSnl6c1p9tTz/4Aryy892OY/aMRPPFwsAZvwGJY l7qQKm0MwCnQQc1JsP6jWxb0d7FaMM0DDuQPrdBlPZt77mMWAC0vdKFkxsNq6tjIR7su teubzHsqtONyvcg3AadXKyBqNw7s77JtpT9eqXPudeVG7N1/7WEdcZzJMFm9h7sgew4R oVZxrWSq/2lrAVt7h+Ei8Xln5kEC5gxn9IEmDAzmRZ95VUVMk0sydx1cTOZdv4+go/fO tmnc+vnrUq48Ac5SsP6OvnN9nmEsCB/uro20gOAo2TFoCm8BnZC9UQnBBW6+d01e57fn zD4g== X-Forwarded-Encrypted: i=1; AJvYcCWWOH9dSo2NdWKy8CedDiV73xdphsdrGFV+sMe0NTOXxMG2dNbRyxObDBmB+Hj4xdewJxQ03/F4dA==@kvack.org X-Gm-Message-State: AOJu0YxDSl+0W2ddXHlY+KhJpfvYoqifY4Q3YmjN6v4DC4YYSqPfuaGw P0w7qwcEpsKZP6KIZgL3KSSYhX2oYUXqngZUpat73oEoVjkmwgmEJ6IQUHPcxhmv7pindr6yvUe egD/gI4YIbLyDMgDDM52GAq90OBh96J7q87o1LdoAQ3ovMENN78Tl3WGTeKuOj4M= X-Gm-Gg: ASbGncsiyqAxHb8Dkx06jf6qMejrVWWBbJRJPcd4b9G81+/UulwTRPbWgm4nrM5fE6i mzrM2QzdvjYzHDdbT7f+TJDa0iF0i2V0UHAv4YW2H+lhgP1VuNZ4+4Ete73r8xUi7Ra4i+iYzZe yQohHRmICTY7w8hegyqBJbSMedMbaHMJEIeI2hZT/uKaVGAmBt0kDcaKHggjkdXW6EVfynLm6Il cSi4vnzpq5d81g7JNEB0k3ftXN1EP500EOGlVHffBnQoeL2dkuGLYL56OVWk91rityVjhGWM/Qz 3cTVJynI03zrSpMVk11TLzXdVvW8m7h4j6ssmPL8PRNNEnP/dioQWAHUojse7Vqqy28n7R8bJR8 AI8kriVuOudVtF6muMzK60dDBptmON0ERPTu8tCU= X-Received: by 2002:a05:600c:3e83:b0:43d:7588:667b with SMTP id 5b1f17b1804b1-450d8846c1dmr174157485e9.10.1748937516072; Tue, 03 Jun 2025 00:58:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFuF8+vnhtRNmRyCVVcDcXRSlMRzaw2IM+WDvELnB/XLtRFKZRwQLOj0Esqbuh3xRvpcNyDMA== X-Received: by 2002:a05:600c:3e83:b0:43d:7588:667b with SMTP id 5b1f17b1804b1-450d8846c1dmr174157115e9.10.1748937515629; Tue, 03 Jun 2025 00:58:35 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fb00ccsm151727445e9.17.2025.06.03.00.58.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 00:58:35 -0700 (PDT) Message-ID: <053ae9ec-1113-4ed8-9625-adf382070bc5@redhat.com> Date: Tue, 3 Jun 2025 09:58:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xarray: Add a BUG_ON() to ensure caller is not sibling To: Dev Jain , Zi Yan Cc: akpm@linux-foundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, anshuman.khandual@arm.com, ryan.roberts@arm.com References: <20250528113124.87084-1-dev.jain@arm.com> <30EECA35-4622-46B5-857D-484282E92AAF@nvidia.com> <4fb15ee4-1049-4459-a10e-9f4544545a20@arm.com> <8fb366e2-cec2-42ba-97c4-2d927423a26e@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: E4gqqQ9YvEBZW6NtWVLmheLPQCf9KbsI6OylNrDUx6A_1748937516 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3AE8B20006 X-Stat-Signature: g9dmsfq61yqow9q6g63szr5pyh1gjezx X-Rspam-User: X-HE-Tag: 1748937521-620757 X-HE-Meta: U2FsdGVkX18BU7eLo16yC7c6EWaG4dZ6Rf+XM3n7xylVQg+DTekaqB8Wh7o/STCHQePt6H9eeC5A2EtmVe592RGAbyYGTOYTjEJ628neIoP7ON+eNys0i7rEx5cpdx4f8NoUjSieKDFO03g6KmN66UThW2pQwKjElUYKaZCqR1w4tsIdYQui1IS51a21MBMfKERW3qUsD+9w0LGnDFsy78GYZDXLGb0x9N67igFyJsgK+wKCOjs5aFwxDxeY0v0pia+FnqasU3Ft/TA020F9qaDjr7coG3wkXPZRujEGcm4wWuJ/lSBT8JsWzkv2bAr1KXfGiLuTcn5Z7p5iBCznMLeyiFeAvbLUbthZ7mtRQNi2uJLBnPTKNCvf5x2EwHnFzKFCZhsiJ3lPS+jZMmd90fqv/4cjD5SRxHAQeCzlmDFl2Cn56RerH1IuNa/VfsJIkLPKiBOu+yZfE8Oy7iwauUh+1qsFwWDRpCFvPgQvv8K8AEBQXSkNS1E+wYKcvmG8V7Cii/LrP9Ue1aqEIqRHuopu+NJAlzblKg9CsFwZ42uIrJsBeXPhaecHruNdGCe6izy/o3aI9wrlLq3TI3pHKfCW/iZpX0z4OsyOlpKYnWQyUzkgVFoQ9kpwWIFvZEPZJrrXBGI2fryoNCUHefyVjp5Xmt3oh+83VopyOKOFTA4+K/CIswKAG55do9E5f88u5FtPuxE4gAAZkmsrSIJEaIh+J+aKmiK7Pyi0fjOB6Dxg+SejAh9sJzULlFeJktYxQ5wTpKlquq/As1JQNqERu3hdXCi2K9/h1W/rolOsg2wf07hvESmjF1R6MLxtEshtDg/wHUKImO609bZKlNpt+XpsPy8ajf/8AbUGzdV1dlpQexYKgRosJCbUnACdMoGTdpjnsaDsUkwjoYM4hKxB9um/m0bgi9IJMi/1wPDroX/7kxz1YHXmcaOtieR9/qEbz9D/bzIUnxQzAdKyXSu mDtuTa/i 3FWUNus99WNIhTzDAZwJdZMYSv+l4ubp5UBg54DkiSiZ9OyebnEcW1zTxHxmXb3N35UXS26Lb1mvzqbMWtlVq6DC6lxX5PXVCrJM97dU9qDY4IyChmSXwXojLdmFOyW3HpzTgQ2A8VvEgCsEEENQCnbEjHEi0sODNJpm5K+2GMkdFTa70DDqJ0EASk8VbyfTzvjJtGB3jbg6jZujVf6LyK2C5Yz6q5OQuXkaP+xHUWED5gpfhBV1pCStISIvUeC3JBC5p4YwwQ5XLDKjt7tkp4CHXSWXS1kdxp7KWjq5Axlm5a1hlJCXBj6Y00XPrkqFC7S+lfi4uGSzzXm/aYPrB/04SgVZ+qrX3y6YZLD2TfDN2XFb8Zxjy/N9VgVGrITiwuIqM+bOL5+PFa2CkibxiHTVPCvqizpxqdRL7QuGGkqmrUFfszvFqiGixVgswbyeHcdfRJDOHkyQDubiZJIi6wetbJhZoi9S+DyrpxQo8/vqy8K5k8NTIAhtK2jCetkCxopqE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 07:23, Dev Jain wrote: > > On 02/06/25 8:33 pm, Zi Yan wrote: >> On 29 May 2025, at 23:44, Dev Jain wrote: >> >>> On 30/05/25 4:17 am, Zi Yan wrote: >>>> On 28 May 2025, at 23:17, Dev Jain wrote: >>>> >>>>> On 28/05/25 10:42 pm, Zi Yan wrote: >>>>>> On 28 May 2025, at 7:31, Dev Jain wrote: >>>>>> >>>>>>> Suppose xas is pointing somewhere near the end of the multi-entry batch. >>>>>>> Then it may happen that the computed slot already falls beyond the batch, >>>>>>> thus breaking the loop due to !xa_is_sibling(), and computing the wrong >>>>>>> order. Thus ensure that the caller is aware of this by triggering a BUG >>>>>>> when the entry is a sibling entry. >>>>>> Is it possible to add a test case in lib/test_xarray.c for this? >>>>>> You can compile the tests with “make -C tools/testing/radix-tree” >>>>>> and run “./tools/testing/radix-tree/xarray”. >>>>> Sorry forgot to Cc you. >>>>> I can surely do that later, but does this patch look fine? >>>> I am not sure the exact situation you are describing, so I asked you >>>> to write a test case to demonstrate the issue. :) >>> >>> Suppose we have a shift-6 node having an order-9 entry => 8 - 1 = 7 siblings, >>> so assume the slots are at offset 0 till 7 in this node. If xas->xa_offset is 6, >>> then the code will compute order as 1 + xas->xa_node->shift = 7. So I mean to >>> say that the order computation must start from the beginning of the multi-slot >>> entries, that is, the non-sibling entry. >> Got it. Thanks for the explanation. It will be great to add this explanation >> to the commit log. >> >> I also notice that in the comment of xas_get_order() it says >> “Called after xas_load()” and xas_load() returns NULL or an internal >> entry for a sibling. So caller is responsible to make sure xas is not pointing >> to a sibling entry. It is good to have a check here. >> >> In terms of the patch, we are moving away from BUG()/BUG_ON(), so I wonder >> if there is a less disruptive way of handling this. Something like return >> -EINVAL instead with modified function comments and adding a comment >> at the return -EIVAL saying something like caller needs to pass >> a non-sibling entry. > > What's the reason for moving away from BUG_ON()? BUG_ON is in general a bad thing. See Documentation/process/coding-style.rst and the history on the related changes for details. Here, it is less critical than it looks. XA_NODE_BUG_ON is only active with XA_DEBUG. And XA_DEBUG is only defined in tools/testing/shared/xarray-shared.h:#define XA_DEBUG So IIUC, it's only active in selftests, and completely inactive in any kernel builds. -- Cheers, David / dhildenb