From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C646C636CC for ; Thu, 16 Feb 2023 12:53:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBE736B0071; Thu, 16 Feb 2023 07:53:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6E926B0072; Thu, 16 Feb 2023 07:53:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0ED46B0073; Thu, 16 Feb 2023 07:53:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9DBEE6B0071 for ; Thu, 16 Feb 2023 07:53:44 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 771FE406A7 for ; Thu, 16 Feb 2023 12:53:44 +0000 (UTC) X-FDA: 80473146768.30.20D73D4 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by imf08.hostedemail.com (Postfix) with ESMTP id 7F702160009 for ; Thu, 16 Feb 2023 12:53:42 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=oauL0G1T; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=t24p3UPW; dmarc=none; spf=pass (imf08.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.25 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676552022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DbrLQv3/pVtTQOZWpqNFqEWPdA+pKJ3lEDwvQXG6DB4=; b=TDnMVs6CQqFEL5hC2kL9pk0j82dybFD6D9bjqFGdJwypZ8YSNUkdMRMj2zcVVxXxgZw4Mj /ud+V1D0UA6LtXNKQTJFFL7TCFaH3bg9UbBgm67t84jHQ5vL+fmyDByPEzSYVn0Ot1Yw71 cmlDatcwo5pAa/iCV/I1c7RE4W9E3xE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=oauL0G1T; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=t24p3UPW; dmarc=none; spf=pass (imf08.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.25 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676552022; a=rsa-sha256; cv=none; b=V4Qsgto4svQGyaCjBPcdok6at6mlxLf1+PmHN5YEsKo2t6zuQDN7/6SgTEHAVfjvbIja+K CW1uQY8mvBC8yriD6ZK6K7FE2g9T9UGbc5SErLrl5/Nj4+yZpKC3a1YI9siM7TqDvJE9Fc EUGlW4E8IbG4DxLmbNIA9fBRskc9Hnk= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6B9865C0182; Thu, 16 Feb 2023 07:53:40 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 16 Feb 2023 07:53:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1676552020; x=1676638420; bh=DbrLQv3/pV tTQOZWpqNFqEWPdA+pKJ3lEDwvQXG6DB4=; b=oauL0G1TRIlgWSz7p8TU8eHziQ UmDyJnfH5478eg3C2PjAxRr2fBk8tvZ2aV8nQVdeXDG1OFRJpOjNnlO9RC8YbKJP 6u1zBU2soFfeEQJO14Ukd4ELMdGyLuJvzsEB/cM8m/ipQPhZtmEk4KESmv9Mx80d +7CYqkOL1aRdBego+2AwNSxvwG8uOgDerQ/vKHnRkcRLzgHV8Z7V7CvoclxqWxg+ l6WszlcPqwYonGkhmfTkxXKN+zOTqWDJ1ioOfnMvo0yxIM/bCEhHnQW5wz7g6vmx qLe2iiMtWJzRJX5db2PRKzbGVpVoTEcsCKrq6S/Qk2nSu7TafxzpMGJBl65w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676552020; x=1676638420; bh=DbrLQv3/pVtTQOZWpqNFqEWPdA+p KJ3lEDwvQXG6DB4=; b=t24p3UPWYZ+KCYTj7ighSAiKBdig04/acVYEucG1LfC4 R+/g9buHJlnRHfHwUN6OzexDtYT3jkuzmFSDMOqGAUD22GEtjYS8jN9WQ69MugDM opv8xT4lHdUKFD+LooI2oT5ogfLpPO2fLFJu1XHPyGPhIfZoBxKMnDLm38rDTVoe N21pYlEAdqUrqCv6JQQzpS5Wfes/swSdZHYEAFCZqRpFmKJ0N6il6X77AAhXE/6y vgxa89YBjC2wZzlhiZOjc6AYdZMxhLvol7Yxo3a8mfOfwWeb9GW/MHqdxXYcGhfO wP33vY0sSgAwMiw5dLQsVwGReJBlmf+ToqipESJ4/g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeijedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepvefhffeltdegheeffffhtdegvdehjedtgfekueevgfduffettedtkeekueef hedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E4E50B60086; Thu, 16 Feb 2023 07:53:39 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-156-g081acc5ed5-fm-20230206.001-g081acc5e Mime-Version: 1.0 Message-Id: <056cc71f-7fb9-4d38-a442-a05de6f7d437@app.fastmail.com> In-Reply-To: <20230216123419.461016-2-bhe@redhat.com> References: <20230216123419.461016-1-bhe@redhat.com> <20230216123419.461016-2-bhe@redhat.com> Date: Thu, 16 Feb 2023 13:53:21 +0100 From: "Arnd Bergmann" To: "Baoquan He" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, "Andrew Morton" , "Christophe Leroy" , "Christoph Hellwig" , "Alexander Gordeev" , "Kefeng Wang" , "Niklas Schnelle" , "David Laight" , "Stafford Horne" , "Brian Cain" , linux-hexagon@vger.kernel.org Subject: Re: [PATCH v4 01/16] hexagon: mm: Convert to GENERIC_IOREMAP Content-Type: text/plain X-Rspamd-Queue-Id: 7F702160009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ztkb1yczwytkzjn5bh3pozgqs4m7mtke X-HE-Tag: 1676552022-138405 X-HE-Meta: U2FsdGVkX18pJtA5GGqFUCT9BT66HIIRVeGUMMytELjG+cVrrF9ev0hyBoct3HSKOZFTtciScBx3WXyBSIPd0gZmIIXqldJTdEsW7Oi2/X+nmjrLVPOPa94Vk5IOJ2XUor9EAjUnchTEvFysoigwnY4fvTT9ziT0xdpm4bQ4FGE/udNYoSqYLzVpxutRjnmNLZOxsAsn8OFXY50EXnuybYhVUftmFWt80EMbWQAJTFHJFZ/geq/s5j4GT95yWZ7dsGh8ivZ7htWKHTcd2cHijgVgxZFIHzyvtg7F/dgw/oMMrc6EVB+Qbt0tyf+B7K/nY99ssg0+cF29kHST7qpSkcxmgb5oUYuYEKCmpRwBxionsrBpHDmqRWrEgvnIvm8Dkj5RMg9ZHp8ai6kC0zYAxa1yXhTUsSqMum9V2AQqnOj6vMUK47BIRaF8BxPlK3DQ79Xs/MsvZf5wg/kYA9aXqPvBRS6kvTqj/V+jMkmbB4okjrOLmV11eCYW0HhYJbC+g/j66PW/Qt8LoVYrgrktI6Jz1SEDkyrCqErNZHEt9ah5JLOWhXyBIyle+bZEjvpOHA9HnkSSJPdsE/O81oQ0bHpktuPMVLLvOSLS6E9XMGJ8/LeYJxERdSXf/LXgfEwjPZ674w25/3H8/4ZYbiKh0emZc9Eb/8QeLAvFm3et6XX2fTrgaL73DAVkrF4L9FEzAhoMltXDci/w9wRt2eEyBf6osmAm0MelD82BFYRy0OUfYKGlUigKejqnitIzjD7bnQTQyieKZTRvscLhWGq9Hgm8hB6JcYtrYRbJZPc/LPrZ4dOgWbKyN87kmZEdQ/LVanaRDOGdMit+6VggnhdJcyFya+iDSAO3RE+hnIQNn9ymfvds7gfNpbydjEnDOt7Ht2y0AyDB2Y8vZsZGP4bsLvSB/JyF2c3UaB1tnB9gxQqBvyr6zw8X1FAEmROfIWy5MVHvGFy2dwnttKKKE5W +GjppWWx JQ2AZW5B9kN6UnwFoRn61p6lLYDVO+sZGECKcQ1bb3AUPTft0ca+g3SLOiZAiOUJ0Ff6XPuOd7KbZjeOwa6kXhnutwbjdte+fSYbDmXhhJCLQN/z6V7f2fhTwBXufTYRzUNhq0JoQI7mNObinQ1VbAWFcNWWasC/QAY40kuGkYSPmWgZA7VwHOdAxTx9O4BCNqbDY1OpYzqxoklnlcQINez3a2K1LRYt6mb9PMv/U5wYJvE5ArmzerITrTPJ2XTwTy59c X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 16, 2023, at 13:34, Baoquan He wrote: > diff --git a/arch/hexagon/include/asm/io.h > b/arch/hexagon/include/asm/io.h > index 46a099de85b7..dcd9cbbf5934 100644 > --- a/arch/hexagon/include/asm/io.h > +++ b/arch/hexagon/include/asm/io.h > @@ -170,8 +170,13 @@ static inline void writel(u32 data, volatile void > __iomem *addr) > #define writew_relaxed __raw_writew > #define writel_relaxed __raw_writel > > -void __iomem *ioremap(unsigned long phys_addr, unsigned long size); > -#define ioremap_uc(X, Y) ioremap((X), (Y)) > +/* > + * I/O memory mapping functions. > + */ > +#define _PAGE_IOREMAP (_PAGE_PRESENT | _PAGE_READ | _PAGE_WRITE | \ > + (__HEXAGON_C_DEV << 6)) > + > +#define ioremap_uc(addr, size) ioremap((addr), (size)) I think we probably want to kill off ioremap_uc() here, and use the generic version that just returns NULL. I see that there are only two callers of {devm_,}ioremap_uc() left in the tree, so maybe we can even take that final step and remove it from the interface. Maybe we can revisit [1] as part of this series. Arnd [1] https://lore.kernel.org/all/20191111192258.2234502-1-arnd@arndb.de/