From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EFF9C5B543 for ; Thu, 5 Jun 2025 08:12:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A7E36B009D; Thu, 5 Jun 2025 04:12:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 057C46B0124; Thu, 5 Jun 2025 04:12:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAFE06B01AE; Thu, 5 Jun 2025 04:12:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CED0C6B009D for ; Thu, 5 Jun 2025 04:12:08 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7297AEE949 for ; Thu, 5 Jun 2025 08:12:08 +0000 (UTC) X-FDA: 83520629136.10.C9494E2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id EDCC5C0003 for ; Thu, 5 Jun 2025 08:12:05 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bTaXK+XL; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749111126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aGysovsvSFhFmocooEY0x0kn//BwNRfG7TQs4Li9A7s=; b=w7UbBY2G72DyRkvLa6V6R4qabmpuYR8VwX7BwbqqyZKPTxxUCRkwB2dtEGNzKRBChhKEmt 4tdQfed2XtWrKdj6FPpp5vAlF4gmoA0GekkZg2faP6red6pkeWYmzAF2j+LYAjowWx8PuH R4cjkZ0XWGPyU+HBJMQ7kQZRYVwDXec= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749111126; a=rsa-sha256; cv=none; b=ynfj9s2v3Lt+TTiwRxGTiDsuNnu3EpuqkhGgj8egR4V/QoDdCaORnLKLkVA6f64EBMancH z2jso5EW3UYF+zZ656NkLFmm6XiUEj5FPKWmSPnT+rbGBkNOY9EzFDfva2RFeNdS1jQQeh zKk995eamKu1SykCH2vg2HeUqGzxw4w= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bTaXK+XL; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749111125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aGysovsvSFhFmocooEY0x0kn//BwNRfG7TQs4Li9A7s=; b=bTaXK+XLUcGyQngJIFi1G6oYqPLEVyOviN80YKfxzP2Xo1oJkZhRVt3JKy5kfc76pCAXEZ 2PYHes/213fKysp8nK84G5hb6udwVzNBBWDJbGCpZvC2uhC+HbNLgjanEYvOt5+gDtX6pm RTlZuHfSITUnWO6AITTFmlhqlu+11rE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-rptJDVrqPES_vsnHHNfZMw-1; Thu, 05 Jun 2025 04:12:03 -0400 X-MC-Unique: rptJDVrqPES_vsnHHNfZMw-1 X-Mimecast-MFC-AGG-ID: rptJDVrqPES_vsnHHNfZMw_1749111123 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4e6d426b1so900390f8f.1 for ; Thu, 05 Jun 2025 01:12:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749111122; x=1749715922; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=aGysovsvSFhFmocooEY0x0kn//BwNRfG7TQs4Li9A7s=; b=ca9Nd4p5cQR8OSp7k/iF0ZGypHCEM7doBHAcTPFza9eNfjHUi4bMIlCwsLXSBVZ2FW 7ANxgWqZ6ZchLjdFqWfy40YyW48hcpdMvylhwK6G85Gfk1UyPAD69eqOxIx9R2phP+IX zxsHEyL5rJ/yfkPcRIwyJfO9ppwi1mqIP2cae6KwcPft5HQAYaGI/MMcmraRh3EUlE1J hhveZ8AV0qKqxumorKekV2o71w0gQ7DTcQDFZ6dgO1eEQoh2/xiMEmm1DiipgpbhUKpt hrhAls/hTNgKSZtI0K0kPik37JqyKiPyXyrMKXdcVjw3CVLKFxRgcuuWp7R+BPF6Jhma ij4A== X-Forwarded-Encrypted: i=1; AJvYcCWKGVpBFB9MZjGhdwOKied9TXspnIM8rlRbvqSC9iYathIQLvhntDM7F8JyjgGnD9eAYfi2usndTg==@kvack.org X-Gm-Message-State: AOJu0YyvHOXTnXcHarNW/dFP8D1Cdfu2FCt9vDritL1qU6RS4NM7CYby 7vIMLKyO2gicgWWjm4eKZu8GvA8UGwYSPDILK6dNjYlm5EBXd1CBgwY5Ij88geHPbtOT9C9Ok/d 2CAtXudZatQP0bypzPrlI96MnKSoyhsSUYWx2gAqB8a0lViBEV1IXXBsANly7S3s= X-Gm-Gg: ASbGncuB8DlkxqRs3s3b/z3Xiq6Co8cGBfI8gVRbcEVbRix66/aIo3/wNHZr9L86f+a TT/FTkaCjL+Y5HbxKEpkfJhvsvvjDNIhf/gedgzPuthv9nwq5TUtizQb5akUcsV+IsHum8THJP0 aKtG9Vc+/PX6tu0t0UZK8pRKlYB7T167ZBlH/CtSS71jqjlaTRGrICGYTSFP2BnHH6U0w/0VCSP Bhh00CBDmXYukWkAClbVnTIbgzJhD7z7vqVew78U3Va3Y8mYqYw4KZlguBmye9rA3fUnZJBXU9Z fHo1egPQY/o6eZON67ISCVV9lNM2KdRGVuita6B7fdm+fw7pivRMxG8twsN9Zw29lQWnuIKa4JY bJfm+nYq82PIbFvlVfVd41Qe1MIZlFVw5B36ELKYJDCvEKSw= X-Received: by 2002:a5d:5f51:0:b0:3a4:e61e:dc93 with SMTP id ffacd0b85a97d-3a526dc53e9mr2106819f8f.1.1749111122612; Thu, 05 Jun 2025 01:12:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcU5CzNqzvXoSvX3HTznxyYrcaaBp12FMjtapttNNs0veytGDkx7moKmOt950sPzUrUeBIfA== X-Received: by 2002:a5d:5f51:0:b0:3a4:e61e:dc93 with SMTP id ffacd0b85a97d-3a526dc53e9mr2106796f8f.1.1749111122277; Thu, 05 Jun 2025 01:12:02 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2? (p200300d82f27ec004f4d0d38ba979aa2.dip0.t-ipconnect.de. [2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451f990cf14sm16149545e9.25.2025.06.05.01.12.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 01:12:01 -0700 (PDT) Message-ID: <057fc1c1-7285-4656-aaa3-9a18d2e8f34b@redhat.com> Date: Thu, 5 Jun 2025 10:12:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] mm,memory_hotplug: Implement numa node notifier To: Oscar Salvador Cc: Andrew Morton , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250603110850.192912-1-osalvador@suse.de> <20250603110850.192912-3-osalvador@suse.de> <9a845c21-5cfb-4535-97bd-0b02f5852457@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dZxbcm4rl0S_CYGojCqK9idUAkq_AvRLJYvPwMZiSw4_1749111123 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EDCC5C0003 X-Stat-Signature: 6ohcktw77a4byf8gaw1sth7qqcphh8zw X-Rspam-User: X-HE-Tag: 1749111125-403137 X-HE-Meta: U2FsdGVkX1+RsLKcFdQqb+d/oJnXWe35UY4E7rHaUtBikavhkUkCSOKy8hgfYSD6BBlCGhe+LnwLiGu4lWZY1N7cbonTWKdp8cpxfcT7vN7QuX49BmBNrpmtgZNauWWvTxS0uDZdwbHF0PoB1zUvg/HEVmFCezqXgZjvCL1YtL5VZGRy6a1SGQgMNLNYPgiYimuKXNz5cWVJek3gcqSGBeT3UWGjs4k2axRhVRvqf4l1QSNvQsSwfZKU8jz27+pzZ7rSEFe1WwWNORmuy6ZILalNBrhEJCkhhKNtdsmQRINqNDDnlQCOB3QPjTKtvAmjfZ8UUAqEYmhdL/byu47j7ymRS99XLvbPKczfpSr70qFTlHCUDSS8IIo79eGpNygfOFYTnZzX/c9a86V08qFK7T0gnPLvQDTBGbur5wxHFFYKTb66CvObwrc1NNx430VleJMRTiAGoWTu91e4dxsZOK51GSEIJvc62+7/ie/af//NjF4cDw49t9ncJJTXMDho24cFsh4NRD42PAXDyuFjG2juYfhkUCnkfH3E7ICzu4gRrCdHS7xsDI9H0Q4fCAznTWAadukm5IgFnFMs48ViEq/9dbrl9VuHmQ6xMBHulRk/oC52aFzT9xKoAG+b4KdvC1/R84fsvTiWWjjdBmpkI0moAMiozeNR5ZmYNgWuPqoAXSrapLygx82Lb2DtJXc+77Ozlc09jnUybh0N8X6+l8q8iwspERNawUOFVrQeIEhmesXNwwtmT5k6ptJkzg5W3MU+Au6rABcpvkUVQ6QXVZkH22KiZv051N3VJEws9eZtEg79JdeX+iSWKObbihR6B7Aam2aOW5wq7o9gWO6g7LlK4wj4SFYXgLmJEQhbOIxC39Q4kpOdPd0OUllz2yWBDl+PrnFHj54d2aqiwPv2dNo49zHASAnJGXPPG+A/StHyo+o9I1au0+bjCeH4b4zfI7YXdue8I3cq0LZ7V3e zeVB3ix1 2OfclN8bVXLuKLM9hWJRbR6buQ9O8OwWO+gdXoy1FOIHD6Sz/ge3XmFF+PMXRwPPriyc1C5NcsJWckkzMaVYDNheDWv3I4vDv+gMhJXUrRrxaTf14R3Axbeww1As5uCGRm/1b3feke40/3wP7C3X8o7Vr/cOayHtnVhJ2v9vIbm3WYGo+0RA67yTcym5aT92RIibai79K0Z7m+LF6SYDNcEjQ+HIoAht9NbKsic4ThI6U6HQ3Fm8zzImHZCGsELmoPnOZGlijsQN/M0rzaPAWrGEGA5/aOP9WjGFanIt1XVmzz3qks8GJ3gt8Nry3MToEkDAV75f7JhJpx+LeZg6A/98wqUNTRsXuCj5gXhYKInCfZG2cFSMV4sqJCz14mcGFOEj2dmqgXZyzjSTBPUzI5mZ4klGuD3bBr0RLXRtRHwN0cF9vQ6JJzjqWI9TJvMpnzVIa2sz9m+DE/EMaGqcbh6gi27fL9ii3ujN6PGOhqhJssMK37qt7hYcQYfNohH2g7Jgrf8dxdy/yMwk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 07:18, Oscar Salvador wrote: > On Wed, Jun 04, 2025 at 02:47:28PM +0200, David Hildenbrand wrote: >> Just to clarify, these were the 3 notifiers each that belong together. I was >> not sure about NODE_CANCEL_ADDING_FIRST_MEMORY vs. >> NODE_NOT_ADDED_FIRST_MEMORY. > > I started working on the new respin and the moment came to make a > decision about this. > I think I'd go with NODE_CANCEL_ADDING_FIRST_MEMORY, for two reasons. > One is that memory notifier also uses that therminology, so I'd use that > one for the node notifier to keep it consistent. > Someone could argue whether we are perpetuating a bad decision naming > though :-). Works for me :) And yes, out of both options I provided, that is the better one. -- Cheers, David / dhildenb