From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA252C47DD9 for ; Thu, 28 Mar 2024 01:59:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AC366B0088; Wed, 27 Mar 2024 21:59:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55E426B0089; Wed, 27 Mar 2024 21:59:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4230F6B008A; Wed, 27 Mar 2024 21:59:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 22D6A6B0088 for ; Wed, 27 Mar 2024 21:59:47 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DE574C0E0D for ; Thu, 28 Mar 2024 01:59:46 +0000 (UTC) X-FDA: 81944791572.21.EE8451C Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf24.hostedemail.com (Postfix) with ESMTP id 4E02418000C for ; Thu, 28 Mar 2024 01:59:43 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711591185; a=rsa-sha256; cv=none; b=KHuX0gHgLPPHCJ97Y6SzIH6jXRcrULj7vqyF/lJuwStFtrZUeOvHP0XlS9IyYRTPchsZ// lSMkf3zpzYTG01ApnOTu6nvZVHpQFjmxkqMZUekTR5n3Z/Enz0StnF+V8veubcRzuOGEE0 weqW6ZlhktRIs47rOYT6vebF5JsjdNQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711591185; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hbtpxPCXTVTl7uX8Af6Csi1f2ppTLkErls9xQwFNHW0=; b=W949N9ilzGnqgl4xG+GcLMHT6pxxCGXpNy+V3rwB+KEQCW7NLd1kcGSm1fxCaUCEX+oaas zf1EkOHzINb02d8vLHm5N8CQw6y8s/MBQpULthD79K+cDLTdUlWBMEznGGArxSGCKeQorA 2a3/LWVB6e5IWpDmNkOOzFyf/dVij10= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4V4mtt5lrjz4f3kkb for ; Thu, 28 Mar 2024 09:59:34 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id D879E1A016E for ; Thu, 28 Mar 2024 09:59:38 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP1 (Coremail) with SMTP id cCh0CgD3EQsIzwRmGgktIQ--.20517S2; Thu, 28 Mar 2024 09:59:37 +0800 (CST) Subject: Re: [PATCH v2 0/6] Improve visibility of writeback To: Andrew Morton Cc: willy@infradead.org, jack@suse.cz, bfoster@redhat.com, tj@kernel.org, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20240327155751.3536-1-shikemeng@huaweicloud.com> <20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org> From: Kemeng Shi Message-ID: <05bae65c-99fa-34f2-43e6-9a16f7d1ddc7@huaweicloud.com> Date: Thu, 28 Mar 2024 09:59:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:cCh0CgD3EQsIzwRmGgktIQ--.20517S2 X-Coremail-Antispam: 1UD129KBjvJXoWrur4rZrWUtF43Xr4kZw4kXrb_yoW8Jryfpa 95Ga1Ykr17AF4rJan7CF12kw15X3ZxKFy7X39rJw1fJFWY9a4Y9rs293yFg3WfZ397Kryj qan3WFyvv3WjkrDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvab4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q 6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyT uYvjxUOyCJDUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4E02418000C X-Stat-Signature: f5pgwyeddwm3c4gxsasojokjd9h1dfyw X-Rspam-User: X-HE-Tag: 1711591183-889741 X-HE-Meta: U2FsdGVkX18qMF0jX6Tf1FILQmrdxTuj+K7PAzTE3NKmzXuYalrkhlBnXtiEWEFzW9ND4kqCOFZuaORBxxXHXHEHPzzemHVtAFNvJRFMce9ZJEJVA4UqHpgM6/FzfiTDLYizBjEZXN2/U32u52wjFprAfHy3rihc6fXGdVftGvft6FR9pdfqxq2cFxUNbguxLvQAQ6cSTXgn2v7X/Had4E440IHGpK43h+YGx8vjGd5r8xQX0eYB2Qn4uRYEZoDpkTVJEpBd5RD8m6cBquJ1/tLKROLeCNpvdKlOUHoUb7NFLWa6mFmyXidiahvUiScIpxg+PbD8nxNOveCy6bkXLQEZO9ZsbxO0i59UXISqMex4Kc84BVsXdJ3BLk6+OpPp3/GwXWSngdEBoiOCNaVeDTwusNfIlB2ijT1oPq5lV98GltHQiIQavMhfZ1+uztEaDw5UkA6ESjj082nqAR9cf1jqxw/LP4StZ6wm1C7w3tEtblvE3dE7V+mpVroaWgf8JVSJUw60ysIoE5Qm7gNNIDrhWRhUAcro6beq4XuS0DG5WgQdc6FSnt3MRkr9aScltQ3rLYlHch8+QloGg4UwLmd/jDB3VQV4afJYQTcJvxmpvUr5uPumcnWXqg08ozj4hzKfLFrHoyf0AICjY1dWPLxmAlJ+ElLqM5PZfC4OYKJGsdsrqJqaDsZIcO3KOZlv7/lOT/aNQc19Hj1yaJYPl32ohVGfMYhxh2GGkPtdMaJ1S8/LewkJricgzoIUgsj4MIraOYPrav8lGN8qu/kcBiNUnLA2aMEfNPgejWOx3GF1JrNfig7+u7aeHHkmB5E6Ql216xRc2TmVu1/FuZb+YtllGqYFKEf49gmrH3teSOLruzqQecCTHtlqjb2JziQQIlBX5+wAGIzhTAc2q1gJVud2GcAdyDCm/Lwcwz3VmYFGOXNcXbhL6b2AePL6XlWlM+2Z6VgxUAsP5tLoz/P HzboIu/w sMvbaJrWy2yR8hO1OssmqIFLo2yxsiGNcsqI/TrZkd40elmKepGsXmJAyqdpcxCgg32K+SJb60YrmClicXD1++Zt6x1t96Ixlnk/cVdIGra8QSlo6lWHLz6NzrUJm7Lx3J0pgxg9RF2g/aJixSt7/GclWsowufm7GfGwI9REGt6WyCmlBANonAJP9WdVcV89qw/Ra46p0P8YtvveEc9grpsjPvK7iiUTjK7045UYa3zeWTXFZ7YZOoTERci/H7ZY6/9brZF/TJDxMhFezdAVMGxyC2/v1cUCvQ3eO78AGuVMi+SA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 3/28/2024 1:40 AM, Andrew Morton wrote: > On Wed, 27 Mar 2024 23:57:45 +0800 Kemeng Shi wrote: > >> This series tries to improve visilibity of writeback. > > Well... why? Is anyone usefully using the existing instrumentation? > What is to be gained by expanding it further? What is the case for > adding this code? > > I don't recall hearing of anyone using the existing debug > instrumentation so perhaps we should remove it! Hi Andrew, this was discussed in [1]. In short, I use the debug files to test change in submit patchset [1]. The wb_monitor.py is suggested by Tejun in [2] to improve visibility of writeback. I use the debug files to test change in [1]. The wb_monitor.py is suggested by Tejun in [2] to improve visibility of writeback. > > Also, I hit a build error and a pile of warnings with an arm > allnoconfig build. > Sorry for this, I only tested on x86. I will look into this and fix the build problem in next version. [1] https://lore.kernel.org/lkml/44e3b910-8b52-5583-f8a9-37105bf5e5b6@huaweicloud.com/ [2] https://lore.kernel.org/lkml/a747dc7d-f24a-08bd-d969-d3fb35e151b7@huaweicloud.com/ [3] https://lore.kernel.org/lkml/ZcUsOb_fyvYr-zZ-@slm.duckdns.org/