From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61753C433DB for ; Tue, 9 Feb 2021 14:26:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BF03564E4F for ; Tue, 9 Feb 2021 14:26:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF03564E4F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 33BB96B0005; Tue, 9 Feb 2021 09:26:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EDB26B006C; Tue, 9 Feb 2021 09:26:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DA986B006E; Tue, 9 Feb 2021 09:26:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 0749A6B0005 for ; Tue, 9 Feb 2021 09:26:48 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AF224988E for ; Tue, 9 Feb 2021 14:26:47 +0000 (UTC) X-FDA: 77798955654.02.egg52_230b78c27608 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 941F710097AA2 for ; Tue, 9 Feb 2021 14:26:47 +0000 (UTC) X-HE-Tag: egg52_230b78c27608 X-Filterd-Recvd-Size: 6335 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 14:26:47 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id j21so3671061wmj.0 for ; Tue, 09 Feb 2021 06:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:references:from:subject:message-id:date:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Uc4hLLfkzcuaU372Q8Ip+lqv8soO3u0k2b73t1eaFus=; b=n9UozebptPP2PPvDim1k4FxcVXje29hmjNsONdbZ5u7jjioGjQPGJV1oOajW7zw4zu JQw2WxxRulBdmUafraawGTZbzFndIYdPqdRgoe9g/1GhszCEeDOPFH5G2WcL/qQxIjI/ qoc2hW5vvxTdLPV3675zX6hefLyIBaqo6Qpjm08HVFK87v7qzED5z5LITq/EE1vIHCew dLdVEOOBvu5sDhhDehEGc5nhT7bWAK4kFeiJv4Q7DZJikN1rI+VAFhMZBOE1YjU+rgVV J5gayV8gIRvQupK3pXnaGPppGj+++5KZPjQGuYeV3VbPoI2ligcg/rwnvgAOCDmt2KC/ loeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:subject:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Uc4hLLfkzcuaU372Q8Ip+lqv8soO3u0k2b73t1eaFus=; b=Ujzlku/hmcjOFtQ9AR+G1tWpLJZCaMEUoFckQjMd63QZcodT7IEKMi2iTCS9AokxE1 eGECb7z47FN15v+47bQAJPd7YufIJDS5Zv1btDYxRx4pSKFNtqxMIuTJ2r7Wbb7H9I97 kOSA8PbqOzoimBf+jgb2MO8VCrVsmpnoE7Oak60ad/nUw2sL+DhtqmLc57+DX+i6ogH8 /J9dfKWOKpyDa83MzmWC28CFj+1JwAnNHZCgC1MmoES+mqoqg0R5u4xDdki0rx2A++SL yGuVwmsvUVVKzHKSN11Be7KqM8a/fz2t9Rz5fm/p+zPPlybAiTAE2+2Tpio/pyB1qhqP nNXw== X-Gm-Message-State: AOAM533raKsi6SQcd9+Fd41x8ocK1WLQ1rEiK8rdgg+eSaMkrUJ8gaPV 39SyxbexhlXi6U+zFW1NbR8RxA== X-Google-Smtp-Source: ABdhPJwv+DvJmRgxDf0fCMECeVERTy5UALceUi2tv/8UPY8cpppnpNJqhbI4CBtV4sA8TjumeiSkuQ== X-Received: by 2002:a7b:ca57:: with SMTP id m23mr3677321wml.75.1612880806014; Tue, 09 Feb 2021 06:26:46 -0800 (PST) Received: from [10.44.66.8] ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id t8sm4337913wmq.36.2021.02.09.06.26.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Feb 2021 06:26:45 -0800 (PST) To: Randy Dunlap , akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, Patrick Daly References: <20210208234508.iCc6kmL1z%akpm@linux-foundation.org> From: Georgi Djakov Subject: Re: mmotm 2021-02-08-15-44 uploaded (mm-cma-print-region-name-on-failure.patch) Message-ID: <05e2ea61-af8b-7a75-f458-f936dc8cf65a@linaro.org> Date: Tue, 9 Feb 2021 16:26:44 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/9/21 06:03, Randy Dunlap wrote: > On 2/8/21 3:45 PM, akpm@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2021-02-08-15-44 has been uploaded to >> >> https://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for mm-of-the-moment: >> >> https://www.ozlabs.org/~akpm/mmotm/ >> >> This is a snapshot of my -mm patch queue. Uploaded at random hopefull= y >> more than once a week. >> >> You will need quilt to apply these patches to the latest Linus release= (5.x >> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicate= d in >> https://ozlabs.org/~akpm/mmotm/series >> >> The file broken-out.tar.gz contains two datestamp files: .DATE and >> .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-s= s, >> followed by the base kernel version against which this patch series is= to >> be applied. >> >> This tree is partially included in linux-next. To see which patches a= re >> included in linux-next, consult the `series' file. Only the patches >> within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included = in >> linux-next. >=20 > mm-cma-print-region-name-on-failure.patch: >=20 > This causes a printk format warning on i386 (these used to be readable)= : >=20 > In file included from ../include/linux/printk.h:7:0, > from ../include/linux/kernel.h:16, > from ../include/asm-generic/bug.h:20, > from ../arch/x86/include/asm/bug.h:93, > from ../include/linux/bug.h:5, > from ../include/linux/mmdebug.h:5, > from ../include/linux/mm.h:9, > from ../include/linux/memblock.h:13, > from ../mm/cma.c:24: > ../mm/cma.c: In function =E2=80=98cma_alloc=E2=80=99: > ../include/linux/kern_levels.h:5:18: warning: format =E2=80=98%zu=E2=80= =99 expects argument of type =E2=80=98size_t=E2=80=99, but argument 4 has= type =E2=80=98long unsigned int=E2=80=99 [-Wformat=3D] > #define KERN_SOH "\001" /* ASCII Start Of Header */ > ^ > ../include/linux/kern_levels.h:11:18: note: in expansion of macro =E2=80= =98KERN_SOH=E2=80=99 > #define KERN_ERR KERN_SOH "3" /* error conditions */ > ^~~~~~~~ > ../include/linux/printk.h:343:9: note: in expansion of macro =E2=80=98K= ERN_ERR=E2=80=99 > printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) > ^~~~~~~~ > ../mm/cma.c:503:3: note: in expansion of macro =E2=80=98pr_err=E2=80=99 > pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n", > ^~~~~~ > ../mm/cma.c:503:45: note: format string is defined here > pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n", > ~~^ > %lu >=20 > because the type of count is not the same as the type of cma->count. >=20 > Furthermore, are you sure that cma->count is the same value as count? > I'm not. Good catch. Sorry, it was not intentional. >=20 > (also s/convienience/convenience/ in the patch description) Thanks! I have fixed these and sent v2. BR, Georgi