From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED1E1C7EE30 for ; Tue, 1 Jul 2025 16:17:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50CDB6B009D; Tue, 1 Jul 2025 12:17:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E4B96B009F; Tue, 1 Jul 2025 12:17:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D40B6B00A1; Tue, 1 Jul 2025 12:17:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2D7E66B009D for ; Tue, 1 Jul 2025 12:17:30 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B7529804DD for ; Tue, 1 Jul 2025 16:17:29 +0000 (UTC) X-FDA: 83616201018.23.493D98A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 50315C0016 for ; Tue, 1 Jul 2025 16:17:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=giIn2jrW; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751386647; a=rsa-sha256; cv=none; b=rWiFAy68VSJ1sHk3oU8hJ6CvbIgSXJmUBXKTvK3xtySxIQFgnLPVYKD5i74gyZVHRWr4xw 1DgYylF40I+hjeSKH8CGXGjCXsxiO0KbeXpiVuYH++Gbbelm7baDaTDVZ/QYoQxd4k8LXy et9Wt4ZVkEMs9TEpIutNHNPSWgejmLI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=giIn2jrW; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751386647; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lVB9kTjPjsCcDiQ3MDFZvRa2zhNJTySbnw345PI712g=; b=3Vv5Z4PuHc0AE5BBG4KZOXVzm3/76CTSzQhMlNearpSTzcsw7YsAQCWNoGt3TKvbE5I2Iu ijBOxIZ1NBd1k8WvhFlJUthM8pjTO108REON/xiz7Xz9raHWIfeFK2RYFv32fx3/UJ0HO9 SJF0iyvsl/jJ0w0XuOHSVBDBvVbqbdM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751386646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lVB9kTjPjsCcDiQ3MDFZvRa2zhNJTySbnw345PI712g=; b=giIn2jrWUJgZWy2P1HNTqozeUN1fpJv4iOn8u/WRaEx7r6p34I1JPQ76U1VLAfi1al+eJc 0sudPIGCwAuA0Pzon8sXq60TlVhXa6F5oXIZzrz8sg8UOlGLQgUOZ3tz4jw1Ta9gIzj6L1 mgkHP2ajdcXFi5zGooTLVhHzUNjCtI0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-PwOAr_HkMiG-Q8oLWqGtBA-1; Tue, 01 Jul 2025 12:17:25 -0400 X-MC-Unique: PwOAr_HkMiG-Q8oLWqGtBA-1 X-Mimecast-MFC-AGG-ID: PwOAr_HkMiG-Q8oLWqGtBA_1751386644 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4538f375e86so31703175e9.3 for ; Tue, 01 Jul 2025 09:17:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751386644; x=1751991444; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lVB9kTjPjsCcDiQ3MDFZvRa2zhNJTySbnw345PI712g=; b=Q0Oy5gQQEXrMW6QW1o+OZQCdVMYXnAUM0Q3ZYKw3wPLqcIkqsxdVeOSJykJZkRpixI 9lhL9HxgWKpjHgf5X13II/n/wvMceRVvcCoFv5qsDUzc2G7KOdvghjjA9GCQ+sVHdOix 2aor6J2qWiweIICySTZcc1ndk4gGf5q/WI7NT/JjIRqlRNto5PayfzJhnK+cjs1MMe7v NexZY/L36oN+5dXlV6OdC73hlPBo0CXypaLdc2a/J4VHGas9ckFqwDtFK0nCOOzDi0ow j1YCP1l8J9hKSD1iFpFPw6a2tYnyFDwMzZ0MtDuq5CK6o1ZNfqfFVcWABPbZo7Okxr7U YQOA== X-Forwarded-Encrypted: i=1; AJvYcCXU5Uukf67Io2NcpkKxTZWyjMB2+M1MDY+iGXVJclBgyKTPpItxifkK/cS3n5cpxvFGK3OhbJhr9w==@kvack.org X-Gm-Message-State: AOJu0YzxmUHAiugilc1aeaWnxlK7uPEe43nMqg7WKtyilVUCWng4GztI i3J1bk3H7YASVrSrWMrKThAaMoEdYMSYmwzlR1gOV+hR9pko9xfCB1O5Gpl7EiSlaYvhWHRLdbF HeDSNX0GY3h0SSCQaXihZzitoWUVRTuM7hfsJgWvhjx+ErF3qelNz X-Gm-Gg: ASbGncsm8nSXI/ST1i2yW4X6LuCiZgNKbChDDnSojg6epuwGJLtmBULuHsRTv3iBOv/ cNklMY4iovokP2qhgSWY1Oh+FFu4u6UjkVTInNkDz3a8xNFd2mq/UKIY1vAqbryNH4Ah3L1Plqt hVKY0pqP4Rm0iU8wxgvFpxlPABv+lvNAq/ItSmHPCW7G7b2TPfw/tidgaaEDlsFH9sTL3F/hGq4 A8I0ZKW6/TY9T2UEFdUpUVIg8BQv9qcif+vOHIyjooOQsYyuqWKGpa2XgL334Zj1LVy6b038XGj TGYAfFc7OObYU6ccXKMy2aOvil4oPmqupOWzDKO5/ZNeKNeG0hRJhwnz1urAfU2gaSQIQay1krs Y/nHuFKRU8aPsjTKFy39KuzzU3EO/AqcI7NxIEwMEyJSRnUcsKQ== X-Received: by 2002:a05:600c:a48:b0:453:58e8:a445 with SMTP id 5b1f17b1804b1-45396a94e32mr124259385e9.11.1751386643611; Tue, 01 Jul 2025 09:17:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvGN3FklTl4ux1tT9v67V+eF7W0w2RvDhr+maKyotoG8OCwBMycQHzwIksow9IVBXZa7R8rg== X-Received: by 2002:a05:600c:a48:b0:453:58e8:a445 with SMTP id 5b1f17b1804b1-45396a94e32mr124259065e9.11.1751386643178; Tue, 01 Jul 2025 09:17:23 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e598d2sm13581910f8f.76.2025.07.01.09.17.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 09:17:22 -0700 (PDT) Message-ID: <05f3517a-754e-40e3-a0e1-bc654f6ed3c9@redhat.com> Date: Tue, 1 Jul 2025 18:17:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] mm: Support batched unmap for lazyfree large folios during reclamation To: Harry Yoo , Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, ioworker0@gmail.com, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com References: <20250214093015.51024-1-21cnbao@gmail.com> <20250214093015.51024-4-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 30HerhUIAXAeREGWvzn3wZ9ksiVkrUA7se63RsDbSXs_1751386644 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 50315C0016 X-Stat-Signature: a1gheda1eyxohot1f1pmh5uwiro7abzo X-Rspam-User: X-HE-Tag: 1751386647-279778 X-HE-Meta: U2FsdGVkX1/HsfnMpy0tFvkD7ThnqLBd+w3z7jLW+CfBuBjINCkvd24FyMGCF3JI2+IcInha0tVo7We9KY2YCcGPTQDe/0/U8MLXvCiSNQltz9bolEXOd4OWXjbTdeF+GGP/KXC4DtpMZsS4Y8clRst9X1rbH3h1XFqcl+2qBMR/bP2Ve/QHDwbE7tRYpnqLsmzXK5sI7TjMrTa87WJKBk44jMOlP3knFexuj0EukOqXjj8dNnhLA2/VHgXIFNNmU8nNHV+Nh3/ppVyAJ3JpSIkyjgtxkJSNzr2Izbx8NIPH1xmsc2hz3vsJSahX8Vj8dLzuFvbIk/1rV2IlzQJPkKXjsEGRwegLKoT9WRG1VP74nDD6VQtxqHi8iPhUzBs2ZgpA57n1tg3RI+g1Pd/ZUAU8UutG5ASMS0AWTkRj5zstvK+A8NAfRA7OyOvUQT+ID1Is0/AhFfIUPXa7l0V6IEFiQjUUEjPHuK8oyB7df2ijrJJGkOVpwUOMcp6T8mGsLJHxDb8O26Kh9XDm/jlqbKnFrR7TWiywx+FzRyruahvuKBvZ0BE61OOdBwJHtPU/QDUaJavRK2AXpt7gYPHlTIJ9mr34/azrmYpYBv8giFQuRfBDgAVxHZLeJlaMiU6v5uJxQ+uC0f3Mg84F/OBLwUx4+qOftSBlwgAUzV8dXYy8Nr6+2xtHRaWGD9uIC8mahej7TMIvM+BOwNZRJg4njdEm1lEGw4VRfJztpTI+jXikviwjeS8Fl3Eh4YLqEkoxfQd/SCdNQSo8r32faN8TShbRwHEV0ZcJCuzOcv/6Y0Nq6g44R2NfzIFCNT1SCcIhvUPQThQNKkcjqqRpiT1BlMssQoM5OcbpB8x7597KRusLgHcaKLp+IYEpmAdwCweXrBh41oLmunoJfxnADat9jVtqlCzvdSSp1IAZ1+AVv3AnjpRNvQQgUZewbtxQw2xP0pSw3NFVY75TI9sH/Px epgHiwNr fhTy03d/UC+j2Iq2FG70EF5pgdyXu1ISk3lN/T8lOXiMbNtfY7nAZUKR4nYEs/hDCNJhI8lAnfXvRbnfZlA8WcyFMxe132qpHcnte3tsMqwaS3trzg4wN9CcDZMDB5USiCH9/9fc7tO28OIcCIXhIDK9QtrZKSDqex7H6hZFtlHGgFwUid8uT5ouLdyPoGAVsm8OeKX674Xr2eSRG43ow5n+V9momBm42IsWdM2jX11DdlHMQraCkg/AAq3eBCbC5hi/LRr5GBlTrzj36+mzrSAx74XC/9XRpehbpbKDqqBEFzSiMiZBJcVtWEhJgN/RSJy0IPvh8J/yixJGTjoWygfRzpoPbwVCi//GeWVb8F+WDwz0bhbhs3Y52N4H66xytY0wcHp9f1LOMW8LO6Ym4+kqYVqpJN0jl6ThbwiJ6xunBKU4JgWwyzQoRKYukkVz8Xxp9uqpwZgDYewSMQfauXIlqRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> + /* Nuke the page table entry. */ >>> + pteval = get_and_clear_full_ptes(mm, address, pvmw.pte, nr_pages, 0); >>> + /* >>> + * We clear the PTE but do not flush so potentially >>> + * a remote CPU could still be writing to the folio. >>> + * If the entry was previously clean then the >>> + * architecture must guarantee that a clear->dirty >>> + * transition on a cached TLB entry is written through >>> + * and traps if the PTE is unmapped. >>> + */ >>> + if (should_defer_flush(mm, flags)) >>> + set_tlb_ubc_flush_pending(mm, pteval, address, end_addr); >> >> When the first pte of a PTE-mapped THP has _PAGE_PROTNONE bit set >> (by NUMA balancing), can set_tlb_ubc_flush_pending() mistakenly think that >> it doesn't need to flush the whole range, although some ptes in the range >> doesn't have _PAGE_PROTNONE bit set? > > No, then folio_pte_batch() should have returned nr < folio_nr_pages(folio). Right, folio_pte_batch() does currently not batch across PTEs that differ in pte_protnone(). -- Cheers, David / dhildenb