From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840BFC83F1A for ; Fri, 18 Jul 2025 03:09:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00E7D8D0002; Thu, 17 Jul 2025 23:09:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F28E28D0001; Thu, 17 Jul 2025 23:09:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3E768D0002; Thu, 17 Jul 2025 23:09:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D40318D0001 for ; Thu, 17 Jul 2025 23:09:38 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8F610C029C for ; Fri, 18 Jul 2025 03:09:38 +0000 (UTC) X-FDA: 83675905236.07.C9C2836 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf05.hostedemail.com (Postfix) with ESMTP id A1E0D100005 for ; Fri, 18 Jul 2025 03:09:36 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y0fMONhq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of jiahao.kernel@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=jiahao.kernel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752808176; a=rsa-sha256; cv=none; b=hXc2mgn/xIDCWrfiogMXnyIr+Hgy/uXtS3NbDca+L5KwT45mlEbuJTEqBC74shopdaIYxG M+9TICN9R9FmW+FaKtXOh2tFjYMJ8/jKKeSuonwB5tW1C9bBGUwC+pwkgQ16MHU3HskfGF pxVYQBuRqyLmbVV7WjJSEVTDVFLJgcg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y0fMONhq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of jiahao.kernel@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=jiahao.kernel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752808176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FvDciYpX6cDw67gVhydVWFNn+mPhlWsC+2w9TSXDjyM=; b=8Ggri/9gLjFHonqazGaWH1c3+G63ZM1nZgYy8jQ3ujhG/Gt6I6oidbPAVatsAcv2vIx7gp /q4gvYxYkVNaxfaBli9IiU5q6JSRCvMZa9zzLiD8h08QvZY90R92PRn3ispgBKYoSyPM9g fEbm2I1c2PQFAI6mUpo9YzkXxaDNB3Y= Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-311e46d38ddso1545813a91.0 for ; Thu, 17 Jul 2025 20:09:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752808175; x=1753412975; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=FvDciYpX6cDw67gVhydVWFNn+mPhlWsC+2w9TSXDjyM=; b=Y0fMONhq0SE30Gth3H5RllUCGavoJ4FJSo6fnQMhBYWuVp39weU0FFkrMk5JyNLaw/ odyEjS7Ya2V2aaZ5oiduiws078kM3uwYp4DNalGfz4g1Exf0zLTFZE8BMvJoacA0DnvJ Cg4lnDMA1HygSFcOu8n1lzcT8C8drmwOXzqYWltfkeWOJXXCHUi5hM4qloooLuUAdqAO BqYd5Knrks8H6HxRf3vc7CZWbivFGoX2Du2QKY+Pkm0T5qYfnwp+xdNEMVK/fX6tcwI0 WK7SOd3jUDNiCViR7TNAXtEM233h6LTWUDPn3JMG+C07XA7KQHMzCdJEDD38F7VNt+rE N4jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752808175; x=1753412975; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FvDciYpX6cDw67gVhydVWFNn+mPhlWsC+2w9TSXDjyM=; b=kNd5o2e2GnfcW3kmUUtKOeyjpxiTIZFl9P5MfSikhFKNzYl2D3Z1Yy2a6OnbFCsUJc cEIvqTEjnCorZMeJ/SYL/T5FIrDUbCucXreoeIqPnsCKuHheM4WSc4f6/+dmTVwM+8KK iOTZ2EMbwYqAnybXJPycQTcxs4y4agFIaHul+FaYPpPQrGtTzlW+67nKY1nPHLfO6yY1 KX7qNQt5e2oV9kVDiWbJaCoTI+s4vvMJ1KEZISl1Pj4+gTtWxLs3Rr+i0lS1Wm8VRT4w OfarJpccqHr+qLLoHR5y052KCO2YNLjotfAX/hdtuJ0CrADq+UlK0R1/Ac1c9zkNKWmA 6UaA== X-Forwarded-Encrypted: i=1; AJvYcCUdX+BWZ/ADUh/pR0KCz9jZlsGUFaeKDm+/AewHXvjHvQgpt+qRhNkV4JTb8nNAeGP1BA8/XtbZMQ==@kvack.org X-Gm-Message-State: AOJu0YyWOo4ClyTI3IbI8ND1HpWyHEjU/mGAgMhhZNTZ7/tzAXNivLC2 ykzdynmLDB9o8Dq6jBRqkmujVXBj1jwzmzrfslYh+1LbcBxnCoINlPq+ X-Gm-Gg: ASbGncvnxgr2Zcx3FaBtwXj/FJ9zGatArmsgcx700X6iXEBoMbAEpE7g/0PEh1oZnbU lDKefoPBKfyGuulkTm/79jqGsVv9uK3BLNXiAB3J49g25B43fUr3Z5RHAMoy8KIfNYw8268mpfK 5g/FZWaImRydfagJGXZ3iNZQ5Z1rAA8GhKFhuquy7apbXpqjyKbCY/gRynDpH3XVHMcYbaTsi9f M23VoilW+qJl7Vp11xnbp3qOj429xPjJXksjpXyjsFIvw8Cutmv8E0iYbVUaL7a/j3o4s2MJHwT lymlnMksJSKYI+0OgRNBHMP5PR0zm9ZHzH5CtERARqFX73ZL0twOfZ0TKiRSEyWpc1obKbbG4N2 nN9owaWWUs7Z1ECP9F2K4XK+Wqjv4veq+rKXrs2e2p1EHjEo+g+NzLA== X-Google-Smtp-Source: AGHT+IHhbuJienL7Fkwh/SX482W4DVo1oRYNgwQdvKeQQeliqD7sCv9BZrpPxsp7U76XyH3tl/NZXg== X-Received: by 2002:a17:90b:5610:b0:313:bdbf:36c0 with SMTP id 98e67ed59e1d1-31c9e605f80mr16126118a91.0.1752808175268; Thu, 17 Jul 2025 20:09:35 -0700 (PDT) Received: from [10.125.192.82] ([210.184.73.204]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23e3b5e2d20sm3753465ad.32.2025.07.17.20.09.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 20:09:34 -0700 (PDT) Message-ID: <062c9e67-b0e2-0528-399c-e11428485008@gmail.com> Date: Fri, 18 Jul 2025 11:09:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH] mm/mglru: Update MG-LRU proactive reclaim statistics only to memcg To: Shakeel Butt Cc: akpm@linux-foundation.org, yuzhao@google.com, yuanchu@google.com, mhocko@kernel.org, lorenzo.stoakes@oracle.com, kinseyho@google.com, hannes@cmpxchg.org, gthelen@google.com, david@redhat.com, axelrasmussen@google.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hao Jia References: <20250717082845.34673-1-jiahao.kernel@gmail.com> From: Hao Jia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A1E0D100005 X-Stat-Signature: cgyhxwkfy1tniaqf9az83rftcqjr5ctm X-HE-Tag: 1752808176-861879 X-HE-Meta: U2FsdGVkX1+8G8zpMhSswIL14wH4f6VMzbieAB6NK63/nxGMGaXDqZS7ISpKML4N2jXB94TIhR+hvOBqwk5nYcm7MdV64dvE2nlj4AQqEIKrQ3aEdrO3C6x70hkmwpk1W+iiuduuTEYGN8iMJD1V5sw811A7+OAHyKDOgn64ywqWSkJLJQ128dhTgSyIh1U4mE+c1XxVxRtHujJV4c2rygqiJ2YQGH3kj1GEktfGy6O2X9VKAORMOUvB02B5VfHYU/miyA1/DgdodHBkLEkd8Xa6g1rrd4WWZDnBrcpsIt2jjXbJ4wlFRnsrseWG6AWxxu75i3ly8x9LNlhkuo+U+1OchsRf+GO7yottyfpoLTBNFIHJk3TNAaj9pXDMEqzEPkQefDtTBOwhlqiQLsQ1Zj8klyiqqTBMhP0Tk7rn4NgtNe81g3eksC4uGZNNY1Hh1Uv8jSLu3yTYaz2WvszFIxxWQps85ICglxbvrmK4pp5ScWuJzEcbtHjPFP0H1uJOK9feM0C7GUtUEkJr5C6mzHFlrnPg8xIgntpmvNlMyxC5Q+vxP4oy7cHwu3gRCP/lprVjsxzhChjdZhjB5xbufgJ5x1hzxwoTOoC+Kjw7yjmYeq4v+hbaUm1XOLZRsfdVjjeHpFoz2kERME1LoaOLUPK1/woq2Y4W39/fsYPd9Ep8EVrV+ZTnbbdDc+DW19/AskdRkbkUf4NJvJkUqhFJS3nrxnyDJUm+ufuTBdeuEcTA8W0X/J8nywNdOvsPqji+gGP1ioVSEMCslR5/TZZi1xYt0J0xZhXftjldatc3PMkNyS9mhfYYhMS/CF+cpSWYSNEpIvNpBWW1TMKkw3jVKzzthey4ouASPNyPkIPkrSrqY7+BZTxGT0VU6WXB/bRpxu2DB3yfX0x4uqexP0uu74BQFIyAurGYHb7ynOs3aXSYCovggKFziw1xFQv9xk6vq1Y6q9EyuDBxsUH/hy/ IUgREXw1 zU19IA3918Tgc33FYmA9VPqfNQBrKzSmencoMUBQnFG5ICn/lH3fbYykAyBSE6w4DL8ah7PAjMwfTSx23kXTnN/Rpd+zjDw7X2Q4D1UnOMgZlE8GGwXqOJ3nDKus/HHR6p3H0UaneVXB0RACN1S25Lv6nrRUzq+A95uRszNRdFopEDsgd49dkM33SFLFBf6a19in6UYpkFqsk2POk58GB9+Y2SWicUxAB8s+jd2Q9ccQ+V+tMxI3A2Ve5l8gYNf+bsCjyuTVJ5WbAjNQiG+x1nSx7vJV5YOEIuJ1kHjGOSSV/mQwvxCp3UZo1vokUsmq7inPr5vcRcRMjLKYWZdPDZBpxNf+Ouhulv8RwkbP8MPtJWjeDW7DVoz7tgEN6NcCw19Qv/+SWL7RJafx7ywTQ5wAW5tvd5AyBavD622N8uQXHU/zVn3o0rDIaA/DQ31u29cA/iJfBOM9J4fnrWxgwkntF2emUVHcvW6UxrEiGWAQq2+w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/7/18 03:47, Shakeel Butt wrote: > Hi Hao, > > On Thu, Jul 17, 2025 at 04:28:45PM +0800, Hao Jia wrote: >> From: Hao Jia >> >> Users can use /sys/kernel/debug/lru_gen to trigger proactive memory reclaim >> of a specified memcg. > Hi Shakeel, > Are you using this interface for proactively reclaiming a specific > memcg? I am comparing using /sys/kernel/debug/lru_gen or cgroup.reclaim to trigger memory reclaim when MG-LRU is enabled. For user-mode agents, the two interfaces can achieve the same function. I see run_cmd() using mem_cgroup_from_id() to get memcg from a > given id but I don't think we expose ids from mem_cgroup_ids to the > userspace. Usually we use cgroup_id which is just an inode number for > the cgroup folder. I wonder if the current users of this interface are > providing memcg id. We can get memcg id through ` cat /sys/kernel/debug/lru_gen `. Thanks, Hao > >> Currently, statistics such as pgrefill, pgscan and >> pgsteal will be updated to the /proc/vmstat system memory statistics. >> >> This will confuse some system memory pressure monitoring tools, making >> it difficult to determine whether pgscan and pgsteal are caused by >> system-level pressure or by proactive memory reclaim of some specific >> memory cgroup. >> >> Therefore, make this interface behave similarly to memory.reclaim. >> Update proactive memory reclaim statistics only to its memory cgroup. >>