From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F3CC83038 for ; Tue, 1 Jul 2025 18:17:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26B616B009C; Tue, 1 Jul 2025 14:17:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21BEB6B009D; Tue, 1 Jul 2025 14:17:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BCC26B00A7; Tue, 1 Jul 2025 14:17:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E6F2D6B009C for ; Tue, 1 Jul 2025 14:17:20 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7FAF959CF3 for ; Tue, 1 Jul 2025 18:17:20 +0000 (UTC) X-FDA: 83616503040.26.2BD62AA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id F236640008 for ; Tue, 1 Jul 2025 18:17:17 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=INPY3h+Q; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751393838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VGEs+zZbCJDxVs2cLi57c4jWLWtlXM7XcJOrJnn4lN0=; b=Hbzg4U77vsmkooCgCNHHviIczJIhDSs81rN3bQqBD15wM+y7Nch+CQeOpbcB77wn0chx7Q BUZrMULC3KEtg/tUl+6afGj2lFQv8TuhpJe3sJLDbnXAhx7+S4JGihhSs/micxT/nLw/Gj 5qvgbyP2dGSRsPB5Jx+KkzeqsBeeQEY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751393838; a=rsa-sha256; cv=none; b=xnPorQ29TFakEjNWGFeBF9zcCy0DxvEtGryPhW6wK3CGZgogBrPPzTjZgAwRqhU0h4fRnX RShFhHmUyfpvPzUWQnq7kuGThwMpO4iDvrWAocUfe3f+wKzdef5gq1ESKSXBQNZ1xImMb+ BR7Xb88yqPQUMUB9kc0fxBIjEjfMhU8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=INPY3h+Q; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751393837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VGEs+zZbCJDxVs2cLi57c4jWLWtlXM7XcJOrJnn4lN0=; b=INPY3h+QMTNDaAdtwm2NizZeZVXSNT/qwmDorCIOw0YtPBX0VDWAvHEMpdaQBo4z2lQoJP L0iHKle5QayLPInHST4XOaSrtVL+a4ii/Jf0eQGXOKkoSWemAJZLvWb94LUQXBSpQOGBaF AGtaWQ+YicZokw3s6QJN6vNwYfqPvAI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-qZi0qkFaPJy7MeHdUUBW7Q-1; Tue, 01 Jul 2025 14:17:16 -0400 X-MC-Unique: qZi0qkFaPJy7MeHdUUBW7Q-1 X-Mimecast-MFC-AGG-ID: qZi0qkFaPJy7MeHdUUBW7Q_1751393835 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4538a2f4212so27748375e9.2 for ; Tue, 01 Jul 2025 11:17:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751393835; x=1751998635; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VGEs+zZbCJDxVs2cLi57c4jWLWtlXM7XcJOrJnn4lN0=; b=Y0YnQAy3Go9AGVTCHc2LRyOmV3akZn5/c8KTLgZme6INDrrY73778HNCbYoXMeeec8 FYOOyrGp2esDOyfs6iyQQxZ0xBYXiV7KfFKpz9lIHe3I0gUvwM4HNV1iSXP0+bAof/g2 Idu/HQgcoYPcEQcHfyRPevWDPp8T3HrOPsjZ1o2to9yutIgyXaAvd3WhukimQgP/Feqf CQQDSvqdaZazDiBHF97RDYUzjOi56kMVZNDcZyPkCs7refJV502VbK5yu6WRq6JLuQ9R Wjc46gTYrvHIZeIGuUmOXYfYxZoz3dnNv4xZTEy0AwmCXV6boJlE8dbjWtbTLX1Hmt01 TZjQ== X-Forwarded-Encrypted: i=1; AJvYcCXZf/EuYvATcUpdckCt8BvcYdmldVMS6az2B8bNGwIJdWXEOsO5Lz0rSuQGJLSuxSlnANwXSVU6PQ==@kvack.org X-Gm-Message-State: AOJu0YzG/EwQzS/OyHC+QSNGWMZqziEs74RcYYbWWppXoBZcplXE7+r9 SE7VmC+LEt4ZTzG75FPtugV6ULeg9h0AUhzAzPEAkzkb0a6vd9dbYc95iEkob0UPMsTcCSj+FCG 5k5lV59K1mFQABQxnVpl0w9Llu46u55l+bTrjQA+ZoTV4pGnmol9I X-Gm-Gg: ASbGncsZ7XEW/SZ7VQbbChQ6p2LRvCyakyqn+moWn9OtuSXjuF3p3sXKshmPGHpHP3h YMkZsWEE33ycKNuakWI6jCyNRmIs6zfD+gTOJ66H/PyHXJIVsXRgkJ3uiBsFrvP+/YBXUvE2LYe Bzlb8v7p1JgIIgr52yXS4UMmnfL6owpssqE29f07tEfLFTO1h7AidzdTsI3BwraaKCo06Ygk//H 6DyQP6iCihMV3QGV/nCObcWI67lNFRy9rZVZV/ZpClNRqGrQh8WWxdBJ3B/MTih27sDEGvpvfAd EmvxAHpkdMCYm6J+4l4fPaMvqnZfjVu4S87WLv6RFxQ5H9/XdPlNFBvy3C3BCbxTsaiDo1YA48B UWRxPTkNZOUY0AgYETOG3RFlfbw8F7k1wsUbNj6cZlDGwKWjPeA== X-Received: by 2002:a05:600c:638e:b0:442:dc75:5625 with SMTP id 5b1f17b1804b1-454a36db257mr1826395e9.5.1751393834840; Tue, 01 Jul 2025 11:17:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFOjijwKPczqWMfdeVKPSvKVFWEPvZAE35lAAMnXLl8MyrFYUOMUzxtudMr6z6AJZXhbp6xg== X-Received: by 2002:a05:600c:638e:b0:442:dc75:5625 with SMTP id 5b1f17b1804b1-454a36db257mr1826105e9.5.1751393834381; Tue, 01 Jul 2025 11:17:14 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823c463asm202736225e9.39.2025.07.01.11.17.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 11:17:13 -0700 (PDT) Message-ID: <069a44c4-754e-41b7-9a42-7c2b77afdd37@redhat.com> Date: Tue, 1 Jul 2025 20:17:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm/migrate: Fix do_pages_stat in 32-bit mode To: Christoph Berg , Zi Yan Cc: Andrew Morton , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "open list:MEMORY MANAGEMENT - MEMORY POLICY AND MIGRATION" , open list References: <25EB3C6C-4D6D-4946-BF0B-9B322E7DC16D@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0CmqVRKkxmvYwdq3IICuufoqoAqhjE61X288rYutB5k_1751393835 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F236640008 X-Stat-Signature: np88xcnm1jiez9fcqfki536prxm6bsau X-HE-Tag: 1751393837-422776 X-HE-Meta: U2FsdGVkX18vxcHNSDl/YO+42eLOB91w876yv3ql8dv8dh84LG4MggKYQwtdzfFlzm7METtj2NiitytZzwlWJgn45wWv90O/y+Rviyym3I9Oz5QKN1UVyHUsf74lyikOK8GUdEoYmic9qRW+tkJVbi8pETCtyVKygD3L8dUFzFmrb+wG+qTt1CDV7OXJcgWnrlTNoKy9f7TbAj6SVRiK7pn6EUUGhLGY6t35e7odeWj0GPO5wNlgiktCswmRTuJen7vOV/2u7KM3VAAmCJGx6jg53ZN/BNA6j+rZBp0lSjKfgBlWe6VWJvrPvoGTAuvWZ2iYsthKffwuilp1eYF3k9Cgu5O6diGs3jwjpVtOrAPXu2hMrfxs94wszd0Gmr/jqNkWmtg17HPqzjr5sIyrCqbxAsaQZdLW1/9vFCLPzO5Mq0351VvzZS3yVh49yUBMwaLYkzEDeDQcrCltKk/TdnZ9VtG0b45cSYfysQsjpZHfNB46QL7sfZCSI9WDyqW9caKHSOg2N8Ddjl2vn7kYko403z9B/9ugaFbGjD4Q2hSuRCrWuGf3RTAQjnGPD/ShzRsRWJHLjulh9YH/VGdjHsfPi4KTA2NSEOj/oZQIRX2/A4wZj6aX3a+lVaED9kmTWacj69xXV/Mxs9/XigBX2Uah2cfDH8aDdRWdUG3xhCWwtCMaBZXRR5iK3e4WYgZ9KG4pH/2TGJPsFpmQxEdbowqvxsH3G9qA2hUyTIbcK0TmYMTARHaN/VK/AdFNZk5yTAoR2rveOkIoBNRiB86etV5S5xBuU0OxcFSruCP7Ls5vyObT6U/d8aMf/3IaQNMzva5FW/jouTU9xj5VT1502Dq0Cj20LQeHw9gsdM4U8lX6+lCfeekusDIZCzhB+QV0GoL+GLL6zNKCkpPrm+gFucluw3jUJPIyjkcrxmrqTNsc5B+KPJm2y4ureIGj3H8sH5sIj5gv5y1pEDZfpgg IYDwZq66 I+Fda6Z42eGyL0eZ8KGg8Oi3EW5GONWpVb3PmJwIUfVqUl6inVyOK3hRaAOdd7uRfXScdRVBsH4l83AMSzxton77PWR6N97r39ziKK3GIQLJTWvjfMbv9yxXdP0PXf9Vkp0tA+MuLpWNyrwPvMKg7iP4ZRe16sOQv4btY2lncmfaHelTvHo+mMTEhSJzLhboBWP1HztkSfxFiykVxo/Bz0QV16iw1e0iH4VLjiNv2iWosK2XXUGxjw0IwBsEgAmPFJFP1RRyUfghVzjOWwwBvgffhVaUhyCAZkoHtr77A282xZDCkanaPjcIVyUQ5RX+yUxG9gvqNpm+znSy5cyIvXJENuRSTq8rMYVuJTT2E1nZEu1b1DvDXN9WPejcggQ2EHloVd5+4a73xWqiFE0939zaBtWxD+uCwEGS3/SI/NvtFiYSLCPW/8WMxYZywId8CxQDdO6RfVa+jqxnilUuwUP37sA4jqcjtEBivJ4gAWVTiuhgWMU+rCtAabmDTe64iAB6WoswSjzBGMAQLnyAEkusfcRGZvrjttdKKhWY/j2KKBeF9paiJVfbSqGRgDX/X8QjMXANhpsz8dXhMc8yTDJkUVuzcV9OUWZOwYLYwfEh8RBiEGU1yJh4l4I5ioF+TWHdy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.07.25 19:55, Christoph Berg wrote: > Re: Zi Yan >> Fixes should be: >> >> Fixes: 5b1b561ba73c ("mm: simplify compat_sys_move_pages") >> >> Closes could be a link to the bug report. > > Updated, thanks. > >>> This seems to work, but honestly I am wondering, if copy_from_user >>> needs a special 32-bit case, doesn't copy_to_user need special casing >>> as well? > > Scratch that, it works because an int[] is copied back, and that's > always the same size. > > So I think the patch is good to go. > > Christoph > > If you have to resend, next time resend the full patch separately, not as reply to the previous version. > From 426c93d558572248273cf386ca784626ae431413 Mon Sep 17 00:00:00 2001 > From: Christoph Berg > Date: Tue, 24 Jun 2025 16:44:27 +0200 > Subject: [PATCH v3] mm/migrate: Fix do_pages_stat in 32-bit mode s/32-bit mode/compat mode/ ? Because on native 32bit it should be working fine. > > For arrays with more than 16 entries, the old code would incorrectly > advance the pages pointer by 16 words instead of 16 compat_uptr_t. > Fix by doing the pointer arithmetic inside get_compat_pages_array where > pages32 is already a correctly-typed pointer. > > Discovered while working on PostgreSQL 18's new NUMA introspection code. > > Signed-off-by: Christoph Berg > Suggested-by: David Hildenbrand > Fixes: 5b1b561ba73c ("mm: simplify compat_sys_move_pages") Hmm, still not sure if 5b1b561ba73c really introduced the issue. I think it only messed with the "pages" pointer, not with the "status" pointer? Hmmmm I assume we want to Cc stable. @Andrew can do that. > Reported-by: Bertrand Drouvot > Reported-by: Tomas Vondra > Closes: https://www.postgresql.org/message-id/flat/6342f601-77de-4ee0-8c2a-3deb50ceac5b%40vondra.me#86402e3d80c031788f5f55b42c459471 > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb