From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F198BC5B543 for ; Thu, 5 Jun 2025 07:40:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CEC56B0179; Thu, 5 Jun 2025 03:40:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A5D96B017A; Thu, 5 Jun 2025 03:40:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76F446B017B; Thu, 5 Jun 2025 03:40:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 59B636B0179 for ; Thu, 5 Jun 2025 03:40:04 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E964E81C58 for ; Thu, 5 Jun 2025 07:40:03 +0000 (UTC) X-FDA: 83520548286.14.68DA99C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 745971C0006 for ; Thu, 5 Jun 2025 07:40:01 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SowGSUWw; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749109201; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BobdB6YRhYGiH5Wx1OVJ5tEllBMnM/ff9jWE8OFYOLA=; b=Kvt/O3WDoG6usxHC2WVGV5U+cRFhcnwfwuKSXA3c0xpBAio2mvVnNufWT3OxPYByPDm5lz Rs1JMsw0CDqL8n+VsqEzgl5p5dB+VAoed60ys8hjGMt1fY4oQ87OOZVoi+t5I/B8mVA0Kf UDAGpZG+XSxOg5J2py7A6EQD2Xw+jMo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749109201; a=rsa-sha256; cv=none; b=AnSHMd8MEIru0Mf41Xu+yTZBQ+GO8tAr+m4HHWTXpXfaB3MENmbrC9MVMFp9XUA2svUDds oI7a1lewTKEoeA0lYoxGMwqOimmcbOCkzlNloTACp2H4pdh6qqqiITUUis8FcO8Mu8UGPI wsBSPdwkpqe96ReYoM+6LQtYvu3DhWU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SowGSUWw; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749109200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BobdB6YRhYGiH5Wx1OVJ5tEllBMnM/ff9jWE8OFYOLA=; b=SowGSUWw0k/vPHemPsNpQfofXN9FIaXGSuvNmqSkd24AZ8syhPmcvrOoFxnXwAKw/i53Ue /gxWmm+ga5ilKqsUNyIVSJMXaOSHCdDCldmdTR0v8kJFiyquGnnfp7dJQ7zH2MYGOAvyfd 2ir2erH30Fo0EfD73U8wqOHEPwCOzN4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-442-DAq7SHIgMwaMNnF6yyng_Q-1; Thu, 05 Jun 2025 03:39:59 -0400 X-MC-Unique: DAq7SHIgMwaMNnF6yyng_Q-1 X-Mimecast-MFC-AGG-ID: DAq7SHIgMwaMNnF6yyng_Q_1749109198 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-442fda1cba7so2966255e9.1 for ; Thu, 05 Jun 2025 00:39:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749109198; x=1749713998; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BobdB6YRhYGiH5Wx1OVJ5tEllBMnM/ff9jWE8OFYOLA=; b=nVVlCNENknaXJipg9zAmZt1HgrXG23cBfoFud/a8xkrFzW8vo2gBhky0AlFFaPs7C3 i4y6ShHNScsYlk6pXUkka8SlxFWJgWHros4arVExFUl6D4ZsH7ki1RWW1I31ErtG6atj hNmQbazLXh/c/KgIBpUsE85RWAGy9FbtKjOmyPiWQuyExh3IATx/BoiFlwIL4ObwKvt3 Aki7jXo6FxJkb+B4bvx4ytUEtDYEUgf045sfodl5jtdtfIkqlODweOf3sVNAomCydW6E 9ZnpAVTEQdxZTtGgEICPk0XB8s+l4YjdiPR4q8ZljGj3BB1guzuzKXzY1msiL/aFxFmK OytQ== X-Forwarded-Encrypted: i=1; AJvYcCWlYQ5S+bXRd/GVBNrLZro8xmO6Z6iocnnVq/Gqakjr+t6SGoCRH906LwiwQuoIg17asb/kN6ERaQ==@kvack.org X-Gm-Message-State: AOJu0Yy9IIQMclh6aOx7Woh/SZAw+32007ZTUeIE9AeI4m0PHTVU6n5m flrX/cKuR7Qqj3djZgLC/UQpimX98ZzC+XL0iGyaHTrJ9i+PScJNhA2P7tJdih6YyHkJR4pE3Bq BShjc9Z3JAgyRnI46ikUnF2jNuV+dxhAzo6KQgxZzj/oVAqaWrf9J X-Gm-Gg: ASbGncuXqOWh5y71k44YY2hBqBZ9weoDn/P0F1cjPTK5cnBlykDmapy0hdij9IU7ENL JnE+ow+wJo30wOWKfXqVNZVcn8zAtvWnnP4COr0c43prLOQ/lyP3AY/5bA6xoG4WiZmvx7CfYob UPkhPYxBHGO9g9v+d/CKXIFm4skYBmEz9V7uO1IB7lbWb+P2LiaKA/UPV10aY/SPGbPY094077c 7m5I/opwgfHV5ZwRdaCwy26KynH8QvJ15pXJpHw6qhFUr+aP1fjvmic+8HBC1swgDBhikVJbJug YqoyN0ITIX0EaRDtF64/Lq+8V7R4RVCRQxEG3VSeJX1I5krybsYvMihEYgV1QRp5LBzvOMwha8M qfKitEkjyX+EkU3vmQarOCR3O3+gxbuSd6xuU X-Received: by 2002:a05:600c:4ed0:b0:43c:f629:66f4 with SMTP id 5b1f17b1804b1-451f09be35emr58479655e9.0.1749109197905; Thu, 05 Jun 2025 00:39:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMcv+qQYueRrHBBgigbdlnqX3kWAp3xUx/rcy+UcGiHeVGTYUfQFomNvqgzjttLYWhhLoaNA== X-Received: by 2002:a05:600c:4ed0:b0:43c:f629:66f4 with SMTP id 5b1f17b1804b1-451f09be35emr58479325e9.0.1749109197540; Thu, 05 Jun 2025 00:39:57 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2? (p200300d82f27ec004f4d0d38ba979aa2.dip0.t-ipconnect.de. [2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451fb2213e6sm8961515e9.33.2025.06.05.00.39.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 00:39:57 -0700 (PDT) Message-ID: <06b3479b-11a0-48fa-8fd7-3a885ef64a6a@redhat.com> Date: Thu, 5 Jun 2025 09:39:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm: gup: avoid CMA page pinning by retrying migration if no migratable page To: Hyesoo Yu Cc: janghyuck.kim@samsung.com, zhaoyang.huang@unisoc.com, jaewon31.kim@gmail.com, Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250605033210.3184521-1-hyesoo.yu@samsung.com> <20250605033210.3184521-3-hyesoo.yu@samsung.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605033210.3184521-3-hyesoo.yu@samsung.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TmcI94tT2m08Lq_QIkZR10dSDMJLycQriE88dzN9sG4_1749109198 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 745971C0006 X-Stat-Signature: h5nuy5ocikb71jrxqrzo17ruzqg1fa69 X-Rspam-User: X-HE-Tag: 1749109201-180665 X-HE-Meta: U2FsdGVkX19Hfr0bkpogCG9HYKHMjUiB8DQeySHNX32W2qOTXd8fTPMF2WW3FCfVVVgwoyd7wVyKWKsKBpH7yqJ7XQiOxQnGelbFSVtrC6e5xrLWal470pc8wpSNe8e8rW4vncDgFlcJ30qD1cNhlV5+yXeaDxuhyHGREFv6yKa5lLtMecSb4Mvf6pElhZA8fIw/wgHBLpC/i/xkzNyPQzbOR0acYbwL1YCo4QriXk1GNg9RH5UwFu+dzgPqnadmvVuT6OaJ8D57dwZyXUpyLNiVtBmwxuoPhhC/ZaXCWtM+mI5ZXCncllrG9BSajicCIjQITN/UTYF7S4AiIDDHBKAd+ZRJxd0LCzY+xEKJsWf99eYJD8lpeaSvTjlF6K27IWszBM0dcwqexEgZ5u7DLKEA6JrrI3eFSzFth3s4eEFrWHW5bQiP6C/P7OQSyhbtjmlNyXD0bs5ethXdJkuZp0cru5F982R0y3cD5UPVsDMGZlDZf2CyD/bPekGOCspDcHYzuSJGB/fKpNBBin52uQ4qnN6FQgSObjzorUSKhJ/PoV5/3xyCOIZHBABOR0sf3KrcuuJZyFT9pzf5Us0pOOp5IDLd8AnzVs9T8EYch/6MjbZU7EJq0Io4Jpjmb/a2Ve6ZIObkXDgJVmGzUSZEaqss2zkgBAl6SnwJ94cPWpz4NyaZiDVVsg7s4fKEpBelejOZyPHdJOf4L7J5WSPppwNd0yGfXT1gY9voKq0OmanmINI16Gp4lQUx7g16pNTqoDcMbEV9rNIcBKyRAeEwMUvnjlsz8T/modLKHY90ldy9v8ldIsZI5ngum3eaza7oFP0bCsnSoZD4Ab9dNDZotaSlDYltaLIL+kBUYK5JVJBfyhZH/zVwl08X7n7CyoagZB7aUS0mGw3bGwYgDrG0A7UH0vUUhiUZToLxox3tF8maHx85xYkUJ02y59WeTbB2Y8fk0wIsorwS+dKaJaN hqqtjTxX VxyD0JPFhhXKwOCb9cSsLmOkgqM0um4TujnJ07epm1jZ7LIj358UOvtLinp1amzDFd4XFsJG0HMaOqNWTKEK8/YXCanek8O+4W5uqdkItJtku8o1IHgh6n52kZeQlMy9L9NFfexrb20vDGIzrTWwuk8KYGuMIFfWMm8Vd/aL9AQigThi5BF3JB4QIWCStRKccUQyyqmTEMqLf/zpECxAGJWlNeFEPjLTDycx40Lg66JaV0Y4hd8/xXSkwlMZq/dYvr+2RV9dFrgqEvGPce3+LiRZVufwxlsVluefQsxb3Ne+3rjtaeo9Zl2F6wGKrKgmOCLQ++OGeujl3Yp3/ApKEWSZciYol+vaNS9uRvYK5VWLFmtSKGGM5aSv8HiQFtj/hBngjipQLfgsJHaPXk1B99iCugAwhP8JWmDvk/rdFoL6zW/CJCoL7hrXA/dMHZa78fwX8zJgyzoUS5P85+vADsVuWywy1hLQT5r0NFxNxJeP9ExN5bKqROg31O7qnPxusFpj9bTqK2RYS0oU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 05:32, Hyesoo Yu wrote: > Commit 1aaf8c122918 ("mm: gup: fix infinite loop within __get_longterm_locked") > introduced an issue where CMA pages could be pinned by longterm GUP requests. > This occurs when unpinnable pages are detected but the movable_page_list is empty; > the commit would return success without retrying, allowing unpinnable > pages (such as CMA) to become pinned. > > CMA pages may be temporarily off the LRU due to concurrent isolation, > for example when multiple longterm GUP requests are racing and therefore > not appear in movable_page_list. Before commit 1aaf8c, the kernel would > retry migration in such cases, which helped avoid accidental CMA pinning. > > The original intent of the commit was to support longterm GUP on non-LRU > CMA pages in out-of-tree use cases such as pKVM. However, allowing this > can lead to broader CMA pinning issues. > > To avoid this, the logic is restored to return -EAGAIN instead of success > when no folios could be collected but unpinnable pages were found. > This ensures that migration is retried until success, and avoids > inadvertently pinning unpinnable pages. > The fix should always come before the cleanup. But Andrew already asked for a separate submission, so that will be taken care of. > Fixes: 1aaf8c122918 ("mm: gup: fix infinite loop within __get_longterm_locked") > Signed-off-by: Hyesoo Yu > --- > mm/gup.c | 28 ++++++++++++++++++++++------ > 1 file changed, 22 insertions(+), 6 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 68d91b000199..a25c8c894882 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2300,15 +2300,13 @@ static void pofs_unpin(struct pages_or_folios *pofs) > unpin_user_pages(pofs->pages, pofs->nr_entries); > } > > -/* > - * Returns the number of collected folios. Return value is always >= 0. > - */ > -static void collect_longterm_unpinnable_folios( > +static bool collect_longterm_unpinnable_folios( > struct list_head *movable_folio_list, > struct pages_or_folios *pofs) > { > struct folio *prev_folio = NULL; > bool drain_allow = true; > + bool any_unpinnable = false; bool any_unpinnable = false; bool drain_allow = true; (maintain reverse xmas tree) Apart from that LGTM Acked-by: David Hildenbrand -- Cheers, David / dhildenb