linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] fix cleancache config
Date: Thu, 23 Jun 2011 18:12:01 -0700 (PDT)	[thread overview]
Message-ID: <07301036-485e-4b0e-88db-7937857d1977@default> (raw)

> It doesn't make sense to have a default setting different to that what we
> suggest the user to select.

Even when configured on at compile time, cleancache functionality
is inert unless the hooks are registered by a "backend" (e.g.
zcache or Xen or other future code).   If configured on,
a backend module can dynamically enable cleancache functionality;
the cost is extremely small, so all postings of cleancache
had "default y".

Just before Linus merged cleancache, he insisted that the
default be changed to "n".  I didn't argue, just changed it.
However, I think in the future most distros will prefer to
have it set so the functionality can be enabled at runtime,
thus the help comment is inconsistent with the default.

> Also fixes a typo.

Don't know how I missed that one :-}  Typo fix:

Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>

Dan

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2011-06-24  1:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-24  1:12 Dan Magenheimer [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-06-19 15:29 [PATCH] fix cleancache config Rolf Eike Beer
2011-06-19 21:50 ` Christoph Hellwig
2011-06-20  2:07   ` Randy Dunlap
2011-06-20  6:06   ` Rolf Eike Beer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07301036-485e-4b0e-88db-7937857d1977@default \
    --to=dan.magenheimer@oracle.com \
    --cc=eike-kernel@sf-tec.de \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).