From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C817BC5AE59 for ; Fri, 30 May 2025 03:02:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61C686B0082; Thu, 29 May 2025 23:02:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A5B86B0083; Thu, 29 May 2025 23:02:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 494856B0085; Thu, 29 May 2025 23:02:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2A7E76B0082 for ; Thu, 29 May 2025 23:02:52 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B03FEEB42E for ; Fri, 30 May 2025 03:02:51 +0000 (UTC) X-FDA: 83498076942.26.EA57EC5 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf08.hostedemail.com (Postfix) with ESMTP id 38BCA160005 for ; Fri, 30 May 2025 03:02:47 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=A6eq1F0x; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf08.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748574169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DAgpEBG7lmS2E9GcUvqSz/E0dYP9VfRFSqUiZg8V0VE=; b=qcg2QCMbFZR5yguaYLJH4C6MRGSrechgpd4eHFs1Vzeprd6NTvr0OOaOKW2xC4PtroPuPa yOxlGkNKyQf3Yw3fuhuodPQ5H4bNseshJ8gP0kEtRx4QFmZ/pih9/yMiE8yVsEOtsn5OsV t8lAEb0bHSxl46KFpdktuXrFouDYPA8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748574169; a=rsa-sha256; cv=none; b=wYGfGYtE4aa4hfk4thbCHKSmaksOuRIJZLChCa2w8JrsPtJBDG6shKf1VwsIwc4fO/KnGq 2arcFahjgl0gs2lP96rFaq9En8nIcbeQ4IqKmyMtz9g2CKsdtUxWEnOZAUAaq752ptWQe6 PGhkx6ZSZDmZE4Bx49NjEjyNc3SkjGM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=A6eq1F0x; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf08.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1748574165; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=DAgpEBG7lmS2E9GcUvqSz/E0dYP9VfRFSqUiZg8V0VE=; b=A6eq1F0xLRUjOi7Y7i1lJYwrCO8oXZ5QCuI7JQJlg15dBHuJ7gk/F6HwfJa8eSX4hp3CTlYshHpSzT8nHaensCoiITA1HPATDDJ7cFJmz7dVNUoXFCHpFz3vw1FFNcqYkN1dbp8TW0u3ERHFphMnWcGSB9gsj8eDd8fUrNeFEog= Received: from 30.74.144.115(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WcJjWJe_1748574162 cluster:ay36) by smtp.aliyun-inc.com; Fri, 30 May 2025 11:02:43 +0800 Message-ID: <07b4db81-095d-4f02-a34f-16f0743039ce@linux.alibaba.com> Date: Fri, 30 May 2025 11:02:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 03/12] khugepaged: generalize hugepage_vma_revalidate for mTHP support To: Nico Pache Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, david@redhat.com, ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org References: <20250515032226.128900-1-npache@redhat.com> <20250515032226.128900-4-npache@redhat.com> <469db7d1-ba99-4dc7-af13-b5fe850d4031@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 38BCA160005 X-Stat-Signature: 7iwihfoiy1cb8nysifh7axyscfbzrdm4 X-Rspam-User: X-HE-Tag: 1748574167-542935 X-HE-Meta: U2FsdGVkX18vy9IxatFTWLK+GyK+6mtVL4bbBLJ5S4oB+0zDe7m/+i5XSanRTXd7CXu/H1FPIqYo2qV5/o/75N9RpluRdAjRdpPcdCW8vmK7gRPpYfX2lBfTLGHqkgjU6Q6/igSmF058Sn6aGq7QZov2ta8fd+Syl16SGUeMViNCBaGOc8NjPQ5CkuMi2D29YyXmpG3GBN8K6MT+yDTLYWotgOvBOeFWUyQSRxBp7sO3FMamgq28LKXIxy+bVNXK7MtLznCN+JPhDnerLGmneJJ7nLoE+72Um8mladKPDiKAA3Idnh1Lev9uVDOfFcao0fyXqVRhK3z0PqJM/URef/RdUnQtpwB2u81wYGtCjQoH9GmROkF8fX+kqWMupVYMmAMkWNyf1+aUqrVO2iVIL92eXnKPlxR9bz+g4tT2qCloAGUOLHZNzFmwkvGbf3yC1iCzNVN36bCt/bUCTQqkakyxzx2kpbvObWK2shZlMK+sdvtJcEDRH1U8dDcv7LUJUf64nnVw82aAiW+o6fez38BAE3OSqefa8QI0oBJ/PSGbGa6JQW2pY2qwsA5LJertx1DcieMo8LpVzuwBtOaXkMjozQsPVYrodD1hKBW+VvqCNdtn/jrOaSGvOrxMdoo+kJAE86a+OkTQsdpCSJXlkKb6it2uA+1qw/a0dymkICerC0O54DCJr0yTq/T61GH0H4oSlsAlwoh3wmqLJSBPqaeqfIf509iftMtw+5rXlelggdSA5RAI2PXQ4uFtEc/NaYvASy+ngrLgW3vljvKaSlXAGFWDfJJPBOh7Ul9d59xkk3SAqHrdkXiRnQBONmsCf+00Of75eGzoBAorDFGQe3OSZcefUEIkpuWSksyZ4F4Z9AbZJv+syPM03Y+LrESaeOX2boUYs4hFuuWVc+MZpng5fVMpeH0/r1eBYrt00VWZ11LKG6z4PtY1nSyhgeE5VuqmdNjzxUyciWDRlVt vMzNgQ+f TLyPWsVnoWU+uRLzJtJQk1+115CpBRT5fp/ZHW4H2iBGJy1kLqC+iON0xm7sGYHseRO4UozFhW7IvNG0Fqf10p7PF1TcW9xwAU+SAW7Bh0T+08M1ZId0SGmnXPq3tbdX9K9Bs41uA1e3sRrQI1J2DX76iut6Og5gA4v5d83en90TxojM1S+cuNiEntgbSOtLOVgBagru7p0AoSom71bLHoVSk/RdfZAPyOLUz/wk08W62LjvCffxzqfZEm+N8hSsYnPb11mgwBdPOAhIhEByohGRMJEDuLrZ0aN5WVUO5Ytne/3VTBSaEF16lPcb0FuamWHLpdef0HeUctxYeXV7ttON7RBOfowdarpS8p7dM6mG3VFF31+Al8fIgW8UQRhlUm/kRDB85NlYdH0gCEp1QylwaZRVU8dEpKvVH9cRyOzm6zxRYCe2Rq755Bb0gyUo4GaYBo+uSlbHOKwLPflrM/5RtqTu2Z2MAwIWFuyVnJd7R4opPo8OBStLe7CQpD4E2thbCjDWeeWE9rhZJR1LiZiX1j2KQgcj+1Un5vike+5waaz3WsFBpVmnceYu6hDbWmgr3ajo9qElnkyY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/29 12:00, Nico Pache wrote: > On Fri, May 23, 2025 at 12:55 AM Baolin Wang > wrote: >> >> >> >> On 2025/5/15 11:22, Nico Pache wrote: >>> For khugepaged to support different mTHP orders, we must generalize this >>> to check if the PMD is not shared by another VMA and the order is >>> enabled. >>> >>> No functional change in this patch. >>> >>> Reviewed-by: Baolin Wang >>> Co-developed-by: Dev Jain >>> Signed-off-by: Dev Jain >>> Signed-off-by: Nico Pache >>> --- >>> mm/khugepaged.c | 10 +++++----- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/mm/khugepaged.c b/mm/khugepaged.c >>> index 5457571d505a..0c4d6a02d59c 100644 >>> --- a/mm/khugepaged.c >>> +++ b/mm/khugepaged.c >>> @@ -920,7 +920,7 @@ static int khugepaged_find_target_node(struct collapse_control *cc) >>> static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, >>> bool expect_anon, >>> struct vm_area_struct **vmap, >>> - struct collapse_control *cc) >>> + struct collapse_control *cc, int order) >>> { >>> struct vm_area_struct *vma; >>> unsigned long tva_flags = cc->is_khugepaged ? TVA_ENFORCE_SYSFS : 0; >>> @@ -934,7 +934,7 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, >>> >>> if (!thp_vma_suitable_order(vma, address, PMD_ORDER)) >> >> Sorry, I missed this before. Should we also change 'PMD_ORDER' to >> 'order' for the thp_vma_suitable_order()? > This was changed since the last version (v5) due to an email from Hugh. > https://lore.kernel.org/lkml/7a81339c-f9e5-a718-fa7f-6e3fb134dca5@google.com/ > > As I noted in my reply to him, although he was not able to reproduce > an issue due to this, we always need to revalidate the PMD order to > verify the PMD range is not shared by another VMA. OK. I see. Better to add some comments like Hugh did to make it clear.