From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32374C83F17 for ; Tue, 15 Jul 2025 15:34:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B898B6B0095; Tue, 15 Jul 2025 11:34:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B614D6B0099; Tue, 15 Jul 2025 11:34:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A77446B009A; Tue, 15 Jul 2025 11:34:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 99DC36B0095 for ; Tue, 15 Jul 2025 11:34:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2806B1DA56A for ; Tue, 15 Jul 2025 15:34:25 +0000 (UTC) X-FDA: 83666895690.09.B7F9453 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf19.hostedemail.com (Postfix) with ESMTP id B37F91A0004 for ; Tue, 15 Jul 2025 15:34:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=weuKPp28; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8JCEqK1Y; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=weuKPp28; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8JCEqK1Y; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752593663; a=rsa-sha256; cv=none; b=T/CYtMXb5FK5jBkOYKiFf+sER/mtaLeKVu7c5cnDrjK7BH0tbihxuI4dOtnbifhvUiYCnZ T9zJWspXLC7/BEFRI7DYIQW3CW1YEU40xkB9Ae4n6YziV1rfT4im4O3G8BntmfZGfInW8M 9L6JlxGQrHsg0oy/lD4h2FV/PqXcszs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=weuKPp28; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8JCEqK1Y; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=weuKPp28; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8JCEqK1Y; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752593663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qNoq8mHkdJD9dv4Bl1KFQ2tFDOhjLYSD+a5dl7OxpgA=; b=HfLLShJadL/6xguefFOBA17KQULoDNGJ01j1hPiuf2G9e3dMojUETK6sMM2gBKhlUZDq8F zxYKvjoGiKb0hbAIMwSkv3btJqsV+JocMuQqg9JxC2VkiDrTUYFY0yGYENDPhwAQKQWAM8 XVWfsR5y4Cd1+AFhBz9dktRn9WwpVNw= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0CCCA211D4; Tue, 15 Jul 2025 15:34:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752593661; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qNoq8mHkdJD9dv4Bl1KFQ2tFDOhjLYSD+a5dl7OxpgA=; b=weuKPp28UfQ08F+RICd3TblaQpRkO1BgArnR0V4zXcceO+SL3Ki8Zt4vBX+eMcHvSERwp4 O4/F7KpOHAimGMyMlct5cpbao4OBFDsMYAlm3tnNJ43ZGNbYZVrZRjihCC1KjZpt8+OTYn g8zZW56j1OTA2Vl4qJ++T0+gU5qkiqY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752593661; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qNoq8mHkdJD9dv4Bl1KFQ2tFDOhjLYSD+a5dl7OxpgA=; b=8JCEqK1YRa4VJlBX+hud9zeOA+/yVU0WpsJiWaY2kMp4uiMc1C9ouX/esYqo7BeZECG9UZ pdGRuXDw6UIrIwDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752593661; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qNoq8mHkdJD9dv4Bl1KFQ2tFDOhjLYSD+a5dl7OxpgA=; b=weuKPp28UfQ08F+RICd3TblaQpRkO1BgArnR0V4zXcceO+SL3Ki8Zt4vBX+eMcHvSERwp4 O4/F7KpOHAimGMyMlct5cpbao4OBFDsMYAlm3tnNJ43ZGNbYZVrZRjihCC1KjZpt8+OTYn g8zZW56j1OTA2Vl4qJ++T0+gU5qkiqY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752593661; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qNoq8mHkdJD9dv4Bl1KFQ2tFDOhjLYSD+a5dl7OxpgA=; b=8JCEqK1YRa4VJlBX+hud9zeOA+/yVU0WpsJiWaY2kMp4uiMc1C9ouX/esYqo7BeZECG9UZ pdGRuXDw6UIrIwDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D4E9E13A68; Tue, 15 Jul 2025 15:34:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id PeCSM/x0dmhkYAAAD6G6ig (envelope-from ); Tue, 15 Jul 2025 15:34:20 +0000 Message-ID: <07d3689c-185e-496e-a0b8-53bb3194f0da@suse.cz> Date: Tue, 15 Jul 2025 17:34:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 2/4] mm/slub: allow to set node and align in k[v]realloc Content-Language: en-US To: Danilo Krummrich , Vitaly Wool , Linus Torvalds Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Alice Ryhl , rust-for-linux@vger.kernel.org, Lorenzo Stoakes , "Liam R . Howlett" , linux-bcachefs@vger.kernel.org, bpf@vger.kernel.org, Herbert Xu , Jann Horn , Pedro Falcato , Kent Overstreet References: <20250715135645.2230065-1-vitaly.wool@konsulko.se> <20250715135815.2230224-1-vitaly.wool@konsulko.se> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B37F91A0004 X-Stat-Signature: nd1qprmhcr9m3n1az9a35ptx6x69cpbn X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1752593662-736960 X-HE-Meta: U2FsdGVkX1/d1hKTW0m0zfrF5S3uffX6mfjr1tehPBAofRYqvzTtT8aA2GJ5j9w0X/xuJCwleaLGuhovhfehxj5Vp+uwp2+b4nV8fsD+ve0PoBPuHw7nlMqTEnht6wVExE00iVi3pYaAf8wKRE/zKNEkVdFGIaZfYppjOQmEWYX2qxAe/Mapuk6IaYdyl2yHDPMNP1Y+RDgJbS8FDkeord5BG8dM3U8NHWIHnXopAOVNKexVoJkniR8u8aNPo3fUBLfwLQLnb4mrV9ftlhCrueVknBd7oOzphJTntaPn58OBDUQk6naJ4oD1oyUkd2lYn7T7cKKWlkYJlLo+vIhvsnLhfrc79w+MwUObimW3ldHdtsoEDhcK6+Sg5cI2Gzba/9CM7RvJwXJLpCHj4hQkRI/NAw4ZxN/9P6UJIvGzyK02r2PnxNxxWjVtnsfw+0L6SRga4AHuWhTreoPWp2J2WyJyK9eNsboVqT+a2rpIo/4Dqgl+n/9xYULlX+RTerlFcZcVR4PfxVDzREYEoHzZnGocKzwn9qHrCRMDwCKAv+YjJC+C0OetGbvpV4ZSWXi/CxpVWEDjwidEB/WcPhxq0eGP6XwlLWDPUdojWFq62MBLWt1W+GkeumkJCAg/9YuiFdTlCZ2cPvYLncLvvkcOICu3UEg8J4tHDLmnu/kSaNmTSjT4X65tbvJN8GBF9mA+m+43K5TazhCGVoj8MCuFCt/j9QRbXTbsQz+VL+QqHfnVEpjfyCsqrkD27Z3P14MG7+SAjNSUjFZOGOt6APAHdlGseN+dYYbBmq9iyBflPLslofqKQ48SQNihoPk4ljoRHpiVrHeE1qJe1Tz8s8J+57Mt5NgFkQxLe3e5pQWcQ1jejRpkzYuGD9BY3CGUqJRUee69Srozde4go5rnPD44skAWshvu/Mz2Tk7q4w/KNLGK4usPCz6pZa1YMkYC0pEv4Iby0IIiAk3eOQPCL/O 4HZL0MAw u2RX2JRmDqUazVBPidz2n7OhhPgobVdeKyGMrCwBAd4/Hz7ub6DAX9bLPq3ZV3EC4lPx0tOu+Ki7pqSfg3ji2UXjc8GQRIsUNGWQc9Hy3A9SGvDTydkQmBRxfeG+83cZtPAfl5pmj8ZVgEdXJ1ppcYb41OWXuxSv7u6SVvJT6qNipY0LmJGA7YgCxrZrC69BR7PcN5V1EeJIvxpO12k053NmWDCSErrAoXvxGLjspbDJq7mPYOBZhWX5x/LuS6LZj/q+1ftp1F0QQGcEsvKulV8Cs4jXTL+Pjoq3b8SjuhCCwfcVLOaJCTqWaBrQ+/u3cmrlYORa1t5n6FYusD8GTR/YNKp3b34t8tcEE9wJ44ApZy8z15Lg1+Dy/ag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/15/25 16:33, Danilo Krummrich wrote: > On Tue Jul 15, 2025 at 3:58 PM CEST, Vitaly Wool wrote: >> diff --git a/fs/bcachefs/darray.c b/fs/bcachefs/darray.c >> index e86d36d23e9e..928e83a1ce42 100644 >> --- a/fs/bcachefs/darray.c >> +++ b/fs/bcachefs/darray.c >> @@ -21,7 +21,7 @@ int __bch2_darray_resize_noprof(darray_char *d, size_t element_size, size_t new_ >> return -ENOMEM; >> >> void *data = likely(bytes < INT_MAX) >> - ? kvmalloc_noprof(bytes, gfp) >> + ? kvmalloc_node_align_noprof(bytes, 1, gfp, NUMA_NO_NODE) >> : vmalloc_noprof(bytes); >> if (!data) >> return -ENOMEM; >> diff --git a/fs/bcachefs/util.h b/fs/bcachefs/util.h >> index 0a4b1d433621..2d6d4b547db8 100644 >> --- a/fs/bcachefs/util.h >> +++ b/fs/bcachefs/util.h >> @@ -61,7 +61,7 @@ static inline void *bch2_kvmalloc_noprof(size_t n, gfp_t flags) >> { >> void *p = unlikely(n >= INT_MAX) >> ? vmalloc_noprof(n) >> - : kvmalloc_noprof(n, flags & ~__GFP_ZERO); >> + : kvmalloc_node_align_noprof(n, 1, flags & ~__GFP_ZERO, NUMA_NO_NODE); >> if (p && (flags & __GFP_ZERO)) >> memset(p, 0, n); >> return p; > > I assume this is because kvmalloc(), and hence kvrealloc(), does this: > > /* Don't even allow crazy sizes */ > if (unlikely(size > INT_MAX)) { > WARN_ON_ONCE(!(flags & __GFP_NOWARN)); > return NULL; > } > > Do we still consider this a "crazy size"? :) Yeah, with "we" including Linus: https://lore.kernel.org/all/CAHk-=wi=PrbZnwnvhKEF6UUQNCZdNsUbr+hk-jOWGr-q4Mmz=Q@mail.gmail.com/