linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Balbir Singh <bsingharora@gmail.com>
To: Pingfan Liu <kernelfans@gmail.com>, linux-mm@kvack.org
Cc: "Jérôme Glisse" <jglisse@redhat.com>,
	"Michal Hocko" <mhocko@kernel.org>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	"Aneesh Kumar" <aneesh.kumar@linux.vnet.ibm.com>,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/rmap: fix the handling of device private page in try_to_unmap_one()
Date: Tue, 24 Mar 2020 11:04:17 +1100	[thread overview]
Message-ID: <08df8238-d894-a748-05c0-ff4fd90d2984@gmail.com> (raw)
In-Reply-To: <1584885427-4952-1-git-send-email-kernelfans@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

On 23/3/20 12:57 am, Pingfan Liu wrote:
> For zone_device, migration can only happen on is_device_private_page(page).
> Correct the logic in try_to_unmap_one().

!DEVICE_PRIVATE implies it's a cache coherent page and we shouldn't bail
out - Could you clarify what issue your fixing?

Balbir Singh.

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 2501 bytes --]

  parent reply	other threads:[~2020-03-24  0:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-22 13:57 [PATCH] mm/rmap: fix the handling of device private page in try_to_unmap_one() Pingfan Liu
2020-03-23  7:34 ` Michal Hocko
2020-03-23 23:32   ` John Hubbard
2020-03-24  3:50     ` Pingfan Liu
2020-03-24  0:20   ` Ralph Campbell
2020-03-24  4:21     ` Pingfan Liu
2020-03-24  3:47   ` Pingfan Liu
2020-03-24  9:14     ` Michal Hocko
2020-03-25 10:54       ` Pingfan Liu
2020-04-01 14:10         ` Pingfan Liu
2020-03-24  0:04 ` Balbir Singh [this message]
2020-03-24  3:55   ` Pingfan Liu
2020-04-01 14:17 ` [PATCH] mm/rmap: fix the handling of !private device " Pingfan Liu
2020-04-01 15:58   ` Michal Hocko
2020-04-02  7:40     ` Pingfan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08df8238-d894-a748-05c0-ff4fd90d2984@gmail.com \
    --to=bsingharora@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=jglisse@redhat.com \
    --cc=jhubbard@nvidia.com \
    --cc=kernelfans@gmail.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).