From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90751C4332B for ; Tue, 24 Mar 2020 00:04:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4EA552073E for ; Tue, 24 Mar 2020 00:04:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jg5R2FO/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EA552073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C1B626B000D; Mon, 23 Mar 2020 20:04:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCCB26B000E; Mon, 23 Mar 2020 20:04:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABAB06B0010; Mon, 23 Mar 2020 20:04:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 914E86B000D for ; Mon, 23 Mar 2020 20:04:26 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 67DC08248047 for ; Tue, 24 Mar 2020 00:04:26 +0000 (UTC) X-FDA: 76628308932.11.bath57_26b89a7255040 X-HE-Tag: bath57_26b89a7255040 X-Filterd-Recvd-Size: 6570 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Mar 2020 00:04:25 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id b22so8063268pgb.6 for ; Mon, 23 Mar 2020 17:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=bq1OcHl3S6Uc2p2aDpeRxBMiZcdcvdC7cs76y4ztATM=; b=Jg5R2FO/9cDvx+KGKCWTQqz8pdE6+hJ1YV4a3elJtwP9DOg7WpAWLeC0F34ZYzu55f OvVd3OLwAt6pp7RznqNtR2LGK4tpcJPZanl9LB0KfWFbV5BhJKw/8+kNJgcHiIqAuoJJ 4Nua+JujgQ9B+Crt3DP2KxTTrx6PuVp5D3ygi/YwmH/oPzz6olHge8Wespi0nIBq4Lkq DVJWeSBEbpOGjPVIat6vCKxW7Ip67PLpWOccnL6g8b1D8KurnbuV0CZ2QwgFqvcbN9ZF XwYiYd13imQSYDniwt1YLzlbL87W76fEzeEFi+lVCXyUnPc0U9vcveY7pOjtNL+ZGX09 GhHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=bq1OcHl3S6Uc2p2aDpeRxBMiZcdcvdC7cs76y4ztATM=; b=kLd38n5YzoFsxrTCsXh/7BHiX8QKxeN7ytMLjAYCWI/dVbx2iQKBLp6ljNTOJ/ol1R t2uzg3Tp5V8vPXhaAsBrpprOPtsfhWtn8uqxDUNAk2Yw6WVZR5Beu7nYRqJcyswJcyol rYvxmD+75+Pzq1FhZxO2lD2bjKU2ggi/9GgZvQ5yNeNqY+zfRtymz3XoJjxr7Mcu0Sl+ 58x7XCrdEITb4iVfEBa8d8lbwxb193cFbznTXjADL1J/2IfKJ46XyooTPgJHIyHN9jXQ +G9PomKHdd9MlATNrz/ZRqyTMkJGgvmOhaGT76qDZIsrcJWDH5QgNmuVY/QL9ZIhh29O bMEw== X-Gm-Message-State: ANhLgQ2i23NuHwcQt5Wnae3S9LUDz59QRTVTCTXKHFvwSVm0WoSkAWIe mNPI+5HFvCyZAhGeeaXTOTk= X-Google-Smtp-Source: ADFU+vsJ1tVsQKX42O1X9Xv/gwWmihXt7XHqpqRgCb1JiiQOpMSoStsQLXhKfFD3l3M3cD+1i0wS3Q== X-Received: by 2002:aa7:83ce:: with SMTP id j14mr13308814pfn.310.1585008264583; Mon, 23 Mar 2020 17:04:24 -0700 (PDT) Received: from u2f459ca2e0dd5b.ant.amazon.com ([54.240.193.1]) by smtp.gmail.com with ESMTPSA id c11sm14589952pfc.216.2020.03.23.17.04.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2020 17:04:23 -0700 (PDT) Subject: Re: [PATCH] mm/rmap: fix the handling of device private page in try_to_unmap_one() To: Pingfan Liu , linux-mm@kvack.org Cc: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Michal Hocko , John Hubbard , "Kirill A . Shutemov" , Aneesh Kumar , Andrew Morton References: <1584885427-4952-1-git-send-email-kernelfans@gmail.com> From: Balbir Singh X-Pep-Version: 2.0 Message-ID: <08df8238-d894-a748-05c0-ff4fd90d2984@gmail.com> Date: Tue, 24 Mar 2020 11:04:17 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1584885427-4952-1-git-send-email-kernelfans@gmail.com> Content-Type: multipart/mixed; boundary="------------BCB700A7E2DD38D8377FD9CC" Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a multi-part message in MIME format. --------------BCB700A7E2DD38D8377FD9CC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 23/3/20 12:57 am, Pingfan Liu wrote: > For zone_device, migration can only happen on is_device_private_page(pa= ge). > Correct the logic in try_to_unmap_one(). !DEVICE_PRIVATE implies it's a cache coherent page and we shouldn't bail out - Could you clarify what issue your fixing? Balbir Singh. --------------BCB700A7E2DD38D8377FD9CC Content-Type: application/pgp-keys; name="pEpkey.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="pEpkey.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- mQGNBF54BwIBDADwzy4QmOIiCHQkP9F7Gii+AiOiLcFpWeY0dRaGZeDRACh0t6QX 3Dm2p3ZSTxNdbUzBXE2SWRASPQOnrtzwsOjqqpfGYIbYBJcULo2A6LrVVlvhFl1o zGTDPiX6phctkPGftJrzpd57RQkIeJ6hca/QcE+RHYMKYLuyJcEgLoXpwKHUW/8l 4dPc33WgqqL5VpvUMEshXGGuTeY3aMk0Qp+ldPXRKQGGMC8XrkYNsFpjH8S0eIC9 DVwO1NJiUwQCkwrSEFGL82mzaz/TRQcJDLADW63ol17js8JVLnqL+jEDlrASRtRy kSWFsV/9FgKkRgvNqttDSuoNIqQ7QK2CmViwntNYOMzjUbEIfXuy1TrTvbocuvdn gm/BWeYlPtjiHJ5z9v7/FjW5skUE/cwSpnbJ2EOCVXX3AJXf3WJUjn1ByjLrSbTZ 0gTzI8zDYqHfP7IWOb3yB8yLOU222fWjrlmqO2cqotey5Ni4gMeb/k3sIi4P/uWV GyJeCeaFfBDzwAMAEQEAAbQkQmFsYmlyIFNpbmdoIDxic2luZ2hhcm9yYUBnbWFp bC5jb20+iQHUBBMBCAA+FiEEvy85yRdoJPGMDzxeqcBJVkwQB2UFAl54BwUCGwMF CQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQqcBJVkwQB2Vf4Av/bH4d 87hDsko87XaU2icVt0ixarLC7vItrGGYxyPneWsqG8aCA9Yph9pDxEsDxYoUK4IX vCky6kf/yFA4ItwUWHqxtEN2JQDi9Zx12mLNe9poZiTGM3bEwHf0x7kZWzrfIQdF /QkhcLO/CT8L+iU3VPEd7VNDCu8fUpgz1JcpXx8M+5xKho4YOIpmyPvw94E0KDow 5kR/9luJ0/s63StfOYjAn/SYlfEyzsZbi3Z5Mv/U5h4/BLAcHZtTapxZ8bkUmArh LwlTIdRVme5QlIcp6sU954BD7vUljTFz+vI0CtAzOUvIFelggFJ+1yZmgMj7WEUM jGrcCZPMV3gX7fq8Nxrk5rZFz9L/6RSBwABux9UFplFm8YnqP9kFV6Oua1Ykabk0 ELOf33eIlpnLd21xGcN9HiWPBNagzQCwpqDhaA2J61csLno9jX9itEfofJItj7tT /aB9pN/TWL4b0Qzk937yzHIsJetw7ng1QBVdvStxseubQjwrP9dOz0VHqvunuQGN BF54BwQBDADDblFfzmfOoJb0Z6z+H2k+OGpYVZekQVIAG62SHKGtwoUkS7eYq5fU 6IME8svnzYYeYdQMozHwLiVb1MXF2SkYBHEXqsC9oqfhgKroeRj+ZrUqTecCTXMa 59S3x6ygPcX3TO6J6ehzzC2EsfcLpNphXaW2l3PVGhlIoFCOdum4RNmXqEleaEHu NqpmdVHrRcBaMwhceXe0WGyULtwORQ8EFct3yeBWA0i5np0/iPjZfCKQ6RsPwOzr 5MXFcln2Ne8f/4BNvDA6HBtutbmYcl1bFz6HDi2Uk2hYY2QzVP4QrjZvNZwBoQqe iHdwtDPJeTbOVfQ2ln/zWPDLjTdNcDuG9dcrEg5iTQr5vSxzPJE95FjnaAkMPECc eWehC0ir2mVtIyCZIXY4S0IZYfTkodsLl4VoRzl82VF+9zZMrz7j5TUggUN4ow/R wdlUkAKQzD7MbTie4PmXsj/79hdoxA4kAS63aHXMrdlUSt0XvLB9HeCwPKuLHEOH 89guPW+QVfkAEQEAAYkBvAQYAQgAJhYhBL8vOckXaCTxjA88XqnASVZMEAdlBQJe eAcEAhsMBQkB4TOAAAoJEKnASVZMEAdlu38MAKyMxP/kgW3D8sKQHrxtmLX0RiQC LKQuAFKmp3Z20GXVeiOKDCqLin8klvEcLIJ4OrLj4JT/v00NzHs4i+V0ZV575DqI oQIZwGIQvK0K0kIYCBCizHW2EeVdSngJKS45hnT3TmADPeoFUlAebGkmqgBoyDsG KSapxIO6SPXFSDBnGV9GeT5aHXBMCnA5PXhTLxPIf+7b5GSExmuPfFy2OrNmsIti tMyyydzpGdG9fvi9biC/taEA/GbjBOPgVgB3qO4NzHnyQcYFsnTNaoOntERAYH37 BcWO7EG0+Xx2xAisLp7IOmNYzEBs9CTIcIypuwc1mGlznS173D5YFhezEBjn5jP8 zFasuXiQWYTPRAZBrCxGogTz1UApbU7vbBVnOsBThVdPb5YJY4R6kELyTA8NQp+/ 5H36SZXZTFIPXIBn6p/DcfnlsnLKiscNewYpoxRwNl1kuUUNtvpQpQGMiyiUhy5T t8N27HWBKnTTl49X+mpkeUQQK0cbMQZEIqlVuA=3D=3D =3DDEoJ -----END PGP PUBLIC KEY BLOCK----- --------------BCB700A7E2DD38D8377FD9CC--