From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DCFC43465 for ; Fri, 18 Sep 2020 08:53:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DA6C0208B8 for ; Fri, 18 Sep 2020 08:52:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W/z/lqMI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA6C0208B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E34FD6B005A; Fri, 18 Sep 2020 04:52:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBE628E0001; Fri, 18 Sep 2020 04:52:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C85A86B005D; Fri, 18 Sep 2020 04:52:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id AF84F6B005A for ; Fri, 18 Sep 2020 04:52:58 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 64AE4181AEF1D for ; Fri, 18 Sep 2020 08:52:58 +0000 (UTC) X-FDA: 77275567236.13.rose23_2605d3727129 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 3C79118140B67 for ; Fri, 18 Sep 2020 08:52:58 +0000 (UTC) X-HE-Tag: rose23_2605d3727129 X-Filterd-Recvd-Size: 4854 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 08:52:57 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id w3so4437684ljo.5 for ; Fri, 18 Sep 2020 01:52:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=asjClMEVQUugwRnuiCaRpILyUTB6qCyLua353zU0XaA=; b=W/z/lqMIRm38/rH5hoC1y6v6zRQO1N/LODV5dyUEiJu3Z0Ysqlp/3+8L1e9rLDMk2m sBItJh8qIyGYm03eIK0hTdBoxXVBw4cghdDiPSwhWAZoWgfzs33gNea15pJClLwx2PyP hHZXDHkjh03U3WZVcKBTqEHufGASOVouVB4m7BE5RIoKEh2joN3kIYcDTDJq0Chrbk2i J/NdgDEshJe1yWvUgaAnM4jfYus4kL1oPcAFg4fuHOSe5l7mwswJJ6COScNBGhNcGGPN q/gR4vXJlWd2ZXlKnLgsRNsC12UFA86our5/zZc8O5yxXBZ6W0BJN8M0aPB9fejtttXs Ecww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=asjClMEVQUugwRnuiCaRpILyUTB6qCyLua353zU0XaA=; b=cvq4WIm2J2D4MzgZ6Ze5vd2kxb5F5oxSIYaofDEcs09fxFB8reWz8hDoSyVN/IV9Ag R56HcbX9sKGDd3xdgcEsDdGKR+EIZkV0xNUOb6TYGISPNoShXDp/BqFwArO4h95ukjaw Q9I3O1f18z8agkr0c0QrKIRxCVHzKAqlrHrowy4mdQ9iR7FzFFUQNQVVKKmq00KrWXR9 bWb5NQtU1iGiI7V8H2umV3Mric4Kp/zgX7v7dU8tViPXF50NNcfuLnEMl6bPTlQMXACI NyGt8rnGNBvaZAW0/xxSJs3nVtinX5BmNgzLi5CIhMvrj537zIkn1meniI6bA9jHP7GV Sreg== X-Gm-Message-State: AOAM532TBstmsjjH64dHCyHAsjDMghe5wCHu8APsxVCjfvHMiicA851R 6/DWZpjSOdQVzm8Sv6/3slg= X-Google-Smtp-Source: ABdhPJy1RlFuj0xDkan2bS2ZV4OPmRHWdA9YyD0WopBAfX+NGu2O9O4BkfmuLbcTQkb9zURbzOO0Aw== X-Received: by 2002:a2e:a48c:: with SMTP id h12mr12544381lji.221.1600419176113; Fri, 18 Sep 2020 01:52:56 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:44fb:767f:35b0:3244:6cdc:c4a2? ([2a00:1fa0:44fb:767f:35b0:3244:6cdc:c4a2]) by smtp.gmail.com with ESMTPSA id u1sm459692lfu.24.2020.09.18.01.52.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2020 01:52:55 -0700 (PDT) Subject: Re: [PATCH 02/14] block: switch register_disk to use blkdev_get_by_dev To: Christoph Hellwig , Jens Axboe Cc: Josef Bacik , Minchan Kim , Stefan Haberland , Jan Hoeppner , Joseph Qi , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Andrew Morton , linux-kernel@vger.kernel.org, nbd@other.debian.org, linux-ide@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-pm@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org References: <20200917165720.3285256-1-hch@lst.de> <20200917165720.3285256-3-hch@lst.de> From: Sergei Shtylyov Organization: Brain-dead Software Message-ID: <091931b1-eb9c-e45e-c9e8-501554618508@gmail.com> Date: Fri, 18 Sep 2020 11:52:39 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200917165720.3285256-3-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello! On 17.09.2020 19:57, Christoph Hellwig wrote: > Use blkdev_get_by_dev instead of open coding it using bdget_disk + > blkdev_get. I don't see where you are removing bdget_disk() call (situated just before the below code?)... > Signed-off-by: Christoph Hellwig > --- > block/genhd.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/block/genhd.c b/block/genhd.c > index 7b56203c90a303..f778716fac6cde 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -732,10 +732,9 @@ static void register_disk(struct device *parent, struct gendisk *disk, > goto exit; > > set_bit(GD_NEED_PART_SCAN, &disk->state); > - err = blkdev_get(bdev, FMODE_READ, NULL); > - if (err < 0) > - goto exit; > - blkdev_put(bdev, FMODE_READ); > + bdev = blkdev_get_by_dev(disk_devt(disk), FMODE_READ, NULL); > + if (!IS_ERR(bdev)) > + blkdev_put(bdev, FMODE_READ); > > exit: > /* announce disk after possible partitions are created */ MBR, Sergei