Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

[Dave Hansen <dave.hansen@linux.intel.com>]

On 03/05/2018 01:14 PM, Khalid Aziz wrote:
> On 03/05/2018 12:22 PM, Dave Hansen wrote:
>> On 02/21/2018 09:15 AM, Khalid Aziz wrote:
>>> +#define arch_validate_prot(prot, addr) sparc_validate_prot(prot, addr)
>>> +static inline int sparc_validate_prot(unsigned long prot, unsigned
>>> long addr)
>>> +{
>>> +A A A  if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM |
>>> PROT_ADI))
>>> +A A A A A A A  return 0;
>>> +A A A  if (prot & PROT_ADI) {
>>> +A A A A A A A  if (!adi_capable())
>>> +A A A A A A A A A A A  return 0;
>>> +
>>> +A A A A A A A  if (addr) {
>>> +A A A A A A A A A A A  struct vm_area_struct *vma;
>>> +
>>> +A A A A A A A A A A A  vma = find_vma(current->mm, addr);
>>> +A A A A A A A A A A A  if (vma) {
>>> +A A A A A A A A A A A A A A A  /* ADI can not be enabled on PFN
>>> +A A A A A A A A A A A A A A A A  * mapped pages
>>> +A A A A A A A A A A A A A A A A  */
>>> +A A A A A A A A A A A A A A A  if (vma->vm_flags & (VM_PFNMAP | VM_MIXEDMAP))
>>> +A A A A A A A A A A A A A A A A A A A  return 0;
>>
>> You don't hold mmap_sem here.A  How can this work?
>>
> Are you suggesting that vma returned by find_vma() could be split or
> merged underneath me if I do not hold mmap_sem and thus make the flag
> check invalid? If so, that is a good point.

Um, yes.  You can't walk the vma tree without holding mmap_sem.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>