From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6157BC433FE for ; Sat, 8 Oct 2022 03:22:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7CD96B0072; Fri, 7 Oct 2022 23:22:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2AA86B0073; Fri, 7 Oct 2022 23:22:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A19D56B0074; Fri, 7 Oct 2022 23:22:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 92B036B0072 for ; Fri, 7 Oct 2022 23:22:43 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 46F11C0CF0 for ; Sat, 8 Oct 2022 03:22:43 +0000 (UTC) X-FDA: 79996335006.12.4597D27 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf20.hostedemail.com (Postfix) with ESMTP id A8AB41C002E for ; Sat, 8 Oct 2022 03:22:42 +0000 (UTC) Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1665199360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VBW+bvnL5i50BkAPUWYpIsJVocJvNtR4CUdFoCZ1wWk=; b=CCw0xblUcmAxhmwNRPRPUFnH1N6nhjzVu1qDJJItMHls1BuBOOe7QtuMk20yb2ZhowvGOQ cb09F49jeOL26wM5y8LEUEke2OKl1HE3yPsojBskC18AeY3oMbU3zBJPs9OZZvJYtCfHxY 1P/UmZNUVNfa28wPTdjzMIi6pk9oAZU= MIME-Version: 1.0 Subject: Re: [linux-next:master 12548/12775] mm/hugetlb.c:6835:6: sparse: sparse: symbol '__hugetlb_vma_unlock_write_put' was not declared. Should it be static? X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Sat, 8 Oct 2022 11:22:35 +0800 Cc: kernel test robot , Andrew Morton , kbuild-all@lists.01.org, Linux Memory Management List , Muchun Song , linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <09F76B11-5440-485C-82F2-C12A140C021D@linux.dev> References: <202210080448.1cB176kW-lkp@intel.com> To: Mike Kravetz X-Migadu-Flow: FLOW_OUT ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665199362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VBW+bvnL5i50BkAPUWYpIsJVocJvNtR4CUdFoCZ1wWk=; b=QOA5w9IhqSJCkvjWQ79WoTp4KbON4nqpn83pSNwTs13JtzmjhjGXWdeWiytDaDJw/oCDPo ow2GbYm9M+emPo/zIG9SxJOndrhE7eXU1gZhyY5Q755/MWYLAfSdAQM/7ik/AeBGZLypul nJ9q4m0mKCmKTHU5fFaGQbRrCMB1Mlg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CCw0xblU; spf=pass (imf20.hostedemail.com: domain of muchun.song@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665199362; a=rsa-sha256; cv=none; b=KYGty8W1MEsthkglAUnFPPJ5S2aRlG+h13rdOxkVt5U7cwsGW5kKR+nU3Rc+GMOItUOEXI T1Y3EeWn887Pkj5z6JWvNE6V36DcQnnMVeX8vBCLFgTlu6RxzLdvhuvU2XTrW5Wuw1sy00 qMQNicg5o8W6XbE83f7JT42Z7OL57c0= Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CCw0xblU; spf=pass (imf20.hostedemail.com: domain of muchun.song@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspam-User: X-Stat-Signature: yybpw4mznmbcta9t8t75s3xnr7r9ijzd X-Rspamd-Queue-Id: A8AB41C002E X-Rspamd-Server: rspam01 X-HE-Tag: 1665199362-666390 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Oct 8, 2022, at 10:24, Mike Kravetz = wrote: >=20 > On 10/08/22 05:00, kernel test robot wrote: >> tree: = https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git = master >> head: 082fce125e57cff60687181c97f3a8ee620c38f5 >> commit: 95b61bfed8291e54f65e1fc836c5f9b49f74068c [12548/12775] = hugetlb: take hugetlb vma_lock when clearing vma_lock->vma pointer >> config: x86_64-randconfig-s022 >> compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 >> reproduce: >> # apt-get install sparse >> # sparse version: v0.6.4-39-gce1a6720-dirty >> # = https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit= /?id=3D95b61bfed8291e54f65e1fc836c5f9b49f74068c >> git remote add linux-next = https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >> git fetch --no-tags linux-next master >> git checkout 95b61bfed8291e54f65e1fc836c5f9b49f74068c >> # save the config file >> mkdir build_dir && cp config build_dir/.config >> make W=3D1 C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' = O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash >>=20 >> If you fix the issue, kindly add following tag where applicable >> | Reported-by: kernel test robot >>=20 >> sparse warnings: (new ones prefixed by >>) >>>> mm/hugetlb.c:6835:6: sparse: sparse: symbol = '__hugetlb_vma_unlock_write_put' was not declared. Should it be static? >> mm/hugetlb.c:459:12: sparse: sparse: context imbalance in = 'allocate_file_region_entries' - wrong count at exit >> mm/hugetlb.c:530:13: sparse: sparse: context imbalance in = 'region_add' - wrong count at exit >> mm/hugetlb.c:597:13: sparse: sparse: context imbalance in = 'region_chg' - wrong count at exit >> mm/hugetlb.c: note: in included file: >> include/linux/mm.h:1282:17: sparse: sparse: context imbalance in = 'demote_free_huge_page' - unexpected unlock >> mm/hugetlb.c:4969:20: sparse: sparse: context imbalance in = 'move_huge_pte' - different lock contexts for basic block >> mm/hugetlb.c:5340:17: sparse: sparse: context imbalance in = 'hugetlb_wp' - unexpected unlock >> mm/hugetlb.c:6221:25: sparse: sparse: context imbalance in = 'follow_hugetlb_page' - different lock contexts for basic block >=20 > Apologies for missing this in the previous fix! >=20 > =46rom cabb47237ecc48fceba767eee90f9b311876b329 Mon Sep 17 00:00:00 = 2001 > From: Mike Kravetz > Date: Fri, 7 Oct 2022 19:15:08 -0700 > Subject: [PATCH] hugetlb: fix sparse warning for > __hugetlb_vma_unlock_write_put >=20 > Declare __hugetlb_vma_unlock_write_put as static. >=20 > Reported-by: kernel test robot > Signed-off-by: Mike Kravetz Reviewed-by: Muchun Song Thanks.