From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E790C71135 for ; Fri, 13 Jun 2025 21:18:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D72C16B0088; Fri, 13 Jun 2025 17:18:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFCC66B0089; Fri, 13 Jun 2025 17:18:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9D556B008A; Fri, 13 Jun 2025 17:18:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 96BF96B0088 for ; Fri, 13 Jun 2025 17:18:27 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C9F221612C0 for ; Fri, 13 Jun 2025 21:18:26 +0000 (UTC) X-FDA: 83551641012.15.649AC5F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 98CBC80006 for ; Fri, 13 Jun 2025 21:18:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="BkxOnX/g"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749849504; a=rsa-sha256; cv=none; b=b7HYC0wrfyw0omU2Ygc4/5OqH+1RJzWQf3TzaTyc6ghyrqfvY6AKlBiX/kebcS7rwh/Apo JMeg8c6fFf3cxsSceErJm1GySTCeaQtYAQ3/nlDIeehWcOGqrFfCe4xJ36DLadvfKFjGnn iBOZjWyD3QwWkLDY9AwRyak3OpsGb/M= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="BkxOnX/g"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749849504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ufscstiQHCbS9G1pdl0dbNIBD2ajGNOtHVKChNRSU3k=; b=GZdsSWV246NAwFXzA02NmKhBzWkodRVJc8ac+HGVDx7oiCFSse5sr+q0RB7jjkOcS+mulM 0jhDOpMTXz7V2BkTmM23yjZBIIEEA0Gj/CftBpl4ZRCgs0NlSqxl1WAgIaR2oVDRqQtULc nVB02NV3zqez3eZazxvYNVaW39+c6fY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749849503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ufscstiQHCbS9G1pdl0dbNIBD2ajGNOtHVKChNRSU3k=; b=BkxOnX/gBfKRD33FD84jFgAt+ygZRxVRyMvSUuZUa7yGzUekVd+PC7BkZsITjNpx+qMJEA 50t0uZ+JW59jEE2LG8su8BqSNdZiISkiq2KbNuxvmWvhjUW+aXzL1w37qEwKcGeGOUPAiP 4tDflGJ4aodR5x0w0nIcB1TsgY5ZlBA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-BlBS_CjoMH6EOGyk-kht3w-1; Fri, 13 Jun 2025 17:18:18 -0400 X-MC-Unique: BlBS_CjoMH6EOGyk-kht3w-1 X-Mimecast-MFC-AGG-ID: BlBS_CjoMH6EOGyk-kht3w_1749849497 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-451deff247cso19572765e9.1 for ; Fri, 13 Jun 2025 14:18:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749849497; x=1750454297; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ufscstiQHCbS9G1pdl0dbNIBD2ajGNOtHVKChNRSU3k=; b=O47/men7C0lruWBG0OYZp7NXNP27x36mLZ9TRMDrmXjS9bc1mOkCZ1brIOsqnqqI8/ e9eB0bj5NMP6H72FlId26rNefqcRMTKM1VPgolrt7kbHpkStTxeTMaFuEI0Fq1CSPxlt HOO/u2923Yp+PUZtNRtJTrPLkWoRpzkiKnLaxG/Tqp/2TBPlw7HozeGvK18xDGnxJflz 23w2E/R14r7a2ADEz0VkUPpBBsotV3vRjQ1654u/f1p0t85DU2kEOT4O1cb49MfE4aDI N2d16wcXxrLoQRfhIcbfQEVseOfCZfWDl004k0De/0ysCLsgLuKFj3iODP5CFtqgjjU2 jA8w== X-Forwarded-Encrypted: i=1; AJvYcCXgnhFgypEI+STB7zfbdCJ79WWu/IIYMRC+4tpnLebd/yll5qVWNlg+zywlwNRuL8V8kXuE8xnoZA==@kvack.org X-Gm-Message-State: AOJu0YyQ/JimQBk2IuhiiK9IqZDsjAxmKrSC1KLjcTcTAjxuRobM2ihQ CdE1BbI5H0T1oNC6KZwPJiv6s6GfoNs3ge8h7JK8LU3T0R33Mv2l19k9t58krBM9NyvwzrAtCV5 R85PE4GWYIl9K9plkom/LY6HEeRFnqr8C7PmMWZfk1be90AXTDc+L X-Gm-Gg: ASbGncstOEyIFzxpYyz/2cgx2q7iRhie82eibZA+s0rgVW/p9M4nJzZWvClGIeiI5fC ghwn+UhXJ3hXACN8mMxvzYsXo8WiSjs/5KVUKb0olfwDaGV24HZ3PhWcCPV/HucygrjKMz9l4pq x22Iy68FXeG03WLb69Mx9XHRlIHMJ9cyvseRnv3oG+zfuoSdHl0Flml8ljjaLRVw1TPq5MPEZBp nAewlU4ZgEXifeA1p7Yz84ub5nvujxHZxcW1xJb0rW8IB1Ca3W16MSxizS8F1qk0F3iF/DjA1BK FGT6p9QltIoue5MtNSd6wsLGaipLfNrHb0T2fgx2hCzwciNXJhirefdnEUnI3KYxTs55VaReYE3 BD0mddFNWSs3x6cc2Fqb755VoohQDVo+Uu0jScRyXXeczzw3TYQ== X-Received: by 2002:a05:600c:8b45:b0:43b:c6a7:ac60 with SMTP id 5b1f17b1804b1-4533c92e57bmr12391035e9.10.1749849496936; Fri, 13 Jun 2025 14:18:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEOB0FovDmJMWiAczOt+st9w/YGQAhqOEOsMFMcs9zkOeNn6NLpFPp2mWC5LMWJqaHx++tm7w== X-Received: by 2002:a05:600c:8b45:b0:43b:c6a7:ac60 with SMTP id 5b1f17b1804b1-4533c92e57bmr12390675e9.10.1749849496527; Fri, 13 Jun 2025 14:18:16 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4? (p200300d82f1a37002982b5f7a04e4cb4.dip0.t-ipconnect.de. [2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e172b03sm63129605e9.36.2025.06.13.14.18.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 14:18:15 -0700 (PDT) Message-ID: <09b66a3f-e7f9-43b2-be9a-bbf6310b3c43@redhat.com> Date: Fri, 13 Jun 2025 23:18:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 08/18] KVM: guest_memfd: Allow host to map guest_memfd pages To: Sean Christopherson , Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250611133330.1514028-1-tabba@google.com> <20250611133330.1514028-9-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: e_lN05XKPe_lP7uj_SZvCXTBYiR_XDeTTBRhrkReYYM_1749849497 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: 9ythir1kh68phkgj7acztydz87qr94oa X-Rspamd-Queue-Id: 98CBC80006 X-Rspam-User: X-HE-Tag: 1749849503-854677 X-HE-Meta: U2FsdGVkX19dlmISl+tW0OmcE8L11ap03rtP7nYf95+yi86N/iZowku0vESJPp09LbTpABmfdjhaTSWd61kNRrfgpYBSysvA+kPO7DoLb/o96BExbd3k3fhow8D1fX5OrPOGoQO0dFNZN8QQSsAVQwPLVfrVvBGt/syNW8VLEaBONKMLbjcA3Awh08VOJI3jassr04NrOL1+6W6x4RfuWQixvPKJsUipQmNk2Ioz7sYVn7Z6VdNh6urDyRgnoXAk1q2zSRMGgvkDb6010GBAXXWjzMbGNWA7HPu1SSV2O3TwkNwSS4rKZnfc0kzzQZ8BbKkgie6hE10OCQyY2mSwBfwHpVp4PYq6Rqn9/6yZq/Wz10hQYRYJs3xckwN0/2pj0JhBQqhdwUpavQxgFTL9JuPv2dzpfVp4v+5rlnqF3yDxwoovD2gi+6hag0kcoG9WhHvokRMQXCKyVCtXXNsb0XmyibF9UhuqrLy9CDsu0ouCgRNlyq1bBHjDIluchgQcTdPq34lh0KTnTJrNsL1xouVz8QRl2sIMhFurqZPLfY2Jww5RrwMMMIloNYONb0sCKVdpDR7VTw9LHbUeLg29Bad0ykZdw+Tu1+EoKq2QqyOdYq8EdpKSj908rkFHyVL29m64eX7y5rkH1utE4HYXdI6ZheklYRjV9rX41CmaTN/oJEJbTqOxi1Voxcrp/tGpDvKxTVQjmVky+j90zKAJt3KpuwlEFLIPm+y0/W+LOWx/F0yEECwa2kmeRtXnaZJ4L1FxqEuzX0a2Fl41qV6XuCIgFFxoeMXnySOYkFJKdI/FHH2gLQcdxe8hfXPDXTHDjZWPq2AqMKe86/ImujH8bIBSPlFxv3hdktq7tFMp+sS6NGhLT3McAkgRRrBiUXufz9VEPPAn080D6d9Jwj2aKyLMd+3OtPEMNAgmR/FgsKMZdtjfZsD2qz9IBdeOgepbI3wQ4G12aOz8G46YXsn nozeye01 ZuDwliZ1KqkIpPGaMkRIGz3reEJd4yEKCEIi8CVle+qUW41lb1e1Gyj2ot5g+dmPB9OyLxghIlEHx8Ucv7pIwOsP4Nq+nMSMFLsI2eOYc5yw/rg2eguejNr0WfKX4bbmxLOP6hpc+vPlnHEb0EDdPWqEDaHzgFo9GSsg2VKyWX3GsckoWFeWqNsOV8nHiAVmF3WN3olRVxs5HEX84+r1haSYxgxCdRh9d53ULz2ej7t40OCXyuv1725ZOOqjODHeGEixwr2aQJOkE8n5Sgnrk81I7bq+Ezt3x64bRjTG69rF5SbuKl2cdR/rspa5LAFlyF+tsu9Izk5O8XY4hjAxFIPnEKCXBlFCcRQn3L1tKsx2EIUCuXeU0Id3Uw3+YXVEkXKv9B0BQCFXrNQ58szKU02dTEK4cHksw19Zrfz5PW8mk1buAkZudLr6gseVWL6UL8/+qI1gLC5kWGvjMRLHrXLV5VEEA5D9dIAE9AJ1OLuNxnIG14J/CJdApyFXhhlTWz3YN4vGc4zKFer/DMn0xmnlMH2YAzlhcGxGzrWmxhTMctQxQv6Ar3XCMGm96Ib9m++rfUkJBUHV7PIhuvu4Tm7wFsJnJ/IvmeFj3myNpcznGqAYCEPW9qplK6bhhCkPF/nupvfVxbupWVSo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.06.25 23:03, Sean Christopherson wrote: > On Wed, Jun 11, 2025, Fuad Tabba wrote: >> This patch enables support for shared memory in guest_memfd, including > > Please don't lead with with "This patch", simply state what changes are being > made as a command. Agrred. > >> mapping that memory from host userspace. > >> This functionality is gated by the KVM_GMEM_SHARED_MEM Kconfig option, >> and enabled for a given instance by the GUEST_MEMFD_FLAG_SUPPORT_SHARED >> flag at creation time. > > Why? I can see that from the patch. > > This changelog is way, way, waaay too light on details. Agreed. Sorry for jumping in at > the 11th hour, but we've spent what, 2 years working on this? It's late in Germany on a Friday, so I am probably grumpy, but most of what you raise (terminology ...) was been discussed plenty of times before either during review here or during the upstream calls ... :( Anyhow, happy for your review feedback on this series at this point, but this is just the perfect time to shutdown my computer on a Friday evening, knowing we will need another 2 years until this is finally upstream if we keep going like that. (again, sorry to be grumpy, but this is not the stuff I want to be reading at the 11th hour) -- Cheers, David / dhildenb