From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A637CD37AE for ; Wed, 4 Sep 2024 06:54:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6E138D022E; Wed, 4 Sep 2024 02:54:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1DCB8D0003; Wed, 4 Sep 2024 02:54:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E6D18D022E; Wed, 4 Sep 2024 02:54:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 761498D0003 for ; Wed, 4 Sep 2024 02:54:23 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E22EEC0BAC for ; Wed, 4 Sep 2024 06:54:22 +0000 (UTC) X-FDA: 82526141964.25.A606210 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf22.hostedemail.com (Postfix) with ESMTP id 11E2BC000F for ; Wed, 4 Sep 2024 06:54:20 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hQ2JnREi; spf=pass (imf22.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725432765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3yb/TQxCcUmpmu8fvQZuCvdp6BbxHLd8SOuBHk2wJ5I=; b=lEfLxLN9CxKyRUz/XOKoUcgk3nsbUY69vtOv1tJ3KYrBbBPCco2+ciXTcUMkTAuxHrf8yD ZTTHNrSM5r3qO2yMXelKukkn3oR1JB2zlYjkn6dd5kChKp/h2CnUgm7vjbxoDqfY5GBti5 AkeUGyslBViFK0TxN//CS1yAiOXvkls= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725432765; a=rsa-sha256; cv=none; b=JSZE0dO5paMp+8r84HSE3fucqTkgLFdQeXNQ6Q54dq3A0GWYUL/ZAMtBR/JG1aKL+juYNs aVrqtnXPKJ40Z53mPcgKmOAEiN5sl6QsZcYJGTyVGR1hVEB1ZCh5dp0Y2GxmEt7R/pMcHq uMMh8CiKpqCcJIxEpCfEsy3a6ZrRebA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hQ2JnREi; spf=pass (imf22.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-714187df604so267182b3a.1 for ; Tue, 03 Sep 2024 23:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725432860; x=1726037660; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=3yb/TQxCcUmpmu8fvQZuCvdp6BbxHLd8SOuBHk2wJ5I=; b=hQ2JnREiUFlvC99c3GVulNHofSFn8nG/dmRP2kp6Znc1n5KWvIbuvFfNs8U5piYufn 1tKx1zCLwTsj6lw5EZv5rcmLTg4QOSa+HTCIg8a+NpY4rxkzGulNDh34FDP451fUqLtl 7JW4WoqyUBDI2auZmBrnvDcZd53pv/UuemPCu/3X+EXbOSQZakZGI/TlbZqE1iiTF1z4 nKNOt4tSuXgXqbxOJHzNW2ZGUNz9ap+oRNfVDabTKx+a+PJdOuhdOs5u+Elb2UU7OLtT H4ba6kG0Uql1bLjakZmguWo2y+Ptm1Wuu/lV26XG7ws4WkiPi1vj9ZGIbsAgu31av0wB cPPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725432860; x=1726037660; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3yb/TQxCcUmpmu8fvQZuCvdp6BbxHLd8SOuBHk2wJ5I=; b=iZZ/S05nprCKtc5+qj+0VntulHUA4CRjzQVVXAqQK09hatKrljx/6DNRlxegwz61lH tyb3bGmA9VJIAj/AVsldS8L9ZHoVRB+ryhwog8IW9E6Odcr46SU+ycyQYEicswbLNieA VDnRi7Z8n0kSST7WXdTH7WqDTcFYxL5aEgHMMWd7zm588ygn000n++98dERjBItDSKZ0 JDCHvTroDOwhkPaVsyEqEQtYlXdtfBIKMZa0+0yHJJLu6a1B9O+kawZZCZECcmJvDERT mhdw1qM/cGMtzQ5lj7/eMojBK1mDd3TLmgUMsmqyx/3mMZYLiGyaUe+FNQqArqu+7NQU TUeA== X-Forwarded-Encrypted: i=1; AJvYcCXf5HeYeQ1zJxzibXCG/EIPwbTkUy+CFGSJPZL/IMTEiEhWy6s2aFu24IJJOFB5sXK769g6aXqnPw==@kvack.org X-Gm-Message-State: AOJu0YxfEBPjlTCL36gBJLYCSOpSKdgRtlkG2Y97ACX6+CLE1I/RVWFa B+19KSjUPM89c2LiKAAEQyCHXNA2yR+K2BAwa17QFSXe80IEEA+y X-Google-Smtp-Source: AGHT+IE1VlNh4g2nryUwcxgvOEeUzMloemr3a4LHWwmYxYZ+h9mPGpX1Mr5jXtH1qG/hEED81fZPNw== X-Received: by 2002:a05:6a00:2291:b0:70e:98e2:c76e with SMTP id d2e1a72fcca58-7177a930f7emr1804014b3a.6.1725432859448; Tue, 03 Sep 2024 23:54:19 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71778598ffasm932388b3a.167.2024.09.03.23.54.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2024 23:54:18 -0700 (PDT) Message-ID: <0a10e61b-f0e6-4423-996c-7884c93af65f@gmail.com> Date: Wed, 4 Sep 2024 14:54:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 00/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool To: alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com References: <20240902072136.578720-1-alexs@kernel.org> Content-Language: en-US From: Alex Shi In-Reply-To: <20240902072136.578720-1-alexs@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: w81nssmrcfdyn3zkfzceguaajmosfdnw X-Rspamd-Queue-Id: 11E2BC000F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725432860-788728 X-HE-Meta: U2FsdGVkX19YoLMorO3hst7jOD0kEonOX281pbQzBX3GGWXgJM0HvoANmeVJzwQPqC2HWfXfnBojFJN4IknBe5UbvL2eDzWt+i3tFBxt1u3dkFTSeQtwekcObk3Qpw0IeqlvtJlQVppALg95bLzCJ6xMM5Y9PtdGkQh4ObW/7Pu1ZQJB50i3amFdo/Ox7T0ISPw4v8LCfYxcbQg5R8KhsRc2OfBfY/D0Pkh8u116nIHRdL8E52PdrwWb3NwoI68oY6z2hJ18CoSNXVH2Y8lXFq+7nF1uMkSvNCh2gLKG8tCQ3FBHGUzwxewAj4svUj23lUx0cuvcyKLTXdW/PD+4irIRoSYtWt7tRcRcUwdaU0+iQifOu7aw7I9DMxEYgZ4avM40iXSMNzhlTpNdLiHYYh6FACj88xRB3sooAtrfWjvcA9W9uUA6BqArNuPWf7WpoOOUtQrdka8iIkmXo6nmlX4Q+Ytbbmso5EmUfzDaVjHUORFG2IPlftJwAgm2Ss02BrpqWFwQbRKNNY4n2vFzdcVJHyfn3ML+w6c/cH74nnaaMZ1iuxehUkqf08smr0xJtR2ViWMQPvGiNwx5J5A6nISCrFxvZNyTrIb1Q4kUODFx+B+UwHWgUcdgd92CjH5RIDX+h/BQJLTVH2QwykE1NXyUM3mRAZntvfQeOAJJw58jSBdlHtTxz5sfBNUXZ9DYBbL9+oQ47UHk0/iNmI379xUlLCh1NQoU5pk+rRRv9XvlIYjHLEX3nRNwwmrmnCqrvhR7ag0GJVI4ALcISXJqL1xaTJkWcMRC4+oLxf2dzOGoe+QesYh8jCtHqVLCGLGolVZqVrJgs+8QukuTEx4lxp6RLjvFt9oU0/+ozPpJrb/YFQ3TQ+4i5jV0Gl9Qs4Rqx8q0vYwLn3TIgnUD5wPXCkc0MhpCEuT9YuN+SjzzuaK9TemwWO8ILRiKnJ791BZ3QrhimP0D3SqXcmGWooj 4I50iKwg NH1dSR5IrskybqrjByi6rRFC7UoCrT/gvI+1EhTn8QJKUOnhibCdukmFKfhN/JNEbg1Xl8mZQNfB8im9VmJcvGJgqqs+EYSvCrn4IgunF9upMPvLdQHmMA/EYNBD+BN3Ml1EqCvb54GetnCSUeevSLA31SadrTL3sxIjXOclhpX2R7QzVtprNIJB1u5DdidaLsZaGQ7iQz2Pz76Xrk9cwbEBoklt2oh4GwumFSkyu/+7KNGIIdxudL/gYCR9Wacw1cCTLbG+Eedy3t/PbNCSWbVsTsovZjXRZTbLgGQJCtDELHR+hSTwzHdmNZ8CXZwpIO7Az+dFQ/lWN2aJKOmEMFqcHhywVWr2EiRZ0D1/6rsQFaO49k6wJBiwtyWJtcsBAVKWhYhhF3lmwyhwMrVHrC+AXqUZGeTrF9+Jw5vigWyZnnIuz9MEcySD/i/2zdReG3dl5qU8wkDN0SinAhqUKpaMAAfmd7TMEx+oE0MUCodkKsy7NlBAJxEX+SWDlMDsN6mTn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/2/24 3:21 PM, alexs@kernel.org wrote: > From: Alex Shi > ... > > This patchset abstracts the memory descriptor used in zsmalloc by zswap/zram. > The descriptor still overlays the struct page; nothing has changed > in that regard. What this patchset accomplishes is the use of folios in > to save some code size, and the introduction of a new concept, zpdesc. > This patchset is just an initial step; it does not bias the potential > changes to kmem_alloc or larger zspage modifications. > ... > > Thanks a lot for comments and suggestion from Yosry, Yoo, Sergey, Willy > and Vishal! > This patchset could save 6.3% code size, and it's a nice abstract of zsmalloc memory usage. Is there any more comments, or mind to give a reviewed-by? Thanks Alex