From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A25ADC2BBCA for ; Fri, 28 Jun 2024 03:29:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F4AF6B008A; Thu, 27 Jun 2024 23:29:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A4116B00C3; Thu, 27 Jun 2024 23:29:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16DC96B00C4; Thu, 27 Jun 2024 23:29:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ED2056B00C3 for ; Thu, 27 Jun 2024 23:29:12 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9B30E14139E for ; Fri, 28 Jun 2024 03:29:12 +0000 (UTC) X-FDA: 82278866544.20.717CC3D Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf13.hostedemail.com (Postfix) with ESMTP id 86BA72000B for ; Fri, 28 Jun 2024 03:29:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719545337; a=rsa-sha256; cv=none; b=L+20mB7nV30OkmeneVpBKJ61qz/8uHYyHZ/Y58FsmS0l6hrcT1xO4nza9ymvQuSvpiNzDA /CfCfp4TVRQ67LCLKH4oujsD/sXeD1Uejeg8/M4Yv7QrYtPuAAcLpY0W8cqCQkcotCEBp0 tYwCBRfjHlEpbT3VIH9bpc95O7HgfG0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719545337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eicw9Wq2wS3GCP4iauClwpAI+U9tLE69vObZrxPVB84=; b=1ETmGl81MSYoLeGOghh9NySSFOiGbKzrRZlARUxBGMp61ZKjM4gVQTCqIAXydXggzZfBd6 HA+daEAOAqPz3hPjQDG9IXVX7UTF7otrqRmYnyYs5CzKc0EA/Xu8T/pQEzqNykNFrJ1Px2 9/iQ7DxvtG+SVr+uL7D06I+AWDQQtpQ= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4W9LQh0BxJzjZ1X; Fri, 28 Jun 2024 11:24:44 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id AB3D118006E; Fri, 28 Jun 2024 11:29:05 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 28 Jun 2024 11:29:04 +0800 Subject: Re: [PATCH v6 3/4] selftest/mm: test enable_soft_offline behaviors To: Jiaqi Yan CC: , , , , , , , , , , , , , , Naoya Horiguchi References: <20240626050818.2277273-1-jiaqiyan@google.com> <20240626050818.2277273-4-jiaqiyan@google.com> From: Miaohe Lin Message-ID: <0a28831c-b28e-6db5-0ef3-70940e75d4d2@huawei.com> Date: Fri, 28 Jun 2024 11:29:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240626050818.2277273-4-jiaqiyan@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Queue-Id: 86BA72000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: kbzcz77m1tsuso3fsqz9iutet873znff X-HE-Tag: 1719545349-461942 X-HE-Meta: U2FsdGVkX19OdLSEgPsLjd+6ADuvDo4KqAB25yLDb3jE6bhN1W7u4rcPUTq3OPDiQoQ9f68n8P6zoSwAQsqsrqNn40DCwhc5H9FWyzx/14ZnOvTM/aQSdkGhinxvJqxqC0jzC74zPOWoOlm6a68wBHeiHqtHgcNIBqgytwtUPvaAyJS0WeMxiNSbBnlD/E00KFuPvrUVf3KZO26xVDEEPpSltItRn6W7EyJ3s4/7VhhJpht6rhqqmfHMKB4qm+4JKMqWib42tYcqwb2/CSL6Ti1J5gHX3HgL0VeCk373V/ekbfhrTTIDfAp6RG2FkSeNWBILEFrVciSONokjncrxlBkWwjow04Fk6/WPhXDS0A4LdMHW+YhLDCF3+VHVCvy3Yl9tKkOf7MPm+d+ymsaOl9de0EwWPGysF45YPF4+weDXyPWzrM6dj+9DOKosaVHcM659dGiDf+vQO6jZXm+olRZDBEtHDjiq4qgo+vrG85fyG/rvQh80AVubVF39ftFks2AZ0Vn4LcJ5nqggQPUTIoQ9TYC0LUwJAc1/U63ZCvvfiQgYafgG3iAB3ulaGRL1t7GDwHBN3Gn40yonSGGd44vGtE6v/U4StvtbVguc2e/fi1FDrH4D2qLDRQkpoJ/6zsziULRtlEeCZ+rz/pfkLLgZvcX6uDZQuApdTvCFBKqIA933IprCUnyKmPswviZJzxJgjoXf+rapxMpCswIxqfXgxWyhbZuyZPP7ENXmzi5BE/diiXeiuJ1WjtQbdYxugRlS+tsJC3Xt8P787/vwUdKlsTn1OdlVLg1ZoSBWPy+4CXxoShCf4FHBBtYu9YANYeWuONAxDrs1Tamq6wa5RNDjIcSGTp6h/ijsnpn3Pl49gtpZ2sJKWtwYkdaZPmoS5b8N33yM9P39juldNCCEyF8nhnyiJR0ecwKtQ5i+SuZYVleCUD6OM9WDo5BLmTbSPbjtZyvmMnBllc3r+XS hOn+fxOz xcv8Kbc7gIXiCl8g+yTtmANVsMsGVPX2v74j17NR7OSB5QNDVwS/AP70vY06+tYuYzuB3eHX7QUDiM+BZKPcwyrwzwSFcNFcJhWYhqy70bBbeVNszjo4EAAv1qz+gBQqNQ3/f22iTH4f7r97DNxLk8KHzqlbvT5uMJIjyDUCvvMC7klwGTRJE6bLYXgdFl/QQBQn33fu6cCnhH/TVA6hXR+Zdt4j7q8kqMASEViRyHaDxfvfM+q2+T9UCcgtTPMDLeWM+3JwL9LLSv9AOyCwgTZZUvI+JWqxmTmLbRpBauBOVu04= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/26 13:08, Jiaqi Yan wrote: > Add regression and new tests when hugepage has correctable memory > errors, and how userspace wants to deal with it: > * if enable_soft_offline=1, mapped hugepage is soft offlined > * if enable_soft_offline=0, mapped hugepage is intact > > Free hugepages case is not explicitly covered by the tests. > > Hugepage having corrected memory errors is emulated with > MADV_SOFT_OFFLINE. Thanks for update. > > Signed-off-by: Jiaqi Yan > --- > tools/testing/selftests/mm/.gitignore | 1 + > tools/testing/selftests/mm/Makefile | 1 + > .../selftests/mm/hugetlb-soft-offline.c | 228 ++++++++++++++++++ > tools/testing/selftests/mm/run_vmtests.sh | 4 + > 4 files changed, 234 insertions(+) > create mode 100644 tools/testing/selftests/mm/hugetlb-soft-offline.c ... > +static void test_soft_offline_common(int enable_soft_offline) > +{ > + int fd; > + int expect_errno = enable_soft_offline ? 0 : EOPNOTSUPP; > + struct statfs file_stat; > + unsigned long hugepagesize_kb = 0; > + unsigned long nr_hugepages_before = 0; > + unsigned long nr_hugepages_after = 0; > + int ret; > + > + ksft_print_msg("Test soft-offline when enabled_soft_offline=%d\n", > + enable_soft_offline); > + > + fd = create_hugetlbfs_file(&file_stat); > + if (fd < 0) > + ksft_exit_fail_msg("Failed to create hugetlbfs file\n"); > + > + hugepagesize_kb = file_stat.f_bsize / 1024; > + ksft_print_msg("Hugepagesize is %ldkB\n", hugepagesize_kb); > + > + if (set_enable_soft_offline(enable_soft_offline)) { Nit: should this be written as if (set_enable_soft_offline(enable_soft_offline) != 0) to keep consistent with below code? > + close(fd); > + ksft_exit_fail_msg("Failed to set enable_soft_offline\n"); > + } > + > + if (read_nr_hugepages(hugepagesize_kb, &nr_hugepages_before) != 0) { > + close(fd); > + ksft_exit_fail_msg("Failed to read nr_hugepages\n"); > + } > + > + ksft_print_msg("Before MADV_SOFT_OFFLINE nr_hugepages=%ld\n", > + nr_hugepages_before); > + > + ret = do_soft_offline(fd, 2 * file_stat.f_bsize, expect_errno); > + > + if (read_nr_hugepages(hugepagesize_kb, &nr_hugepages_after) != 0) { > + close(fd); > + ksft_exit_fail_msg("Failed to read nr_hugepages\n"); > + } > + ... > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index 3157204b9047..781117fac1ba 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -331,6 +331,10 @@ CATEGORY="hugetlb" run_test ./thuge-gen > CATEGORY="hugetlb" run_test ./charge_reserved_hugetlb.sh -cgroup-v2 > CATEGORY="hugetlb" run_test ./hugetlb_reparenting_test.sh -cgroup-v2 > if $RUN_DESTRUCTIVE; then > +nr_hugepages_tmp=$(cat /proc/sys/vm/nr_hugepages) > +echo 8 > /proc/sys/vm/nr_hugepages > +CATEGORY="hugetlb" run_test ./hugetlb-soft-offline > +echo "$nr_hugepages_tmp" > /proc/sys/vm/nr_hugepages Should we save and restore the value of /proc/sys/vm/enable_soft_offline too? With above fixed, this patch looks good to me. Acked-by: Miaohe Lin Thanks. .