From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0D5C43460 for ; Fri, 9 Apr 2021 07:43:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D990610A3 for ; Fri, 9 Apr 2021 07:43:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D990610A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shipmail.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6E1466B006C; Fri, 9 Apr 2021 03:43:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 691206B006E; Fri, 9 Apr 2021 03:43:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50B6D6B0070; Fri, 9 Apr 2021 03:43:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 362656B006C for ; Fri, 9 Apr 2021 03:43:38 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CE82918020C51 for ; Fri, 9 Apr 2021 07:43:37 +0000 (UTC) X-FDA: 78012038874.36.DCD1116 Received: from pio-pvt-msa3.bahnhof.se (pio-pvt-msa3.bahnhof.se [79.136.2.42]) by imf29.hostedemail.com (Postfix) with ESMTP id 32A67DD for ; Fri, 9 Apr 2021 07:43:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by pio-pvt-msa3.bahnhof.se (Postfix) with ESMTP id 142353F7A0; Fri, 9 Apr 2021 09:43:35 +0200 (CEST) Authentication-Results: pio-pvt-msa3.bahnhof.se; dkim=pass (1024-bit key; unprotected) header.d=shipmail.org header.i=@shipmail.org header.b=PlWrzoCP; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at bahnhof.se Received: from pio-pvt-msa3.bahnhof.se ([127.0.0.1]) by localhost (pio-pvt-msa3.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TYUFMyAhnJsP; Fri, 9 Apr 2021 09:43:34 +0200 (CEST) Received: by pio-pvt-msa3.bahnhof.se (Postfix) with ESMTPA id C6AA13F377; Fri, 9 Apr 2021 09:43:33 +0200 (CEST) Received: from [192.168.0.209] (h-205-35.A357.priv.bahnhof.se [155.4.205.35]) by mail1.shipmail.org (Postfix) with ESMTPSA id 1EE23361DE7; Fri, 9 Apr 2021 09:43:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shipmail.org; s=mail; t=1617954213; bh=nLyzMwqZi1pS8dIp+5a5AY91s3S25Zv80Z6WNiXvzRk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PlWrzoCPHQSTnemMvEoT5uU667LeDa8BjQkJQCqZLvG+gGbOa1WgskCkKGGL9EJTJ NHBqExDebeLhuE/WmwJfPvpe5RVHjf8k++rbsQug/wW6ZBd7nb1DUKd1dN5zIb3XYB AGilG8zhTb8whaGwgil5IVsQoKVppq2xkKyKpdgM= Subject: Re: [PATCH] mm/mapping_dirty_helpers: Guard hugepage pud's usage To: Zack Rusin , linux-kernel@vger.kernel.org Cc: Andrew Morton , linux-mm@kvack.org References: <20210408191529.677958-1-zackr@vmware.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28Intel=29?= Message-ID: <0a742aa1-572f-a62f-677f-af430d47a19c@shipmail.org> Date: Fri, 9 Apr 2021 09:43:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210408191529.677958-1-zackr@vmware.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 32A67DD X-Stat-Signature: h1ajfjfn7t9oa8h6bwk3uy5gkj9xygar Received-SPF: none (shipmail.org>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=pio-pvt-msa3.bahnhof.se; client-ip=79.136.2.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617954215-648710 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/8/21 9:15 PM, Zack Rusin wrote: > Lets make sure we don't use pud hugepage helpers on architectures > which do not support it. This fixes the code on arm64. nits: Perhaps be a little more specific about what it fixes? I figure it's a=20 compilation failure? Also please use imperative form: "Fix the code arm64" rather than "This=20 fixes the code on arm64" Other than that LGTM. Reviewed-by: Thomas Hellstr=C3=B6m (Intel) > > Signed-off-by: Zack Rusin > Cc: Andrew Morton > Cc: Thomas Hellstr=C3=B6m (Intel) > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > mm/mapping_dirty_helpers.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/mapping_dirty_helpers.c b/mm/mapping_dirty_helpers.c > index b59054ef2e10..b890854ec761 100644 > --- a/mm/mapping_dirty_helpers.c > +++ b/mm/mapping_dirty_helpers.c > @@ -165,10 +165,12 @@ static int wp_clean_pud_entry(pud_t *pud, unsigne= d long addr, unsigned long end, > return 0; > } > =20 > +#ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD > /* Huge pud */ > walk->action =3D ACTION_CONTINUE; > if (pud_trans_huge(pudval) || pud_devmap(pudval)) > WARN_ON(pud_write(pudval) || pud_dirty(pudval)); > +#endif > =20 > return 0; > }