From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE7CC38142 for ; Mon, 23 Jan 2023 14:52:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C1A06B0073; Mon, 23 Jan 2023 09:52:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7718C6B0075; Mon, 23 Jan 2023 09:52:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 612406B0078; Mon, 23 Jan 2023 09:52:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4F3256B0073 for ; Mon, 23 Jan 2023 09:52:28 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1D45AC08E8 for ; Mon, 23 Jan 2023 14:52:28 +0000 (UTC) X-FDA: 80386354776.26.C9DF77E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id E92E2A000A for ; Mon, 23 Jan 2023 14:52:24 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B0h1Jd34; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674485545; a=rsa-sha256; cv=none; b=et+8poeYdqK4S9Ely4SBcWeEA0t9Kpozl9hvECGIrlc/U4LQQm48+1eiHlH3Ut3DrDbOkg q+ARchEte2hA0/eNjGGC2aZFq6nHSbL/g8TRqcews30+9brLQs+1n857WFiGI0mhRmAgcs 3Df29FeU5a2cbPuIWS5rypy4PT/EZ1U= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B0h1Jd34; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674485545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T03uo0w38ySOqZDIO4krSGr7PfEci5UnYfFK1tg2gBM=; b=c04I5kkHCXPachan4oJ+1X6aVLiHfAJIcwQaTSZkDeR37G41jANWXgT3bB++5hyHVUzLdr DpKR8oXKLr/JLS6F6JHRRvJ/TYVUx55ukEZ9hHZdsF9vJjDHWX8a/U/lWAgB8C/HFtVJUf Aghgd8qsRpqfYi3nD65XcGVqCF7p8Bs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674485544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T03uo0w38ySOqZDIO4krSGr7PfEci5UnYfFK1tg2gBM=; b=B0h1Jd34jvgmqP8NtT4os1uUhxvjxCs/iVtRezbHF1YnA1gDI4mCghns/V8owjfx5KVt3+ qUF+rgX7NzuvqqQGf0rrtYngLQY42wsPAErMobBN0wZ06XeIqQdDFVjlH/5NnLgS5rOOQC kFgMKOH5dK+fWyoWc/8DQl36slsSPT8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-561-XguvbFC_NU64x8b-wFhdSA-1; Mon, 23 Jan 2023 09:52:23 -0500 X-MC-Unique: XguvbFC_NU64x8b-wFhdSA-1 Received: by mail-wr1-f72.google.com with SMTP id v5-20020adf8b45000000b002bde0366b11so2072473wra.7 for ; Mon, 23 Jan 2023 06:52:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T03uo0w38ySOqZDIO4krSGr7PfEci5UnYfFK1tg2gBM=; b=eCBI1afAim2EgKUqysqsJIJJxhEuw10vo1nlzyE+WXV6xdg+j2IosuIpm6R6AR7T25 wfITMHDbLr5P6Y1Yy43RuPC9q8k6u4xFfEXOIVykZr21yoEBEtNAjMf8dvsSkiHySvp6 8uj6ODVrop+9dboUVEmM0bf6wNFwM47EkvPrRYmxKatNtdknDDqOKoCuM62oA5OPxa5S zDKrneLLA/0J3xYmRf37OLyaUcNJvR+/Md2/vIJeTwMUWcwxNcdAtyrwzcu/un8DcuB6 yUEilCOnksnTH3ye+3puqSR0fgJTA/OOOI6/izoSARZaXYjIR7meal11ClX6tl2ponRB t2Lw== X-Gm-Message-State: AFqh2kpcNV5DNH0vX2fLhUUQs38/Lu2qly5PH2MiHLVq3ZJuRe/rRkYQ vaVGW2IV7RrNmQoHZim2Y+AK56yW6jiiHi2t4pf4pqX42KEQ8G0mcjH8Pq60kxYTIGFWz4glc74 SNVkd/InQjEg= X-Received: by 2002:a05:600c:181a:b0:3d2:2043:9cbf with SMTP id n26-20020a05600c181a00b003d220439cbfmr24302086wmp.10.1674485542173; Mon, 23 Jan 2023 06:52:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXs4cX35Xv3q9pQQ3Kj5yZfSgNPu8tIJvtHCi/GdKeTxeR5w39usjuny9yGDTN2v9+4Kh+S+Ig== X-Received: by 2002:a05:600c:181a:b0:3d2:2043:9cbf with SMTP id n26-20020a05600c181a00b003d220439cbfmr24302069wmp.10.1674485541943; Mon, 23 Jan 2023 06:52:21 -0800 (PST) Received: from [192.168.3.108] (p5b0c6374.dip0.t-ipconnect.de. [91.12.99.116]) by smtp.gmail.com with ESMTPSA id m18-20020a05600c4f5200b003cffd3c3d6csm11679776wmq.12.2023.01.23.06.52.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 06:52:21 -0800 (PST) Message-ID: <0b2660ee-ce1d-caf6-7f81-9c1fb64b67b4@redhat.com> Date: Mon, 23 Jan 2023 15:52:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 08/10] mm: move debug checks from __vunmap to remove_vm_area To: Christoph Hellwig Cc: Andrew Morton , Uladzislau Rezki , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, linux-mm@kvack.org References: <20230121071051.1143058-1-hch@lst.de> <20230121071051.1143058-9-hch@lst.de> <02bc3d67-3457-ff17-0810-e75555609873@redhat.com> <20230123145016.GA31543@lst.de> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230123145016.GA31543@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: E92E2A000A X-Rspamd-Server: rspam01 X-Stat-Signature: mnt5urx419mhhxtrexkwuo3x1ffpuaqk X-HE-Tag: 1674485544-416817 X-HE-Meta: U2FsdGVkX19jTcCWDfJrsngtNAmxbFbW/a8w7EVXZwyyJPT5eIB2VgD1E0YCeRLgEUwP0rn4RQhNsZvh3h1fDXmKWjH9n2TXyReLfv4qVUTJuR5g6HclqbXgSwRe8VzGIi1jp9RBnMEKg1x4WMTqaMZv6nRzNLIgUvh3c8kWWqR77u6cgkzsSIa51XNG4e63BY3pmWO59NBt+zUSQL7D2Fqz8x+WB9oj91CyJsXDsmDJDrBvNNig3Q7LrsCXM93sZONfP5BPN+HpcdW20cS/CY/hBcS65Dh1tMS7cDGW3SukkgSUj3rQNs1OpMJMsDsXyvca+s9kZ/Wt9SMX/1eeZgFTadbVk/80hkQz3NA3Rq9NEDG/dRrv4CNzjgkj+1EgA2/YD94pNe9YMzXz8Pd4etf1CFBvIUz40M4BmO40FXsWBFYpooBiQq0LsO/tj+7YM6DsYXVx6qKhlZ7H3qvUkk9GwNzBRjUk/fZlswcv2zyCe4VdSEwDxavZ1W18JUffdcjVQXM+F+Cr2uiPwxqD/5aDQlxrsQZox2psRIUkTecXwrPauktw10Z+7qQ8N9c1+n978sLLPxfszWC03SFAyAmkjfteEhgTJOcu3PDAH8vpH/vGozsb5U2TuC7KZE4CgKYIPzwp553Vlppgf5QdeRHwTASf66FX9aFIQKP4gyKGuGj/himhX7RIVxu1KIEe5e4FUO6v68k+admcN4wVtX4/1N0nQ5ZCStuvBDcmgUimx7Tu7dhW+DhrJb31/zGI4ksRGUkXbD5legFNx+yFGnuP7dAtbTyjo9BPbyiQL1SQIlxVuRSsMlWXaU6NfvQloEMI89+u/x3KL2X9atPc0iTMKH3Z2PMRAw07DwYnliYJlaqS6Xas4sU5S5qD8k4gV1CIZBse2ozTrgFTbH8r0WvL50zPYWUKYlOVCOBWDyTgZc+gS+HazdRFAo4aY4f6xS1R+QQUASdt3SDyasP kbGjDHzo LPpkW4U6THwIoEfNAs89A/mNWGK6owKZD1SSFma39rseHOkRNWIfCdHF3Q1ZE8E8swX42wrSplAnh3YiQ96e4wuwxGrsA7bss6Dc53vyERtp6y1Y8c0N1maMeL1Lm/0ULYDHgIZltnjN5G0gwDLFS+IQaPaSSPGpoXgjtpGHX00yg27MIttkQqYTiQphfMCs26gDGjZOSmd9pYDx1rV8EOCDFLz5QQmW2F+afpVotijBMu1wIefDsDQdN6iwRXPX0p9NEl+kWjqEK58CNC0FY3qcGgmKiOQiGvzT4YisCd2K18uInUmF7lKOuZ4TkbEhVQV5BtLL8Y+ryPLTxmxDW6TyYY5IAIImB1apDp/rhjR3VkMiA0cuMwWoF1ZSQnA6uHW2nd9K3ibJuu74wtxtOvF7P/tqUqZ+2AOxVheaJ1ArCH0nD5gFbL9KNE7rt6BMXIdww3ZNWBNpzhweIeK36zUK32282KQC7SmaeA3IKJhdZ/+i5BSeHhvAMoOelVki/flTgfttF0nCnDpshMLW345jAPpHW4jszFj7g X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.01.23 15:50, Christoph Hellwig wrote: > On Mon, Jan 23, 2023 at 11:43:31AM +0100, David Hildenbrand wrote: >>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >>> index 97156eab6fe581..5b432508319a4f 100644 >>> --- a/mm/vmalloc.c >>> +++ b/mm/vmalloc.c >>> @@ -2588,11 +2588,20 @@ struct vm_struct *remove_vm_area(const void *addr) >>> might_sleep(); >>> + if (WARN(!PAGE_ALIGNED(addr), "Trying to vfree() bad address (%p)\n", >>> + addr)) >>> + return NULL; >> >> While at it, might want to use WARN_ONCE() instead. > > One thing at a time. But yes, this makes sense and could be an > incremental patch. Sure, there are some more !ONCE WARN calls hiding in that file. -- Thanks, David / dhildenb