From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8880C44536 for ; Tue, 21 Jul 2026 15:19:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B53B96B00A4; Tue, 21 Jul 2026 11:19:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2B956B00A6; Tue, 21 Jul 2026 11:19:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F63C6B00AA; Tue, 21 Jul 2026 11:19:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 70C4D6B00A4 for ; Tue, 21 Jul 2026 11:19:20 -0400 (EDT) Received: from smtpin27.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DA5351A01B2 for ; Tue, 21 Jul 2026 15:19:19 +0000 (UTC) X-FDA: 85013142438.27.F0D80D8 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf31.hostedemail.com (Postfix) with ESMTP id 2288A2000F for ; Tue, 21 Jul 2026 15:19:18 +0000 (UTC) Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="cxXu/Jgl"; spf=pass (imf31.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1784647158; b=uF16BvCVIra23UFy6RYfHvoOr8PDmc21IpBpkU4WnQTutKGxwjQCsHrZT5jI7ycanZOIlo +f3PlBit805flho9MomyJsaEpz1zQ1bzQL8wnM+grI/dcIy7qbQQSOH+xey7qBvYynqOK1 /gGxHuceGH0oVkR+s02LDkXX7kT1P44= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="cxXu/Jgl"; spf=pass (imf31.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1784647158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NcQHotnRc1YltaL0d91NNFzXPnSIvU2fa84uq1Kqf80=; b=z3j4j3Jr37SbppEcdm0Bj0atrwv9mOH1+Bi1PBhms319BN0kwPIHU8CPa4WQnmPW7RTGZf teLd9Y/YRkq/9sRgXOy/g20TcJM1Yl01CSR0HbNoxA+rw5vHm7TKTzqCkn5Jwssaupu0uZ xI7t0f8sak5MMqS0qEm4lyOwN0QS/h8= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 91A77600D8; Tue, 21 Jul 2026 15:19:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2559E1F000E9; Tue, 21 Jul 2026 15:19:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784647157; bh=NcQHotnRc1YltaL0d91NNFzXPnSIvU2fa84uq1Kqf80=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=cxXu/JglamTfxZku20/hvwti8kyhkeyVDle5r6Gs3gp+SkJnbyhtcGv/c18jtV/cw 7gSgQmx19CA7r6u805JO5I8cZ3xBRPmkyR/TaKUjbH5t+Gm9nKMDsP+xj1jwAvi8dW owS3DMGZ59TLPI3kIqnJaRSYe1gjvqDyjXDBUA50bTQChhd5HKjqPm/P51z59oZg6/ DbaXmu+vpmoqXHG96HzQT4+JM+fRaZglAuD4Kv4OKXvbdx+2jLMN67pqWyuu0y85qm dUyOAjy7uV0NxLmjNVxyy+EME6N/YRuWZvdtvW6P4ZjgS0iJJkfPgii0UTXWZb8cqx way087G+3sExg== Message-ID: <0b9be5b3-93aa-407f-b83d-409bec4b55e1@kernel.org> Date: Tue, 21 Jul 2026 17:19:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/8] mm/hmm: move page fault handling out of walk callbacks To: Stanislav Kinsburskii , airlied@gmail.com, akhilesh@ee.iitb.ac.in, akpm@linux-foundation.org, corbet@lwn.net, dakr@kernel.org, decui@microsoft.com, haiyangz@microsoft.com, jgg@ziepe.ca, kees@kernel.org, kys@microsoft.com, leon@kernel.org, liam@infradead.org, lizhi.hou@amd.com, ljs@kernel.org, longli@microsoft.com, lyude@redhat.com, maarten.lankhorst@linux.intel.com, mamin506@gmail.com, mhocko@suse.com, mripard@kernel.org, nouveau@lists.freedesktop.org, ogabbay@kernel.org, oleg@redhat.com, rppt@kernel.org, shuah@kernel.org, simona@ffwll.ch, skhan@linuxfoundation.org, surenb@google.com, tzimmermann@suse.de, vbabka@kernel.org, wei.liu@kernel.org Cc: dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org References: <178413903133.1155966.3904063656020521607.stgit@skinsburskii> <178413935809.1155966.6398279131483632373.stgit@skinsburskii> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <178413935809.1155966.6398279131483632373.stgit@skinsburskii> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2288A2000F X-Stat-Signature: 69817mhkfhphgaw4eqk4y3eewfczh5y5 X-Rspam-User: X-HE-Tag: 1784647158-347344 X-HE-Meta: U2FsdGVkX18AyI7mgPgC7V3hOUktuwEvpwBAtk/OCsH2mOWifiFZzWKTtpPyYC6UwS6y30SFDHG5d13lwf03OXZUDTf5CFK745liMjpqTvZ4te7ZgctEI6DRhi31C7uvisGVDdYo3sHdRwc8qo3kuknUVfAnGJNPQZ010X5o2ZCFwPQcB+Im/V4Cp4uuXEj8WgDyUveCv9KHu9NkKV/F9WQRpSC2w2uif7ZuDd9w+pgzMNSZfteQmS57Z/L/GSkO5ct7cXDe6F3wVk154KVBCdYT5UfUe0qx8cARSFkZZgku5ytlAarC/cf1DTuvUCsF+urDfyPdKj7rtOkCtNvL8XZw8qJHqVgZH9t6NhxybSsZvtbN8YvTW0YwFro6TFJ2ieHnjBH4YTmFEDwcONxtDkmFmN5Dtoi1fS7j7t5zvefpOAFou+XnfQcCkO29Wrscj949T9Mq5fYqt7wwYMZJIWRReV1X8z6w8P2lOgHkq6EqbaBh2Q/yXfydKOht5Oq2UM4NwJ48e7q8j2f3DWhK0C74dROBtYcne0M7JsTzrHp7GU2t3PMBBidhOrC/0L9FPUCWFVW1El+IZz+7Go3dPqnlnw7d823/oTSUNlvOreqwNJ46b2uyfYiDDrOKssjiGBiL6AmYBatEp/isXiaF8S5tB2rixjfW7UcuST3GWUbCYpqX015tZm0aZPdtuKkdjLFfNZ3P4IxsUx/1KO/R+6WIP/rwQWDHYCiORMNRfVz7U8a3VkhZxtICW8wxdhI0Vfp5EOrm1ucjyR1NrYh77EduCym6lE/ehzJeclcpYBY6cBbf3lq4BR46/g7ytPGFJxFbSon7nrjouwR4vlUkK7cgXCudmN/AWKJG+/B4HEzgweZVC5c+iDh6drH3c2yUOL2yUrMYYwyCB3TseVRcX97ahny3tnH6940XpL16TlPmhRkWPL+cF2JAa7Oao9wbL9MQK+2YhmXMdV+X/3P 4D6tkV9c xK9oaTTYwNumHu3D5FOymDSzjM70KVfJUexBXrXHZRtKGxLPJaNtdpsQWLZYbiyhZ76dzFkLPTTvBRAhNUj+E2GOZ+09JPZmza84s9q7NlFNATknLo3AH13D0K0VsJOfcmNp4ICgA5/sV3rDyI+vrdE0ytDK9yP6/Ool3H4Tmo+WxMHOpvcCzE5PRRUHKJvANaugKvdhOVb7A9PE0gBgqxzBoh58GQYmuZuboqJsriM3SNv6NwFXD5gGVmJa/XYoK49qllrwA8+EaNbxlwszqCNaJKYXyeANcgaxdRQnoQZIVsgp+m+DGQ2tYLQcAHbQNjLY0EYdWnQxWvHA= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/15/26 20:15, Stanislav Kinsburskii wrote: > hmm_range_fault() currently triggers page faults from inside the page-table > walk callbacks: hmm_vma_walk_pmd(), hmm_vma_walk_pud(), > hmm_vma_walk_hugetlb_entry() and the pte-level helper all call > hmm_vma_fault(), which in turn calls handle_mm_fault() while the walker > still holds nested locks. The pte spinlock is dropped explicitly by each > caller, and the hugetlb path manually drops and retakes > hugetlb_vma_lock_read around the fault to dodge a deadlock against the walk > framework's unconditional unlock. > > This layering does not extend cleanly to fault handlers that may release > mmap_lock (VM_FAULT_RETRY, VM_FAULT_COMPLETED). If the lock is dropped > while walk_page_range() is mid-traversal, the VMA can be freed before the > walk framework's matching hugetlb_vma_unlock_read(), turning that unlock > into a use-after-free. > > Split the responsibilities the way get_user_pages() does. Walk callbacks > become inspect-only: when they detect a range that needs to be faulted in, > they record it in struct hmm_vma_walk and return a private sentinel > (HMM_FAULT_PENDING). The outer loop in hmm_range_fault() then drops out of > walk_page_range(), invokes a new helper hmm_do_fault() that calls > handle_mm_fault() with only mmap_lock held, and restarts the walk so the > now-present entries are collected into hmm_pfns. > > No functional change for existing callers. As a side effect the hugetlb > callback no longer needs the hugetlb_vma_{un}lock_read dance, and every > fault-path exit from the callbacks now releases the pte spinlock on a > single, common path. This refactor is also a precursor for adding an > unlockable variant of hmm_range_fault() in a follow-up patch. > > Reviewed-by: Jason Gunthorpe > Signed-off-by: Stanislav Kinsburskii > --- [...] > > pfn = pud_pfn(pud) + ((addr & ~PUD_MASK) >> PAGE_SHIFT); > @@ -564,21 +561,8 @@ static int hmm_vma_walk_hugetlb_entry(pte_t *pte, unsigned long hmask, > required_fault = > hmm_pte_need_fault(hmm_vma_walk, pfn_req_flags, cpu_flags); > if (required_fault) { > - int ret; > - > spin_unlock(ptl); > - hugetlb_vma_unlock_read(vma); > - /* > - * Avoid deadlock: drop the vma lock before calling > - * hmm_vma_fault(), which will itself potentially take and > - * drop the vma lock. This is also correct from a > - * protection point of view, because there is no further > - * use here of either pte or ptl after dropping the vma > - * lock. > - */ > - ret = hmm_vma_fault(addr, end, required_fault, walk); > - hugetlb_vma_lock_read(vma); > - return ret; > + return hmm_record_fault(addr, end, required_fault, walk); Yes, that looks much better, as discussed. The downside is another vma_lookup() in hmm_do_fault(). > } > > pfn = pte_pfn(entry) + ((start & ~hmask) >> PAGE_SHIFT); > @@ -637,6 +621,44 @@ static const struct mm_walk_ops hmm_walk_ops = { > .walk_lock = PGWALK_RDLOCK, > }; > > +/* > + * hmm_do_fault - fault in a range recorded by a walk callback > + * > + * Called from the outer loop in hmm_range_fault() after a callback > + * returned HMM_FAULT_PENDING. At this point we hold only mmap_lock; > + * the page-table spinlock and any hugetlb_vma_lock acquired by the walk > + * framework have already been released by the unwind. > + * > + * Returns -EBUSY on success (all pages faulted, caller should re-walk). > + * Returns a negative errno on failure. > + */ > +static int hmm_do_fault(struct mm_struct *mm, > + struct hmm_vma_walk *hmm_vma_walk) > +{ > + unsigned long addr = hmm_vma_walk->last; > + unsigned long end = hmm_vma_walk->end; > + unsigned int required_fault = hmm_vma_walk->required_fault; end and required_fault could be const. Reviewed-by: David Hildenbrand (Arm) -- Cheers, David