From: Dave Hansen <dave.hansen@intel.com>
To: "Huang, Ying" <ying.huang@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ben.widawsky@intel.com, alex.shi@linux.alibaba.com,
dwagner@suse.de, tobin@kernel.org, cl@linux.com,
akpm@linux-foundation.org, dan.j.williams@intel.com, cai@lca.pw,
stable@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/vmscan: restore zone_reclaim_mode ABI
Date: Thu, 2 Jul 2020 07:36:56 -0700 [thread overview]
Message-ID: <0c1e01bb-bd10-50ab-ded0-9d4f37951f25@intel.com> (raw)
In-Reply-To: <87d05ejgug.fsf@yhuang-dev.intel.com>
On 7/2/20 4:28 AM, Huang, Ying wrote:
>> But, when the bit was removed (bit 0) the _other_ bit locations also
>> got changed. That's not OK because the bit values are documented to
>> mean one specific thing and users surely rely on them meaning that one
>> thing and not changing from kernel to kernel. The end result is that
>> if someone had a script that did:
>>
>> sysctl vm.zone_reclaim_mode=1
>>
>> That script went from doing nothing
> Per my understanding, this script would have enabled node reclaim for
> clean unmapped pages before commit 648b5cf368e0 ("mm/vmscan: remove
> unused RECLAIM_OFF/RECLAIM_ZONE"). So we should revise the description
> here?
Yes, you're right. I updated the patch with the updated understanding
about the implicit use of the bit but didn't update the changelog. I'll
do that for v3.
next prev parent reply other threads:[~2020-07-02 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 15:26 [PATCH 0/3] [v2] Repair and clean up vm.zone_reclaim_mode sysctl ABI Dave Hansen
2020-07-01 15:26 ` [PATCH 1/3] mm/vmscan: restore zone_reclaim_mode ABI Dave Hansen
2020-07-01 20:03 ` David Rientjes
2020-07-02 11:28 ` Huang, Ying
2020-07-02 14:36 ` Dave Hansen [this message]
2020-07-01 15:26 ` [PATCH 2/3] mm/vmscan: move RECLAIM* bits to uapi header Dave Hansen
2020-07-01 15:46 ` Ben Widawsky
2020-07-01 15:56 ` Dave Hansen
2020-07-01 20:03 ` David Rientjes
2020-07-01 15:26 ` [PATCH 3/3] mm/vmscan: replace implicit RECLAIM_ZONE checks with explicit checks Dave Hansen
2020-07-01 20:03 ` David Rientjes
2020-07-01 20:04 ` Ben Widawsky
2020-07-01 21:29 ` Dave Hansen
2020-07-01 22:01 ` David Rientjes
2020-07-01 16:00 ` [PATCH 0/3] [v2] Repair and clean up vm.zone_reclaim_mode sysctl ABI Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c1e01bb-bd10-50ab-ded0-9d4f37951f25@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=ben.widawsky@intel.com \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
--cc=tobin@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox