From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Hui Zhu <hui.zhu@linux.dev>, Leon Hwang <leon.hwang@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Kairui Song <kasong@tencent.com>,
Qi Zheng <qi.zheng@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Barry Song <baohua@kernel.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Hui Zhu <zhuhui@kylinos.cn>
Subject: Re: [PATCH v7] mm: assert exclusive nid/zonenum bits at the page/folio access sites
Date: Mon, 29 Jun 2026 08:22:11 +0200 [thread overview]
Message-ID: <0c3634d7-855b-4f80-99f3-342309d74e10@kernel.org> (raw)
In-Reply-To: <7561266d0aedbb55f3f67090fb2493f7a899b66e@linux.dev>
On 6/29/26 05:32, Hui Zhu wrote:
> 2026年6月26日 17:09, "David Hildenbrand (Arm)" <david@kernel.org mailto:david@kernel.org?to=%22David%20Hildenbrand%20(Arm)%22%20%3Cdavid%40kernel.org%3E > 写到:
>
>
>>
>>>
>>>
>>> Better to factor out a common macro alongside a comment for these two '#if'?
>>>
>> Yes.
>>
>> And while looking at it, doesn't memdesc_section have similar problems? And
>> there are other callers of memdesc_zonenum we wouldn't handle. So the
>> macro approach is only partially helpful I thing.
>>
>> Maybe we should just pass by reference and fixup all callers? Ends up the cleanest.
>>
>
> Hi David,
>
> I think pass by reference is better than macro.
Yeah, as long as there is no other (future memdesc specific) reason to pass by
value. I don't think there is.
>
> Would you like to send this out as a formal patch yourself?
> Or would you prefer I include it in my next version with your
Please review and test the patch (and fixup anything wrong with it), fill in the
patch description (explaining why passing by reference) and send it out.
Feel free to keep yourself author of the patch and add my
Co-developed-by: David Hildenbrand (Arm) <david@kernel.org>
Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
Above your SOB
--
Cheers,
David
next prev parent reply other threads:[~2026-06-29 6:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 3:20 [PATCH v7] mm: assert exclusive nid/zonenum bits at the page/folio access sites Hui Zhu
2026-06-26 4:54 ` kernel test robot
2026-06-26 4:54 ` kernel test robot
2026-06-26 5:04 ` Leon Hwang
2026-06-26 9:09 ` David Hildenbrand (Arm)
2026-06-29 3:32 ` Hui Zhu
2026-06-29 6:22 ` David Hildenbrand (Arm) [this message]
2026-06-26 6:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c3634d7-855b-4f80-99f3-342309d74e10@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=hui.zhu@linux.dev \
--cc=kasong@tencent.com \
--cc=leon.hwang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=qi.zheng@linux.dev \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
--cc=zhuhui@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox