From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F7AC30658 for ; Tue, 2 Jul 2024 11:53:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E2C66B009C; Tue, 2 Jul 2024 07:53:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 093516B009D; Tue, 2 Jul 2024 07:53:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E26CD6B009E; Tue, 2 Jul 2024 07:53:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BDE346B009C for ; Tue, 2 Jul 2024 07:53:24 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 52D17141C30 for ; Tue, 2 Jul 2024 11:53:24 +0000 (UTC) X-FDA: 82294652328.07.BCA48A4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 153581C0016 for ; Tue, 2 Jul 2024 11:53:21 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ok4G4Bih; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719921180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CLzIS6/xqvBtE7oUGCvw27/2uQHcsttu4uuLNGJydEo=; b=1aueqtWllLK5lHRUYetuy+4rLS6x8JFg5WU7UIl497zYslChDXi3ne0ntea278OtpSRfta 0Ia/YTxZCDejseHurSABqF5e6tz5FxhV9FJ6UFwr3MJU54H532QmOd6wUYnBOz+XZWV3rJ 7CbqD9VorBJhWa6sv1J6IleYE/nB42Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719921180; a=rsa-sha256; cv=none; b=BUBdf23Sb/7MZcX24TG3msjWHyPE3TA6iIle5z9ca4+A1QkPVrX4bGhhnuNHG2Qk+SzRau WOy3gP0zQSvev3L0tFpPW3GHWCt6LbBiRLMdF91WKixTCy0PezV4/+FIsFkzbrBUpRohcV mlaCxiSH3KaSqY4rQsOUTkbGfLIgDdg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ok4G4Bih; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719921201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CLzIS6/xqvBtE7oUGCvw27/2uQHcsttu4uuLNGJydEo=; b=Ok4G4BihRFOX2tmCFXbR4vKBTpDbZRciJio70WFpheNUIAsVDd28frd26s2TtOFW/dUmfB iyVoqT6GMxEZiX2KRy0FxX+rNl1ikIckvthVMhdzCgfJrHsixm/m4NOs8fgBoshKAXCYHg EUd2A+CfQMnW6icFAx3oVDg1JmcX1Eg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-66MlXj4pPnSS2rXdcwOeCg-1; Tue, 02 Jul 2024 07:53:17 -0400 X-MC-Unique: 66MlXj4pPnSS2rXdcwOeCg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-363542774e1so4334475f8f.2 for ; Tue, 02 Jul 2024 04:53:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719921197; x=1720525997; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CLzIS6/xqvBtE7oUGCvw27/2uQHcsttu4uuLNGJydEo=; b=HQ8/ay6b/Jx1WAiMihrh83UFNvL2ITGN9aZhFxM69IEg37wM8XJWVKYtNzvzy7Cadc V6qR1D5pAx+Kq0usScJpnoRA+e2bd1smFiJLJmt7Ha5Ydvm39MgfKv/4FMgHYDigD8zE qRsO8DRT1CNcCzdYHGUvzMRxz0hGbd1DAvei72VFDVf9GZajcYgZEnIZivf6e0gVxKmO Qb8oCH89G4LT8h8GM6o02l2N6D8NTMNE6qpgnG2x+oWReToGTssm98nXxXiXK7SELam5 VC1F0H4fXIHepMqXw3vqdxIAW9o1nvTSNkTZqghj/2c9t1e1zBh23IpVD2tNvU7uw9Df 1ung== X-Forwarded-Encrypted: i=1; AJvYcCVgNX1+tXVqoS6LRNqbSInxNQogrAMLqOp4kmZ1Ny2m0rfvHCXiyQQg2xjdtD5NR5cURKB+M82Tm7HQc94H2theB9E= X-Gm-Message-State: AOJu0YzrQk/NdBiwbSp2tbBokWpwTo/1Qcvohtb0B8cZnUIb/pQHiUOZ NkxzhgR6mvMdDgeJkNz3CvwENzWmjiIQ01QWxMpEs5ExZU/lnQiojkaDvJ9oq5CEWsq7qk4pANJ pzHXbQQi8W5euqVoLOIS3BAgG9Gydzjof+f7ww1crDH717Hrh X-Received: by 2002:adf:db48:0:b0:35e:ebe7:de43 with SMTP id ffacd0b85a97d-367756aaa04mr5978289f8f.21.1719921196811; Tue, 02 Jul 2024 04:53:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQMF0a8Br6+lHUnDLVeQ1xr6zVjHgN/vKj9wCtu/b+UZ8WneOYrvFC2+PloSAW0ikkuhAeCg== X-Received: by 2002:adf:db48:0:b0:35e:ebe7:de43 with SMTP id ffacd0b85a97d-367756aaa04mr5978267f8f.21.1719921196375; Tue, 02 Jul 2024 04:53:16 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:2400:78ac:64bb:a39e:2578? (p200300cbc739240078ac64bba39e2578.dip0.t-ipconnect.de. [2003:cb:c739:2400:78ac:64bb:a39e:2578]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4257dee5f2asm106204245e9.22.2024.07.02.04.53.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jul 2024 04:53:15 -0700 (PDT) Message-ID: <0c701d72-2f9c-405c-8e64-ec058568845a@redhat.com> Date: Tue, 2 Jul 2024 13:53:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/13] mm/memory: Add dax_insert_pfn To: Christoph Hellwig Cc: Alistair Popple , dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, david@fromorbit.com References: <50013c1ee52b5bb1213571bff66780568455f54c.1719386613.git-series.apopple@nvidia.com> <20240702114601.GA15426@lst.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240702114601.GA15426@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 153581C0016 X-Stat-Signature: 1dxm5y4hynsyoqkowijogb9ibc8g4raf X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719921201-959458 X-HE-Meta: U2FsdGVkX19qnm+0FHKMkwmslw/uzyqXcepVIzceeb5gBBGqv6OuykTvkOk8XfDNYykyk9gltwLDtA0+n4BtkrsZwj0lvqfvi6to8PSrMj6ubHSMAia+JlnHuAcXVK1Q5vz8ecJcsso/7C6jGzgkXn5jehrrF1nPchczK7kb4sHQ9P83DlGtl8Hh5cOBRU2A3pF2VunJdbPpICu/cFPsudI9my+rWAXNEqkPWntljwVqTeThbsRaaLCFXGUfDS+OeKNf+VwWu8HNJ0p3uHdNsrwaD69dyZxB791XHSKeXO/xJ1YXV8fxLRRMS/sUgp7iI037XF+itkgSgUBH6+0bS6qpPjjDR14soJ2O2TK3CCxxQ0HP6W1UvGZog48tlrZHGGNX7DcHkqfBxaQuJS0cEKLYO7gZeFxLfY1WVWBY9aMvxEN1s6aKpufMLNZNLgBIvURFY8ZpnMC+0I7dAanp+32jmXTEE7StqStynAGvAZ09LmL0iea3uFkqpehcJ+D+9RFnmfzuYGpfxx4LVyDAJ6APOXoDKMBiLO3Q3pQxBxOjuZYbJUqHQnVD4stFYEkp2138iPW5M1Jq0yhIOukX6Kr0VLiPkq63PiqSHSJzDQXHQOMZQI9xBkCYBZgARCI8G3lSyE6fIOTam2L3SWJXqgHAPetklWYwopHBzOei2fBEkwLdr2ojkOg2WYOLt/P6NAZki3SxZQAbTXL4ZecXe6bi7MHNh1hL6d+Hx034SrnPA5U9X8ipGUROnuR+jsJS8tlBRYy/jjPZ05oVk66ivx0CRFCr1ZHHhnYNeW5i5OrJxbFyaNKU64lFZtLnMZpKpbK8UnrIoPDLbSU5XNHn6iXnm+ZV84h/UZCpLI6tohR7UOtfYZS5xTJ5gvi4ZvKiRytJzwZnLqQD8bwYSVupUAEAD5Q/yTyyawjXpGtxLQmd7QstS5dakt6iu4KGEkf/G69QQzTM40/pnFN8bqW vexiYFRo +QFIoVwxv/tuKb7Yl4AYIqI/1Xgx1ybLN0U9NsjoHb+g5SOLxEaryQHAGDYMSQjid6R1GnB871aDf5tNbQC73cuYYRIirv5HGhpSJ5L4Wgk1SAfQO8akHnex+IHvTKvu2eKhD1BMEsPzx9b4NugdxXFdLHnfIbUx1JnrF5fbnqwJHe0xMjcqdZ2wD57Tf0UVeIdSDFeU5HfH1WHMtUnEIEQ4a39MvvkQtcG69NsVGcDUc0vU5M4kyYJEEXi1zuqIudcqaQLACYWE7Qa8rUe9S0bQFoW3ud0YMiAMcLrUn4bzsWPz/Mqi4aL9dqWLWA4P8QmXF+xyrs8Ot5A82GWc0lybWzFgnaNoE0LW6UiwHP4ZXXhVFn5u7cl/j2sr5+TmTZQBhgHtzMalkCiQ+EkskV/TsVHNcjWCk2OkVqHuRH+/ZClij/6fO8klbwmQ1UKrPj129 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.24 13:46, Christoph Hellwig wrote: > On Tue, Jul 02, 2024 at 09:18:31AM +0200, David Hildenbrand wrote: >> We have this comparably nasty vmf_insert_mixed() that FS dax abused to >> insert into !VM_MIXED VMAs. Is that abuse now stopping and are there maybe >> ways to get rid of vmf_insert_mixed()? > > Unfortunately it is also used by a few drm drivers and not just DAX. At least they all seem to set VM_MIXED: * fs/cramfs/inode.c does * drivers/gpu/drm/gma500/fbdev.c does * drivers/gpu/drm/omapdrm/omap_gem.c does Only DAX (including drivers/dax/device.c) doesn't. VM_MIXEDMAP handling for DAX was changed in commit e1fb4a0864958fac2fb1b23f9f4562a9f90e3e8f Author: Dave Jiang Date: Fri Aug 17 15:43:40 2018 -0700 dax: remove VM_MIXEDMAP for fsdax and device dax After prepared by commit 785a3fab4adbf91b2189c928a59ae219c54ba95e Author: Dan Williams Date: Mon Oct 23 07:20:00 2017 -0700 mm, dax: introduce pfn_t_special() In support of removing the VM_MIXEDMAP indication from DAX VMAs, introduce pfn_t_special() for drivers to indicate that _PAGE_SPECIAL should be used for DAX ptes. I wonder if there are ways forward to either remove vmf_insert_mixed() or at least require it (as the name suggests) to have VM_MIXEDMAP set. -- Cheers, David / dhildenb