From: David Hildenbrand <david@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Bibo Mao <maobibo@loongson.cn>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH v3] mm/khugepaged: sched to numa node when collapse huge page
Date: Thu, 28 Apr 2022 12:07:11 +0200 [thread overview]
Message-ID: <0c716a6b-c09c-f02c-a42a-9c8dc13518aa@redhat.com> (raw)
In-Reply-To: <20220427134843.576f0a18bea28de9e798004a@linux-foundation.org>
On 27.04.22 22:48, Andrew Morton wrote:
> On Thu, 17 Mar 2022 02:50:24 -0400 Bibo Mao <maobibo@loongson.cn> wrote:
>
>> collapse huge page will copy huge page from general small pages,
>> dest node is calculated from most one of source pages, however
>> THP daemon is not scheduled on dest node. The performance may be
>> poor since huge page copying across nodes, also cache is not used
>> for target node. With this patch, khugepaged daemon switches to
>> the same numa node with huge page. It saves copying time and makes
>> use of local cache better.
>>
>> With this patch, specint 2006 base performance is improved with 6%
>> on Loongson 3C5000L platform with 32 cores and 8 numa nodes.
>>
>
> Are there any acks for this one please?
I'll have a look!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-04-28 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 6:50 [PATCH v3] mm/khugepaged: sched to numa node when collapse huge page Bibo Mao
2022-04-27 20:48 ` Andrew Morton
2022-04-27 22:29 ` Yang Shi
2022-04-28 10:07 ` David Hildenbrand [this message]
2022-04-28 13:50 ` Peter Xu
2022-04-28 15:17 ` David Hildenbrand
2022-04-28 16:34 ` Peter Xu
2022-05-13 0:36 ` Andrew Morton
2022-05-13 1:19 ` maobibo
2022-05-13 1:29 ` maobibo
2022-05-13 1:49 ` Andrew Morton
2022-05-13 1:59 ` maobibo
2022-05-13 2:40 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c716a6b-c09c-f02c-a42a-9c8dc13518aa@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maobibo@loongson.cn \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).