From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C95DCC433F5 for ; Thu, 28 Apr 2022 10:07:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 123DF6B0072; Thu, 28 Apr 2022 06:07:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AC5B6B0073; Thu, 28 Apr 2022 06:07:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E67836B0075; Thu, 28 Apr 2022 06:07:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id D19E16B0072 for ; Thu, 28 Apr 2022 06:07:25 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id ACCF081E00 for ; Thu, 28 Apr 2022 10:07:25 +0000 (UTC) X-FDA: 79405860450.26.678F578 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id C91D8A0060 for ; Thu, 28 Apr 2022 10:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651140444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ao0Bz8xyz5j/xrhsX58NYx9f81qbkBvupY+H6E6SS5g=; b=MnR64QVcYnTV+W+gnRzvhwL8K5jCyWfkWU7SUMXjowa4ZQcCLSknl5ycs5Ay5Kn2v+ARDc phEKtZSKzSWt9pUp5NS/P8unE84+Hr25plxkjrlfjh8eidYiJ0rJnm2OL6pju8Jx0I07Ur nyPc9nDxIPULal7N+BIk66WScsMnNj4= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-501-k5mjPPi_NyGl4m00w-lR5A-1; Thu, 28 Apr 2022 06:07:14 -0400 X-MC-Unique: k5mjPPi_NyGl4m00w-lR5A-1 Received: by mail-ej1-f71.google.com with SMTP id cw19-20020a170906479300b006f3e54b1dbcso661722ejc.4 for ; Thu, 28 Apr 2022 03:07:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=Ao0Bz8xyz5j/xrhsX58NYx9f81qbkBvupY+H6E6SS5g=; b=H0EVkiN5OUr6MoVaVoDFdt8p5+Y2E6g/QlKH3V0bR6Sh1L1qjZKkDxIWvMkbJojUnY sVnxVBrtlPUwrWsAjRbqS7xDhNMjk1WNgxqJTaZ1zNnllp5/MOcx4yN33h7TUyYlo8iK OAv0vr5Ag0Cz75QY8sU9ccXnYbxj8fx33V8tADbNKKiVggIVPHwomaRQAQ3vO8CFrh4D R8hCJAjFEqaOkvoiWONUPy5+bETxmyod88iRQGCrW8z8980MsEB5qW4RmVU/7h7bNFQp sfTQnZ8JScjLct9eTjqpI2iODR6/GS0uAI6PeOlssZjfd6U62wMJY6M1mfEzUDC2vk7U /1ug== X-Gm-Message-State: AOAM531K5HV5IPtKANlzQxLTffxXyeNwHfmWpl85xdxQjpTrFq6lW5Gu eCJXtbFsOs4lZclLV5sufokwvEfPxsZ6FCKOlxutyPxRRnxv+hca4UUy/Vqm6o0mfo4GevEUT+l GjU2fJ97avMk= X-Received: by 2002:a17:906:6144:b0:6cf:bb2e:a2e1 with SMTP id p4-20020a170906614400b006cfbb2ea2e1mr31136397ejl.299.1651140432980; Thu, 28 Apr 2022 03:07:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywqv6biAMo0wtUvC8JVZeUiaXehKVhIyifRpO229YR0IF7PsJl/wJWYDkew029kmRoHokXIg== X-Received: by 2002:a17:906:6144:b0:6cf:bb2e:a2e1 with SMTP id p4-20020a170906614400b006cfbb2ea2e1mr31136378ejl.299.1651140432762; Thu, 28 Apr 2022 03:07:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:ef00:7443:a23c:26b8:b96? (p200300cbc708ef007443a23c26b80b96.dip0.t-ipconnect.de. [2003:cb:c708:ef00:7443:a23c:26b8:b96]) by smtp.gmail.com with ESMTPSA id u18-20020a17090626d200b006efdd9b95c8sm8217917ejc.47.2022.04.28.03.07.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 03:07:12 -0700 (PDT) Message-ID: <0c716a6b-c09c-f02c-a42a-9c8dc13518aa@redhat.com> Date: Thu, 28 Apr 2022 12:07:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v3] mm/khugepaged: sched to numa node when collapse huge page To: Andrew Morton , Bibo Mao Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi References: <20220317065024.2635069-1-maobibo@loongson.cn> <20220427134843.576f0a18bea28de9e798004a@linux-foundation.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220427134843.576f0a18bea28de9e798004a@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C91D8A0060 X-Stat-Signature: ymqq1fh3hn1dxq3xcrcepeaaxcjttdo6 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MnR64QVc; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf25.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-HE-Tag: 1651140436-921415 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.04.22 22:48, Andrew Morton wrote: > On Thu, 17 Mar 2022 02:50:24 -0400 Bibo Mao wrote: > >> collapse huge page will copy huge page from general small pages, >> dest node is calculated from most one of source pages, however >> THP daemon is not scheduled on dest node. The performance may be >> poor since huge page copying across nodes, also cache is not used >> for target node. With this patch, khugepaged daemon switches to >> the same numa node with huge page. It saves copying time and makes >> use of local cache better. >> >> With this patch, specint 2006 base performance is improved with 6% >> on Loongson 3C5000L platform with 32 cores and 8 numa nodes. >> > > Are there any acks for this one please? I'll have a look! -- Thanks, David / dhildenb