From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50BACC5AD49 for ; Fri, 6 Jun 2025 11:56:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF3E46B009A; Fri, 6 Jun 2025 07:56:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCBBE6B009B; Fri, 6 Jun 2025 07:56:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE1076B009C; Fri, 6 Jun 2025 07:56:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AF9406B009A for ; Fri, 6 Jun 2025 07:56:22 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5FE38BEE6A for ; Fri, 6 Jun 2025 11:56:22 +0000 (UTC) X-FDA: 83524823004.16.AE033AE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id EBAA71C0015 for ; Fri, 6 Jun 2025 11:56:19 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fEYiXl2l; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749210980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v/9NNy4TMyU9eeIJpLVXjlAQECKJ+eaM7O94WJTzoyU=; b=jz7F+z2PUaE3CQbp28H8T+wBZmG3uEHX75JaUUYxVKNP5CWWkJ0vUf/tFWyL+OD/S+oVhk eh0qK19MPyhB+Ao7reLUVYZ7cZl9UxbIe0kojE/1P/ZWUszrhehzgUFhygKPU2qiaspFQv 9CrzY2qBT/XgD0DTtt+UvygM6X2qOYA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fEYiXl2l; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749210980; a=rsa-sha256; cv=none; b=pdN6jLqgLeIoX9D6TBF08vACv+6ZsN03dYe+VL/pUJ1SsmUHGzlZAenYVZvPk01hJo6lDc 9lur2DPRgBge4AqRovVV2c3Ie+qL+RgzoRt+3rPveEiX1Wc2vUwsZkp3uO8WP99PYXv7ls mr/ma50/S6L7d+BwavRolQZOqXHbnRw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749210979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=v/9NNy4TMyU9eeIJpLVXjlAQECKJ+eaM7O94WJTzoyU=; b=fEYiXl2lvPgtPc/I+NHMHzEbv+k0Mfak+EUTliOINzbUQNgJlywGf+gPIaxPlmLbAnvEQN 6ZPOaTvWgWbdk4zdxNfMnJGm1Rux6lGmOgKcJAJHAh5CZ10sY3cGnExW1f6bGI4IMGz2bV NzoEd33Mrtz8g66wj9eU0WJ+wlpoNQQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-kCWgzFr6PHiXMaLS-F0Onw-1; Fri, 06 Jun 2025 07:56:18 -0400 X-MC-Unique: kCWgzFr6PHiXMaLS-F0Onw-1 X-Mimecast-MFC-AGG-ID: kCWgzFr6PHiXMaLS-F0Onw_1749210977 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4eeed54c2so1281730f8f.3 for ; Fri, 06 Jun 2025 04:56:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749210977; x=1749815777; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=v/9NNy4TMyU9eeIJpLVXjlAQECKJ+eaM7O94WJTzoyU=; b=Wl59bp69guhqmASiapqaW/Py/3W5W+RAJRXsaSqqnkawepLk/hXKVFLFlnKOpu/9Fw nIdxNGQ/aVMqHUFQhJ5l34pzGgrZVPlxXgY0Jbm2HwJZvJFM2fskgrjgWOF4qDGxp8AW F5YwndJU2N6lhfRGmWqeTjRPcXdvrk7mnGVr6kdAuJ2MgecP6ihpOaYzKjAA/999lxF4 8eIsooEKTrNt70AUp2FQ+xFZPd+7RvUhq6YkIScAslL8UK6j4rU0x1QfwpzzjZ5nHEez se3nW+fCue84AMQWjoANnQtDcGUFj1rQJ58fUW4CpGPrCBtc/Hg2zBnoPmhq9uuktdIL eTRQ== X-Forwarded-Encrypted: i=1; AJvYcCUZnEla+6xMQBIQD7C8PeIxVfwnUSvMAsl0UpOiadJB6YS7x9gHYmmFR+mGD8ZH0KE9532FyTO9Yg==@kvack.org X-Gm-Message-State: AOJu0YwiYLzjnqlWV/PxjifNwOF7/8qllHmjXFnTckPrDcICcdLFV3bX ldxVrXKNEzmz5Qzgj3RrXpX3h5hrHRBqzqJhRNEhKqJ0Ql3mTF9ontaMYUtKVb08uI56j9udtNs CzB6lgWsbHjY8XtepfxYwab/4t6FVm/oEbacInqIQYbN3a830zVpj X-Gm-Gg: ASbGnctLbXMWDJXhbzV31/P8BVjDv673jTT+BFBLdgin4LciBgR5tiGK6db2CF/z6aX ET11X5BCrphTFTqM0K2raMVYejnh5dtqbQ+fuvQL9OcV4alQSY4NtOz8HIdYM4KJZrbCEeBp1dP yovnxHfgejvfIJJpv/Oh08QNPQo4xLTt2u0QrVbTu8S5eQkaR8qg+tqGFOIhAf4MOXZGCm9FnWq UydDcJ193oW1cTNt2MJQ8AwaBHXrNEI1HSCCApvwzx1lmjVv+VzoeCMaEeunF/nxxte5hsuHdvH 74o/obraRjCbA5TA+CqFJVVBpgPjrfuf5zh1ZOUUE4Dk4JAxs+q0/r5tHVN8oLohoRf1SFxhwei N1+zvXhIasAfig1poDrW5TGFsiv7hB74= X-Received: by 2002:a05:6000:4284:b0:3a4:d8f8:fba7 with SMTP id ffacd0b85a97d-3a5318822a4mr2440242f8f.2.1749210977095; Fri, 06 Jun 2025 04:56:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH81pzwafZsjxj1UMHZCDZeA5pir+zKKSl7ua6ZL1jSF8b76n0i40RaUs/z/QtsMw38UkmCOA== X-Received: by 2002:a05:6000:4284:b0:3a4:d8f8:fba7 with SMTP id ffacd0b85a97d-3a5318822a4mr2440224f8f.2.1749210976743; Fri, 06 Jun 2025 04:56:16 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a5323a8acasm1641373f8f.26.2025.06.06.04.56.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 04:56:16 -0700 (PDT) Message-ID: <0ca963af-8dc9-4cb4-9142-04497c359b81@redhat.com> Date: Fri, 6 Jun 2025 13:56:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 04/10] mm,slub: Use node-notifier instead of memory-notifier To: Oscar Salvador , Andrew Morton Cc: Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250605142305.244465-1-osalvador@suse.de> <20250605142305.244465-5-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605142305.244465-5-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hHs7l4GkjqjGptubprNLUXTFd27wROjt8HOb5StxYcI_1749210977 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EBAA71C0015 X-Stat-Signature: e9cu3wuywtmq8ixrmdtgowam8zkps5b7 X-Rspam-User: X-HE-Tag: 1749210979-436788 X-HE-Meta: U2FsdGVkX1/B9Gq1qi3iiGsTg3IRyCr/KSsvCp9Q2M1BbLPr2hQk3Ggjb2I7uWMqPWRwWeRLIky//ZYCynraLUV8TIylgGkSOFfhPJyMnapZzw8FA2lgAzwUdW0iRLLWhwkgxdict2Envw2Vkqk3AVgwED5d/Kai/Wd1zu9E9ZPYYVQJ8ktNBeoHFIC6/N+0O3zQ/zr3f/hv+0HLPItBluwLIRwqw1Nii12tridYKz1u8QburnMEZXMG38WlXneM/QOkBPjGZua5nzro+vgjcxa/m/0UPCRIJ4wG/Op+QHrEEP0XqJJMriJmGfSmZ4DUJFp8CyZZtJ1XvSkwQjneMhXry6181A3D2tLvN1QZzoNhIU1BvyeGhdV9Pnz9QRRi5XIAL+Z69CsH4ohayu3fdxvKQZcAfNq5EIqZsLxVk43APTTVWwwtSA26f6Phpxdw2p1BC7vJUiTaVUexUnZDVDzVn7hrF9fqxCDAQg4l8P76TH1hiHH7PKIH/b/8zKhwRrDUU5H9B4hZxHkq37XFLDkACqXzafysxSAAZN4+gt+qyro8FviUO0KNvGXuq2+ycLlbjFVA2PWndcB1CfM1LGZDAOLrHyGPzzda0lcjtuoPz0uKAevQwY5StbynwdOA/7yRcdyEVJ0JZh4BMF9hExfeiHHIyPRJJ8KUrENLURa3/GsInZRho8KvbbiIDcJybMvv+FpwOjugraKNBGcAU5Mno8Yd82RmTTTwKcYiRpyM7raS/RHOriyL9ZgYn8yXSQPkrO2WC+Dkhl/ciXn5jnrCpNN7a7bJ/DGaF2dCSCYnXIInrL4Mak46wa+Nh0l45zqEbBxsMcD9zw7AJNi7FD/gi4fhzYzu0zDzgKKdeUFaah6/i7ZIXRx3UBX+ZmqsMNjZYMtGr9H2ebsUmQneaJZ1vzK9aPIt4WfL8XAqZsN/h1eCjQfehjqMHSOhFeQ/+RbXljYTnzZUcJTrFLj oxnCm0MG S3rhXYIBKKEnRWXrYWSNJTaRR+bk3LaPH+ppLK5hh9oLippPt9nGt3xTxw4XmzB9tsM5SYp7Yxo9GRws3tQERMx07VBDrPk3sJu8Gei71j251xgi3CDgIgo3Y4DW9EsIuamDUqVTNkOnirvwC10RKOssfpU48/JTDlHoTZ/4937WJnsKlwpRzW1dhemXaca832/T27jROfeiThfTlg19EYJm2PgrIKZc/sk6Loloi+ciuC8hx3/w4gkfmZyWeetXla5EZlH7J3HyYgLjPLJv/BAw8maEa2AqIcUSpO4k0fRwb72Cm7/trRV/P8XcbnI2m3fVx/1taov62R5UVGxA4oUsqKOSyUI6nS7Yn5ajv+NHpGmgPp2YL9pPT+2F6Kh3KtCfYL7d/HT4Y1cXlPHDxeHaSxOE5SJNVgjVebok0DXgrRGVkbJNY34TwdEYHIHq7QMcXYRSft2KSzri0a+TAd+CHKfWFYmNESi8rv5V4nf14UV0BWXL7ZxP2fe0w6MPlU1qEYqbThwmGrP0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 16:22, Oscar Salvador wrote: > slub is only concerned when a numa node changes its memory state, > so stop using the memory notifier and use the new numa node notifer > instead. > > Signed-off-by: Oscar Salvador > Reviewed-by: Jonathan Cameron > Reviewed-by: Harry Yoo > Reviewed-by: Vlastimil Babka > --- > mm/slub.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index f92b43d36adc..b8b5b81bfd1a 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -6164,8 +6164,8 @@ static int slab_mem_going_online_callback(void *arg) > { > struct kmem_cache_node *n; > struct kmem_cache *s; > - struct memory_notify *marg = arg; > - int nid = marg->status_change_nid; > + struct node_notify *narg = arg; > + int nid = narg->nid; > int ret = 0; > > /* > @@ -6217,15 +6217,12 @@ static int slab_memory_callback(struct notifier_block *self, > int ret = 0; > > switch (action) { > - case MEM_GOING_ONLINE: > + case NODE_ADDING_FIRST_MEMORY: > ret = slab_mem_going_online_callback(arg); In slab_mem_going_online_callback we will cast arg to "struct memory_notify", no? Probably needs to get fixed. ... and probably best to pass marg directly. > break; > - case MEM_GOING_OFFLINE: > + case NODE_REMOVING_LAST_MEMORY: > ret = slab_mem_going_offline_callback(arg); slab_mem_going_offline_callback() doesn't even look at arg, so likely we can drop that parameter? -- Cheers, David / dhildenb