From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28264C5321E for ; Mon, 26 Aug 2024 15:28:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A7126B0083; Mon, 26 Aug 2024 11:28:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 857816B0085; Mon, 26 Aug 2024 11:28:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D0E56B0088; Mon, 26 Aug 2024 11:28:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4FE286B0083 for ; Mon, 26 Aug 2024 11:28:35 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A9378120F11 for ; Mon, 26 Aug 2024 15:28:34 +0000 (UTC) X-FDA: 82494778548.06.7F6168B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 5328820023 for ; Mon, 26 Aug 2024 15:28:32 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VwkRvTp+; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724686026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/0/D/mqx8S/GSlZdjVOSgTAjgr7RwUJb4ayF8dILTNw=; b=VUpJWyZl4Rfl48xQGlgDzKtbrSveFHnYcDPlNH7ml7d+CWUjNOQwss0H0VS7T2VzUEreQz bIPsjXUbk6OD6Pjn39m0TJfk/sfPyO448wgTh1atxEUngj++k7MdX3r+eH9tQwhUGEJ2ig 9s6/UHJNe75bHkT3e4gizVvhLQih2Ho= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724686026; a=rsa-sha256; cv=none; b=BwbSOSATO1c48wLa64KNFW8OhwUcNT7j3JoLXfNkUFeFbangtNvvOwWmWbJVTdB4+im3cp C/qGLWaOYE+cS0rKIZg6BcYnyiUgpLtIZLErgkIkSZxvM1IJZEUeWhwI5A/zHTwPjcgfss Ea+vvTbVpUzmCWiLg5XwZIWVyudTcL8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VwkRvTp+; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724686111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/0/D/mqx8S/GSlZdjVOSgTAjgr7RwUJb4ayF8dILTNw=; b=VwkRvTp+t6Q9CD4JlaY3urzV8meUhd4UWQM0+Bo52FnFLyCgMUgqxfvx6Vc5f9oGwLA8x1 f12HLy2mEPSEizdamglXKfhUmR+Ly2JJ+3k/4dxSoCnEPcxYlw2zkz5KPOwFatXjZWLuhn nHCfZYlFJywbsSWpInIInIF68UgqCnc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-232-fjc2qVrzM0Oi3H2WI1oFJg-1; Mon, 26 Aug 2024 11:28:30 -0400 X-MC-Unique: fjc2qVrzM0Oi3H2WI1oFJg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-371afcaab22so2943336f8f.3 for ; Mon, 26 Aug 2024 08:28:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724686109; x=1725290909; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/0/D/mqx8S/GSlZdjVOSgTAjgr7RwUJb4ayF8dILTNw=; b=XNIIozgI6KsJ2LfHdH6Rmqs6as+00pWrgTXPTf3aMnlqsxAKZNar0mxYCQdg5Uptvy 1Ivxq4pId049CckGpk2oX3BP5TUYO1p7u+8Ost7QYgs2imdC1TkQCGGDZzcOb0RiCer9 MorqIzIjPPIEwa1CVF7QwRGXessQP9MrtGUZfVW07zV9y4lTpvXgDOISqLZAKF6khWY0 7sQvnYiHaswcsdp/zxE0V+PDMTVnAhTEGqJSc+n1uZjQhT8ORkMVv416A2nknVxS6dfa DinMgGTwVBDXMjsQ14uxPNQd/y/aJNLE6bqpzl8GXY1Iez/9aUpcK6TYeOQnDKl/MRU2 aH3A== X-Forwarded-Encrypted: i=1; AJvYcCWvZdtMcwJdhFhBpE8UN2PLBi6yhorDZc89htQjl2R3KpAKOUkGXiEqQtPrX3HPIZvUX/UwkDnpLQ==@kvack.org X-Gm-Message-State: AOJu0Yw8B/NuEszLyTV/WWCI3DdZmCzwogP7BY23GUJQ2ikHB/2gcTRL t2ozvmRpgY2r7g28PZ10/lVoGqxDNSZrrP04SwPQ5p+QWFSQv0yPToJxx7f9u+ODGQU4d9D8vaS Em7zD9IMP6pla9UnhvVop6jz+0gfibnZAtMBgZEIPWdwcho79 X-Received: by 2002:adf:e512:0:b0:371:8682:467e with SMTP id ffacd0b85a97d-373118d0bd7mr6501068f8f.46.1724686108900; Mon, 26 Aug 2024 08:28:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGuJF3qiUb+lUyCxaaobbsWcSjJJvrd35TRHfa7m+0xI9NSwN4+kDr5E4Gf+YbVT31YWsDeqw== X-Received: by 2002:adf:e512:0:b0:371:8682:467e with SMTP id ffacd0b85a97d-373118d0bd7mr6501036f8f.46.1724686108008; Mon, 26 Aug 2024 08:28:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:1900:16b0:8dc:77e:31af? (p200300cbc737190016b008dc077e31af.dip0.t-ipconnect.de. [2003:cb:c737:1900:16b0:8dc:77e:31af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42abed8b6a8sm197305465e9.2.2024.08.26.08.28.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 08:28:27 -0700 (PDT) Message-ID: <0cc7b49c-8e6a-459a-8541-eea6d15f8e5b@redhat.com> Date: Mon, 26 Aug 2024 17:28:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/14] powerpc: assert_pte_locked() use pte_offset_map_ro_nolock() To: Qi Zheng , hughd@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, akpm@linux-foundation.org, rppt@kernel.org, vishal.moola@gmail.com, peterx@redhat.com, ryan.roberts@arm.com, christophe.leroy2@cs-soprasteria.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org References: <89ae94f722996b4ee7ef20d44cd7f5e2f0495c47.1724310149.git.zhengqi.arch@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <89ae94f722996b4ee7ef20d44cd7f5e2f0495c47.1724310149.git.zhengqi.arch@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5328820023 X-Stat-Signature: emk1568o6sybcbniiboepeofjqdi1ttj X-HE-Tag: 1724686112-278588 X-HE-Meta: U2FsdGVkX18eu5ZK287Okd63YZSdMJD1yC/QBihnlcAY/75m21QId7g219al+R0oChnywePqAssPFlPiGQtNHWenlHBEtSPVNYQdvcBTZD7PrGfiUHzFvxaj38kKqvePEL46kIJEV3xy4YADgEfidYYLaGTyEeO8lDXDTxkIRPmhRW3OiuM9EJAuO7ociV1Rdrnfplvz0JzCW/YPvLERPlBL0OfVQVnMbPzZH3n6T8eO7CfTcdIam3501qOhR3utQ3A8iDc/TXjwldnsMyx+lyl7qrMai2gK3dkstWvQ0/7rR95nltt1oGmvQXCl/DcYWH9dObx5+LCkoQeEquA75L3JAHbPG8Bmlze1nBeFE32VKMWrpsXrlLTobJFXfMSmQOf+0DJxVmUUQrjfjrzo7paWr4BksQW8lvG+j4uv92C7VY4JCYUKrIkF5QG/xbBSpOpo+OAk/0rqage1TA/7DrwIMf2gUSs2HL4Gb3KIY2lJJl4dK2Sl6aYVatXiV8AbF84+7a7ljlhm3tiAmXpZySdccFeSgkja/lNOfizCQ9C1ifUQV00sjSsIMsXvaFXgMalp50S2Lp3mLQp5FiKe5RfQbB9rXJnDG/p5HDUjHA3SZffrhxtGBAw0dNVlKcuUUj6ZxuImOQtgU4sYUyynvj3MiBjw5dJ8whfQh330aScvZumzTdtzohBbj9t7wwkH9wgZhOxMWfvtxNlB8m5jsY8xT0YO1tSQZ+Vy7jnHPlsWxr5i0KKHp6MrRMBfTwExyi5d/+DgNK5Pdby9KuMS2aji5/BrX5SEg+Mg0a9cbF+R2HgtlHagnwosHDhKE3TJM+E7hQQacnluyIygjnqHb34CSf3JFqaqYr8zxeAnpU/p2Nv51mwy42fP0n40HGGiPx8AWJDyxMr/gZc/kUEFRkXjrALVChW9W02Ri3ZKZcKZzQG6l4V1UebLxiAlhVieinlIHzE8XTI8ar8nDaK 5tOPNc+/ GCXGLYlA1VwtKhzGIl0RvCXz76BASlsLZoTOX1klyNCmHPLS9WQZXmuwfeHkJonnGsnMyXTQ4jLH/9V4hDUIP3rkO0NdH7v/wZQe0+3Z1XTGsQbLU3VZKWrYOZPG52unp7ydlOigQbRNWyuEASQtPibr4JRtFBBwjeSvRFexGqfX6VJNtNG/UT3YQGTcAWI6hgtBVg+qcclLiSW31675GxN2iPPF5WPADtEVBYULasNrCakWDy562wzNFJxuIZSni94eMpIBVBb8D+lAHBiJiVm2yhJDZfzQ7yn0adBXiGw/PIr66eTk3zNqHSFxsJ/lhadPKdTfS9wwn3XtMyswbnWHXbI2lYvtDyPho4keMrdXWbmR6Ti3mjyrzwfS2SVU6kyga8tOGtCFTXm2vXKt3muOyoxDWxgZajdbs3we7IqFcTJP4IFEKT+/VVWi7p0S1MxSCGxyEFoRFafYsxDgtt6Jn5462+cRAst0/xJq8fRICKc5fI+gUzKtmF6r+vF2nRhhf/sZLHp30FSOrjIHeQ1guuw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.08.24 09:13, Qi Zheng wrote: > In assert_pte_locked(), we just get the ptl and assert if it was already > held, so convert it to using pte_offset_map_ro_nolock(). > > Signed-off-by: Qi Zheng > --- > arch/powerpc/mm/pgtable.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c > index 7316396e452d8..61df5aed79894 100644 > --- a/arch/powerpc/mm/pgtable.c > +++ b/arch/powerpc/mm/pgtable.c > @@ -398,7 +398,7 @@ void assert_pte_locked(struct mm_struct *mm, unsigned long addr) > */ > if (pmd_none(*pmd)) > return; > - pte = pte_offset_map_nolock(mm, pmd, addr, &ptl); > + pte = pte_offset_map_ro_nolock(mm, pmd, addr, &ptl); > BUG_ON(!pte); > assert_spin_locked(ptl); > pte_unmap(pte); Acked-by: David Hildenbrand -- Cheers, David / dhildenb