From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EF51C7115B for ; Thu, 19 Jun 2025 09:35:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6E076B00B4; Thu, 19 Jun 2025 05:35:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D46126B00B5; Thu, 19 Jun 2025 05:35:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C82866B00B7; Thu, 19 Jun 2025 05:35:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B48D86B00B4 for ; Thu, 19 Jun 2025 05:35:20 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D5C6E1A08C7 for ; Thu, 19 Jun 2025 09:35:19 +0000 (UTC) X-FDA: 83571641958.02.F11C496 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id DE7CD2000F for ; Thu, 19 Jun 2025 09:35:17 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750325718; a=rsa-sha256; cv=none; b=hgOndjPVYi5f1O7C0uMu6OvTIid8Z6hBWwQlwpjPoHVFrCzZ+n7iNNVNel3b2Fr8hijkco r4XzSud0zfWSalNtWLHukUkJXXZMFRS5bg1sA1G87h10LljWovltfxKWzXbe4Lt2duYDdu /NmYPBScvrZz4DtMrJDircwsc7sSFZw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750325718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YGN6AVJ3q8vGlFaGFFTou+6AQrZ2+tRKPDu2kSnKT4c=; b=BrqFy8P3rx5d3YAFhPKo4DkiSkmGkmyRR6jYlZVEvaaTguZaVQJRU0t60B106N8zRJHQQ/ Mll4mT0E74jUrdDOPpajHM2aKR6xm1CthqBp81+dvhhRMyF3376s0iExvEs1woZOJ8iHv7 1/y6J4jyGaagGBWipw0UKrzOkdzq+Sk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E1725113E; Thu, 19 Jun 2025 02:34:56 -0700 (PDT) Received: from [10.163.35.214] (unknown [10.163.35.214]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 953A43F58B; Thu, 19 Jun 2025 02:35:13 -0700 (PDT) Message-ID: <0d437b3e-37b5-4e98-90bc-afa6c8150e77@arm.com> Date: Thu, 19 Jun 2025 15:05:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t To: Andy Shevchenko Cc: linux-mm@kvack.org, Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 9hybgngjg9aw9nsucp7hti411mh89tkr X-Rspamd-Queue-Id: DE7CD2000F X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1750325717-536839 X-HE-Meta: U2FsdGVkX18ibDK800RgB38ucyLFLz0B6ZtyoH2L/k9GwqfCaKgAJxBv//qwzmQxg/PN0j+Ai8BaSCvhC7vIX249JP0s/ogSx1sn6o2t5OAm6WwJRriwz2k6TGoGtdQbEEHVWtRcmczau//adyy6Is4vCa/j46c6jtxi80REQPmqJL7euGg8C2CVQ1Q0eNBglII8kokZc5qRVCE3sI322Lkkjrg709BUTd8pMLnyGsGjsbVyRFoHM5gO+/vqiTEaxuAOQnDBYntlSiLmXhYlpjdXNn63b90VtzAJCEtx0Gm7rbvuzlrDkiqklJDiGUCgfE2ZSdbDFeUGTDOk06/RHdJg7x77e6vR2jr16WYYQYb4TS9fEHQIsaqI1cJp7XTU8nRau4/bCACQqC4Yni+g0qedV52YnOFmyuu+GgP9PLL1vGTd1Q3bebsleWP+GSt8UkS2b3Ed2I9yNelPbnFNK5qKVngWeEDKBeHfbE73syeXdBepIt4uYcq5Un5f+nOK7Yhyq7qvawCH9monDPGrNOUUfuae9c/Y+Z/Wu6DxWv9kagsUZwh9CClX9dfyqSPFezeH8I6GaK22quxnde3fdBajtCQ7ITbZO8xHf7VakGrlfd/p0HnOhx9Iywrciv7zj/Ay45UuUaZzDVZrbpcviAAwDFnjzfnHGIBydHoyotTUwHlEh0Auae4+yY2unt/SHCRalSdKDcGR5qfgPigLws2Ku5BUfCeXd9BGWWBelkRlK5jqspkPkP7rJLol8W573NzcwBjr60YQxV0+P2Y8C0CQvT9QwdykKtC7AqyVxtDhIcBNN8pwdIJojXSUk76K0CMuXJSBI/Ud7UpdA0blOmZx13uRxvl1acHc8dGsTVktxqI5NzyqWam75UX/Ey4a5E1yPHxQzp1ylY45EPVPHxZPbpm1sk7hH6Rbr3ZTxVlbWvSPGa9IWEUSCsaCRrQ1oVP0MlwPOdJX7pA6z0J RC0Edmuj Cc4Z+Joka7UdkdyAWyVf2fvV7liHKSgb/WOvbqK1G7+9UyRgIU/Q+e2Ljr+jy6Ka7oPQy1p/tOCYf227b6R8mZVMgfFDbP3eMgy9NytCdglLxWFbbcRvl96q6X3GH0o22YuONp/U+VR82moGLFOiXZMLGDLEwlYHAywShxvFFKndqJBg9imK1ryyR6d6lqf3IMB/BbyiIBtk0Q5XDPi0rwZYpqICGnIhdYqVCRAAajnnEa3RfwjqWnPiIY/VelzH5ls7+JgVNMTMAYxbTGlA4GwpR5mqVmWhUs7DLrBsR8O8eR//9Z77jDkTRPOQvBtYVa7cMt3RTqld2bDO/GvsoHQUo8sp9edp/m+rj8M5XM6KC+J9jvTyiAYHDrmz4wxqXez4FKbwD3YECjGLgEUzQDIHZ0Xc7r3v+Ru14biB+8XJuXtDnBA5UnHzey80oyAvgb8O6t1VdIV2rl1t2tm2i7GPijUGIU0SyUZGehlzW4JJKsqqp64TYhCQjGaaKpEWDDnPqlvve0VnLQs+1TjiLEK3ZUhk1eby+okRs9OITKrHj9bDpoag8SwKbae16m9WR/rGT8np6C8ch2xipoPq56WYZQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18/06/25 11:16 PM, Andy Shevchenko wrote: > On Wed, Jun 18, 2025 at 09:42:34AM +0530, Anshuman Khandual wrote: >> Add a new format for printing page table entries. > >> Cc: Petr Mladek >> Cc: Steven Rostedt >> Cc: Jonathan Corbet >> Cc: Andrew Morton >> Cc: David Hildenbrand >> Cc: linux-doc@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-mm@kvack.org > > Please. move these to be after the '---' cutter line below. Just leave SoB tag > alone. This will have the same effect w/o polluting commit message. > >> Signed-off-by: Anshuman Khandual >> --- > > (somewhere here is a good place for all your Cc: tags) Is not it better to also capture the Cc: list in the commit message. Seems like such has been the practice for various patches on the MM list. But not sure if that is an expected standard for all patches. > > ... > >> + %ppte > > I believe you can take %pte. Yes - that should be possible. > > ... > >> +Print standard page table entry pte_t. >> + >> +Passed by reference. >> + >> +Examples for a 64 bit page table entry, given &(u64)0xc0ffee:: > > What does this mean? 64 bit address containing value the 0xc0ffee > >> + %ppte 0x00c0ffee > > Can it be ever 64-bit? I am sorry - did not get that. pte_t contained value can be 64 bits if that's what you meant. > > ... > >> + spec.field_width = 10; >> + spec.precision = 8; >> + spec.base = 16; >> + spec.flags = SPECIAL | SMALL | ZEROPAD; > > Do not duplicate code we have already in the file. I am sorry - did not get that. Is the above flag combination some how wrong ? > >> + if (sizeof(pte_t) == sizeof(u64)) { >> + u64 val = pte_val(*pte); >> + >> + return number(buf, end, val, spec); >> + } > > Ditto. > >> + WARN_ONCE(1, "Non standard pte_t\n"); > > (almost) Ditto, > >> + return error_string(buf, end, "(einval)", spec); > > Ditto. > >> + } >> + fallthrough; > > Please, avoid this, it makes code much harder to read and maintain. > See above how. > Could you please kindly elaborate on the code duplication problem you have mentioned earlier. I might not understand your concern here correctly.