From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Tal Zussman <tz2294@columbia.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mm: remove unused mark_page_reserved()
Date: Mon, 7 Sep 2026 16:08:22 +0200 [thread overview]
Message-ID: <0f48f042-8f04-4a04-ac2f-49e87bde5676@kernel.org> (raw)
In-Reply-To: <20260901-mm-remove-unused-helpers-v2-1-f6474e169c23@columbia.edu>
On 9/1/26 21:38, Tal Zussman wrote:
> mark_page_reserved() lost its last caller in commit 6215d9f4470f ("arch,
> mm: consolidate empty_zero_page"). Remove it.
>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
> ---
> include/linux/mm.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 1b28e6fc8d5d..e3736c42c4db 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -4080,12 +4080,6 @@ static inline void free_reserved_page(struct page *page)
> free_reserved_pages(page, 0);
> }
>
> -static inline void mark_page_reserved(struct page *page)
> -{
> - SetPageReserved(page);
> - adjust_managed_page_count(page, -1);
> -}
> -
Good! The less PageReserved magic, the better.
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-09-07 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 19:38 [PATCH v2 0/2] mm: remove three unused helpers from mm.h Tal Zussman
2026-09-01 19:38 ` [PATCH v2 1/2] mm: remove unused mark_page_reserved() Tal Zussman
2026-09-07 14:08 ` David Hildenbrand (Arm) [this message]
2026-09-01 19:38 ` [PATCH v2 2/2] mm: remove unused totalram_pages_inc() and totalram_pages_dec() Tal Zussman
2026-09-07 14:09 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f48f042-8f04-4a04-ac2f-49e87bde5676@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=tz2294@columbia.edu \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox