From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E783C0015E for ; Tue, 15 Aug 2023 07:48:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C76C7900026; Tue, 15 Aug 2023 03:48:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C26E790000B; Tue, 15 Aug 2023 03:48:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEF7D900026; Tue, 15 Aug 2023 03:48:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A0C8A90000B for ; Tue, 15 Aug 2023 03:48:18 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7619740CF1 for ; Tue, 15 Aug 2023 07:48:18 +0000 (UTC) X-FDA: 81125561076.19.9B359DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 1B4BB2000D for ; Tue, 15 Aug 2023 07:48:15 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GYWopG5I; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692085696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OSgA22aTASG7kf7kmkk0CbjoADJSE+B67qAYQ8TTaYo=; b=AsbSDNFqO6LrMpO6u0WGF92O/jlKMOj7NYCFX5b5AjLYRr4oWu/aMjN34UkKOLl856N43Y 1qVp559lgQUrp0ikMEHLHnF3IUuFVFy0P7TToI6q8fopoB+ATlHfc2KGdNR5MBXcE3UvjB zkU/+3sFlJ4Cl7Wi/fL/vhXs9sNxn7E= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GYWopG5I; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692085696; a=rsa-sha256; cv=none; b=IyDLhJdC67mI1JjPB+tysgyHcxgD20ublzZSdswOfn9deMonm8niXBVH2rhF5ouwZKItLP xO0UvHAVB8Ku7Nw1JwoNiG4TdkrVPCjxu3kU30uHv6dxtHK3C1YQN6c1q7fg++xcodKfjc G77jNvZ3TeLKW7kaAbMXDr7vZHq7MBQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692085695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OSgA22aTASG7kf7kmkk0CbjoADJSE+B67qAYQ8TTaYo=; b=GYWopG5IKmbbFkBCRkWQjMGbOuCqgumtOAuef/IIyvIlcbF+Fz0GAQZic9PRC0OfcEk9sL LTeH7ud/oFKYspuDZHPqUUXOb72rH/5RsDx+QZ67KtXU4h9L8IdHvO8TjfeSQkgUaTTWaY +i251q9YPakDBT2JQ0olfiALUHVtX5c= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-fiOO6w3VPIqcDo7qYpj1BA-1; Tue, 15 Aug 2023 03:48:14 -0400 X-MC-Unique: fiOO6w3VPIqcDo7qYpj1BA-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2b9bf49342dso51833011fa.1 for ; Tue, 15 Aug 2023 00:48:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692085692; x=1692690492; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OSgA22aTASG7kf7kmkk0CbjoADJSE+B67qAYQ8TTaYo=; b=BJ9MVY+LLRTIyN9MMXSp4+kKLpip1MJwW78dbp9008oOTcFXTaviIuGxR987CL14FM nMTOTE5BHCBbECtYoTUzZ5ZXqVXEoUsb2mVUpZG4H61SSX/0eG4JagY8sLXscVvvI+RA e4AL/WIUBpoxFOGqusweUelVH2rTbXu2zCm0dBxJIZyoI2xsCCtCcV2ZdARRMqHgpKc9 49Hf3TXJET/RplJJhxw7TjVspaMQAxyW4NOnAr6HD9ojMfGlF+KUE51pr3ZnN1mBFTAB eEfkVcZqD3AXmXHj65mcypMD95pe0JnhxQP3sBbvNWldsUwzSjaksb7HjoCxw8q7NoXx k5Pg== X-Gm-Message-State: AOJu0YxIKoi0cRV5BNK/qwqQb1dEasrFtED5b53d+IPMRfFh45R4931L wFRanYkQVZJQplQSIwSGCCF6gjtVEoUpgS2tZam5tiySSscGNUFsNoqD+U/Fl3ZVbSz96zxgjIb eRg69ZKW61wU= X-Received: by 2002:a2e:910c:0:b0:2b9:e9c8:cb1 with SMTP id m12-20020a2e910c000000b002b9e9c80cb1mr8184963ljg.48.1692085692599; Tue, 15 Aug 2023 00:48:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHvDkHXLCluyzb4LmqhzSYc+RuSfI3neOngQcWD9TW3hL8SED9CHVVrhKeNIG7tKvJmQLWEnQ== X-Received: by 2002:a2e:910c:0:b0:2b9:e9c8:cb1 with SMTP id m12-20020a2e910c000000b002b9e9c80cb1mr8184958ljg.48.1692085692255; Tue, 15 Aug 2023 00:48:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:3100:c642:ba83:8c37:b0e? (p200300cbc7013100c642ba838c370b0e.dip0.t-ipconnect.de. [2003:cb:c701:3100:c642:ba83:8c37:b0e]) by smtp.gmail.com with ESMTPSA id c6-20020a7bc846000000b003fe0a0e03fcsm19480088wml.12.2023.08.15.00.48.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 00:48:11 -0700 (PDT) Message-ID: <100aa4cc-224f-f7b9-cb71-781d5073576d@redhat.com> Date: Tue, 15 Aug 2023 09:48:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/9] mm: Make free_compound_page() static From: David Hildenbrand To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: Jens Axboe , io-uring@vger.kernel.org, linux-mm@kvack.org References: <20230815032645.1393700-1-willy@infradead.org> <20230815032645.1393700-5-willy@infradead.org> <880a26db-f46e-7d28-b4fc-ff34a2566acf@redhat.com> Organization: Red Hat In-Reply-To: <880a26db-f46e-7d28-b4fc-ff34a2566acf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1B4BB2000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: h3cdmp6fhuz7jmai316kwrcezyyutu4o X-HE-Tag: 1692085695-284148 X-HE-Meta: U2FsdGVkX1+qe3K1d3EDrMZrno1/cu2raKjdE1NeCxlSVsIZYJ5jq8IrWW3Svt5DzTWXO8CVmIIGVuv5Ptq6IPaUCsmJUFKPNgEES6smK2RWgfG3cyEPNTQjCzq+xRHKf5agITU1ciyHZRaEJJRSbPAcbN1MHarbBwfUdPa6pN294PgaDeuO+479Xu5xNWDhoV7YpLqsi66EL1HG+pUnI/oLM4YXvQoW2Lz73FJqNKNsgsVZF4CSALgj7JUSbMAszK6ARwgeA1o4ITcwPKPzb/ext4cSRf9gI9WqEBjeRgmM3BAJipp13oZXB7pjz3Q3pv2N+FjNRnIMxWsFl9nIW8zyLjemOwPDyp4RjDuwWohYhS8goXmiiFlRjinrs00b4HN6V1o7LJ7jqwGyzFS1oZp4oxuxpQPNbanWCJSS8G77FLuO5fefRxmT8IrjJPzMVA5rwiLmOVw0VqOuPSLgAk2oI9eSKV7XYHuMYHqN5UZLNK8P4SmWKOxJfsCcdbiEayOrDHopanuEHHPRPupP9SeCOJiFmWWDpxlMmN+2qeX++dyPi2x7fjxP7MVFZPBo0SJWPkhypp4I18pObbL6vD53WH5W6Vk7LT9qqtRIeqxvcTp/4Kz+xiOuNCPbaT7d+qkRpnjI876Myuwrafb2J9NVO7haYaoj2C5+i5nwu9BGLG//rg58Bgp2Rlldto1x6i6IDQDN8vtxu1nUGzdIRPUvdskBQ8Pzy0eEHaw/yGQzvVmU2VO2Lj1RIeoaALw77o3tBlrTizPpXC4Tr5D8wlZf2Ztdyzl5tzdEgTkK7sOwRs5hnuQ/TJ9+v06+L8CLJL/lbVlPgQ2cSeZRCswLQ2zAY88WraXuRlmpS4Hv9jyQM1KPSkNkYZ6ienNq6xzhRCDppijP9vRn9ouzQeC1Y5RGF15WvAN4aAJIehQWBMVYt6nPuoVnpHLKmDMh8Gc4BZA5iS/OBPKKN4CjdIR jbMKjZUY U84Z5b7BMvOoCeYTNcuEG+IcOipzjOduDkdxH0sSatgXM3M72c8jxwK7ph7Tw7giFlGcUECp3tMncJ17aMuK/P+wDuJTh/7hjRLPET8o4GbvokaIApOAJvxc3H/+sJeCkkWNbdbdmIeArHuAXDrExRTiJiXVV29/dl8kFwBCyGHLiwe0WaSHnbRqd39OBCSI47DW7LDQCKuRsZscfX4zBhhoNC96YxTtntD16yHN1XRRJBL//zYXbKtgVmSIj/EtFjhFcARyXJ3MNaNINGN2xpecJy6BEDgj1D+sAyEB8DRxeJ1yQmGUMLA/oPwtDtZ6Byr1NEM1GgGMBTqej1+oTkzTZwBa6TVN99ZAi3O3TW1hjjv2t4HxJNKSLKVsJNGUYBNdc2ypykx9IMoHUtGFeVcwCigkPQuAwhbtFNb52ortSV7SRhHBJG2ipxIsnxdptYXt/urnOVAyDl0HZ1qNSKrTmaa8XIk9z1i+mXuJ2sbjY7wg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.08.23 09:47, David Hildenbrand wrote: > On 15.08.23 05:26, Matthew Wilcox (Oracle) wrote: >> free_compound_page() is the only remaining dynamic destructor. >> Call it unconditionally from destroy_large_folio() and convert it >> to take a folio. It used to be the last thing called from >> free_transhuge_folio(), and the call from destroy_large_folio() >> will take care of that case too. >> >> This was the last entry in the compound_page_dtors array, so delete it >> and reword the comments that referred to it. >> >> Signed-off-by: Matthew Wilcox (Oracle) >> --- > > [...] > >> int min_free_kbytes = 1024; >> int user_min_free_kbytes = -1; >> static int watermark_boost_factor __read_mostly = 15000; >> @@ -587,17 +582,17 @@ static inline void free_the_page(struct page *page, unsigned int order) >> * The remaining PAGE_SIZE pages are called "tail pages". PageTail() is encoded >> * in bit 0 of page->compound_head. The rest of bits is pointer to head page. >> * >> - * The first tail page's ->compound_dtor holds the offset in array of compound >> - * page destructors. See compound_page_dtors. >> + * The first tail page's ->compound_dtor describes how to destroy the >> + * compound page. >> * >> * The first tail page's ->compound_order holds the order of allocation. >> * This usage means that zero-order pages may not be compound. >> */ >> >> -void free_compound_page(struct page *page) >> +static void free_compound_page(struct folio *folio) > > "free_folio", maybe? Doesn't seem to be taken yet. Ah, I see it gets removed in the following patch. -- Cheers, David / dhildenb