From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B7D4C433F5 for ; Thu, 7 Apr 2022 09:46:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA29D6B0071; Thu, 7 Apr 2022 05:46:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B51866B0073; Thu, 7 Apr 2022 05:46:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A19D46B0074; Thu, 7 Apr 2022 05:46:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 92AF56B0071 for ; Thu, 7 Apr 2022 05:46:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4DF0E8249980 for ; Thu, 7 Apr 2022 09:46:19 +0000 (UTC) X-FDA: 79329602478.24.A3CFA5D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id C1F6C140002 for ; Thu, 7 Apr 2022 09:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649324776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CIrkyxw2ltSATsongCKPkeTXMJ2u05ZyiioovqE8L0s=; b=XOfPxoDk9VCcvJYem46YEBw3tYjh8uvmu8n+694jbfSz/1w2ziGeEfRbahUXzmv36uwbqS h7JabP+wWTcE5poq9U53zO9RmvpySR31rPhi5xP5eNARGxvZQlunAhlAYhq8B2WwIqglGF vZ3slaU32ANsYstlrM1DAVMj4TasVvM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-628-6Hg09mqoPvCui66fhcrt3Q-1; Thu, 07 Apr 2022 05:46:15 -0400 X-MC-Unique: 6Hg09mqoPvCui66fhcrt3Q-1 Received: by mail-wm1-f69.google.com with SMTP id l19-20020a05600c1d1300b0038e736f98faso1345472wms.4 for ; Thu, 07 Apr 2022 02:46:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=CIrkyxw2ltSATsongCKPkeTXMJ2u05ZyiioovqE8L0s=; b=XbFc6SZobMQITQ0rxi/VyPUsWKttB5sQhvnCJCIyv926zkCfWwwcRYEv1kTF0Wrzc+ +sqYKrsPnOdH7p421QKagX5xIVvyuJblxdzthSVM5t2YfwAxCgmyPlRJhGtoMXl8302U V73H8BVO/ffAGGwNwLD08tEZ8H6Az731HMlm7vG4oke9C6FkEWa526msz77x2HM40XRv OLDph/W1y1NbSFo3dr4OmzDAsoWIQWZB3nmfDWw5iPg/WM+FpAisVkKJBziD2sAdi5rq 0VlfDE6IAaK6OhZj+XIsQFRvhSB90YQUdEtp7LBBglsbVbXylLOWP9t5VqCBQ9BQRX6j 42Tg== X-Gm-Message-State: AOAM530HmVMC1t+msd2mb5fvlmVTvYAcgANeeFPjfKrPgQ5wpbBOrmgI 4IFjHJxnWkwl2wMsBw/Tm5OGUcDbtNRxS6OZp0Te97ZgATvoRJfh9FHisugZLiUqSy7JTBEBXBv h5GD8YhdbeYY= X-Received: by 2002:a1c:f005:0:b0:38c:b6d5:5c2a with SMTP id a5-20020a1cf005000000b0038cb6d55c2amr11560879wmb.89.1649324774615; Thu, 07 Apr 2022 02:46:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaV/O4sc8yI66xNvj9tArkavzQBoS8J9F6Pviebz+CdcTWfctMEO9PWcH/8H60MajLM0j21Q== X-Received: by 2002:a1c:f005:0:b0:38c:b6d5:5c2a with SMTP id a5-20020a1cf005000000b0038cb6d55c2amr11560857wmb.89.1649324774387; Thu, 07 Apr 2022 02:46:14 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8? ([2a09:80c0:192:0:20af:34be:985b:b6c8]) by smtp.gmail.com with ESMTPSA id l28-20020a05600c1d1c00b0038e72a95ec4sm8249142wms.13.2022.04.07.02.46.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 02:46:13 -0700 (PDT) Message-ID: <1028ca3c-5b6c-d95e-9372-ae64b1fcbc82@redhat.com> Date: Thu, 7 Apr 2022 11:46:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node() To: Juergen Gross , xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , stable@vger.kernel.org, =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Michal Hocko , Wei Yang References: <20220407093221.1090-1-jgross@suse.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220407093221.1090-1-jgross@suse.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C1F6C140002 X-Stat-Signature: cknh9k37kcrb4fhx7an1gkja61qahi7k Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XOfPxoDk; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-HE-Tag: 1649324778-705288 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.04.22 11:32, Juergen Gross wrote: > Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist > initialization") only zones with free memory are included in a built > zonelist. This is problematic when e.g. all memory of a zone has been > ballooned out. >=20 > Use populated_zone() when building a zonelist as it has been done > before that commit. >=20 > Cc: stable@vger.kernel.org > Fixes: 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist initialization"= ) > Reported-by: Marek Marczykowski-G=C3=B3recki > Signed-off-by: Juergen Gross > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index bdc8f60ae462..3d0662af3289 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6128,7 +6128,7 @@ static int build_zonerefs_node(pg_data_t *pgdat, = struct zoneref *zonerefs) > do { > zone_type--; > zone =3D pgdat->node_zones + zone_type; > - if (managed_zone(zone)) { > + if (populated_zone(zone)) { > zoneref_set_zone(zone, &zonerefs[nr_zones++]); > check_highest_zone(zone_type); > } Let's see if we have to find another way to properly handle fadump. Acked-by: David Hildenbrand --=20 Thanks, David / dhildenb