Re: [PATCH] no buddy bitmap patch : for ia64 [2/2]

Dave Hansen
2004-10-07T15:43:13Z

On Thu, 2004-10-07 at 05:42, Hiroyuki KAMEZAWA wrote:
> #ifdef CONFIG_VIRTUAL_MEM_MAP
> extern int ia64_pfn_valid (unsigned long pfn);
> +#define HOLES_IN_ZONE 1
> #else
> # define ia64_pfn_valid(pfn) 1
> #endif

The real way to do this is to put it in a Kconfig file.

something like:

config HOLES_IN_ZONE
bool
depends on VIRTUAL_MEM_MAP

right below where 'config VIRTUAL_MEM_MAP' is defined. That way, if any
other architectures need it, they alter their Kconfig files instead of
headers. Also, it leaves the possibility of having an arch-independent
Kconfig file for memory-related options which I'd like to do in the
future.

-- Dave