From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5918FCCD1BF for ; Wed, 22 Oct 2025 20:26:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B00898E0013; Wed, 22 Oct 2025 16:26:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB0C38E0003; Wed, 22 Oct 2025 16:26:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 978758E0013; Wed, 22 Oct 2025 16:26:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8417C8E0003 for ; Wed, 22 Oct 2025 16:26:49 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3F137160948 for ; Wed, 22 Oct 2025 20:26:49 +0000 (UTC) X-FDA: 84026883738.23.2FF4B50 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id CC19E8000E for ; Wed, 22 Oct 2025 20:26:46 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YGeMhRep; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1761164807; a=rsa-sha256; cv=none; b=m1O66B7w4dkb5UGZNhfBTQ+vnLOIaH9w5cDqQUIOCKo5WDcIUxlGysidLfss0oJsDimM2U w3wRRE5HoOoNtUgG3zq9p0Hz6yQRMFHDynnGCB5rUpn0k2HDZRnr34eLUw1fodSRQGRItA CI9WwoQgrKWqPvtjGkF+F1hD6P1ncBI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YGeMhRep; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1761164807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6K32svgAbD2UvOv8puLiiBLpqrvmrg/LVO1ZPbynXYU=; b=W09tQdDXec2mDgVPgx0FIqL6jy9gP0N1hIITpEesl3r3LiQMR25l9/pP6ECDuwpa3blkTM rlxN45NLCPVZV/GF+7l/2dVcaRgVC2lsCeHkd5hNG9Wj2G4zDsQmv63jlISKky+Y/Q3wMz DfEUl1yZUYs/+UqY2Aw41xrBipu17yQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761164806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6K32svgAbD2UvOv8puLiiBLpqrvmrg/LVO1ZPbynXYU=; b=YGeMhRepnTRsYb0ERUsAHhuCdxjccxqemzL4qtHPzDkkO9oSY62XQ/pz5Kb8L0VBJA/z/L 8QmgIbID1hPCwaO2mBJP4mM6hQiADv7ZNEW6VVOaSb9W6I9Lo3uMurXfDodaQNTvww3YEu mNnFOIK2A8SHbbK3uTY2cjDYh1QwTCQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-112-Z8f0q5wXN3WbAB3zysxgAw-1; Wed, 22 Oct 2025 16:26:42 -0400 X-MC-Unique: Z8f0q5wXN3WbAB3zysxgAw-1 X-Mimecast-MFC-AGG-ID: Z8f0q5wXN3WbAB3zysxgAw_1761164801 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-426d4f59cbcso771327f8f.1 for ; Wed, 22 Oct 2025 13:26:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761164801; x=1761769601; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6K32svgAbD2UvOv8puLiiBLpqrvmrg/LVO1ZPbynXYU=; b=NGT3g8q8G1mk3V3Fp+TNwCf9AAuaEUMCM8KvNNjFzjCkx/LBOpFuW/2BQSETWJtkvt sRPzaHThHqZxZ4kRo+fqNGCT4rMUqqhBKOpUIt4LAIcnLUyUsK2iIZ3Lx5m7wkTSTsIg MUtZS6wuvjbb7j4rg5heKyFpGIVW/+lAJpKWXkN/+jN8Vl6F4x/g6uNayE6tSS30HT1R JkoMSzW7S3FYKFLkJJ2p6P+agFurpsJ0N7TYuGyUK51O7GMutTmtIAbXArRngti1sgp3 l+FsNfHhVV/f1dDp3oz+TGl4ERhNHq0+ExLY7GCZfEVSvK5rpoP4FwlYWJlq8wV67uEq P48g== X-Gm-Message-State: AOJu0YycoxB9h9sVyDYaNRMb+6EsZc4jCJS5DqE+1P1p0/8Vn1bZ6p4V JdT5Mi5y2fYtJF6wfCBDsJhcK/UgRfmZu5w/dcOfhIeLmtMKQPuoOsF5jy4WTqBQ1WXbDvKDti4 F8i/VP9VUJ7ufOvQe0H6BwMWInVA0tnixEJ6ZNdpAufJNBhB4xuig X-Gm-Gg: ASbGncvHjzp1q/AgCB18d3uzV6dvsVbclR0w6gW6fDBxNjGYIZdcUalS+iXVW36IyU0 dgETFSgLzOvSYGolBgNTPGQ4zRmyBqBABFs5hF3Xk069rxB8IgQTI4uyRj5vZ5C+ZJb6CW4LhgY 8KtEbxOAldrEzclB4gCGBVRvDnW0gDzcCBiUaCz9eMjuXLMdlM6RwQe/LS30b3jFlEWprlhsqv0 5bbTvpqVpMkFeqau0vzf4+m2UHLB9PMVc0mCbACPzqkw1qzfT3HbGN5j3tWELNqVDlhaAOOeOOu KdqTV9irlfNtwfxspUmLHeqTQFWqCloAuY6hpUp5vtQFS+6CsDu2LMnayx2KWNb1lI3fpMKb8Hy i7SroVqrDDrZ9AVrG6OUUxsqhyOwdNfk0EBJ+6vw4UvntLijRIe1HdFNaylRWa9pYQngrXtmuhl 0s13wWIUsXS41C0uKDzH65imEdtgM= X-Received: by 2002:a05:600c:3792:b0:46e:1b9d:ac6c with SMTP id 5b1f17b1804b1-475c6f698e0mr13940185e9.17.1761164801543; Wed, 22 Oct 2025 13:26:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFsj/AUY1gsWLuqDtWZdNSLKlWlUqV3y4jE1GmXOwqyk0uHHIGQodyI7Ps/lUace4lJIYeE7w== X-Received: by 2002:a05:600c:3792:b0:46e:1b9d:ac6c with SMTP id 5b1f17b1804b1-475c6f698e0mr13940025e9.17.1761164801163; Wed, 22 Oct 2025 13:26:41 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3? (p200300d82f4e3200c99da38b3f3ad4b3.dip0.t-ipconnect.de. [2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475c428e9b2sm60253275e9.5.2025.10.22.13.26.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Oct 2025 13:26:40 -0700 (PDT) Message-ID: <10c39cf0-fecb-4da3-9bb8-d31dccaebbdc@redhat.com> Date: Wed, 22 Oct 2025 22:26:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch v3 2/4] mm/huge_memory: update folio stat after successful split To: Wei Yang , akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev Cc: linux-mm@kvack.org, wang lian References: <20251021212142.25766-1-richard.weiyang@gmail.com> <20251021212142.25766-3-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251021212142.25766-3-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rmuSIxFxNziMFoqNQ-RUUvs9vYaUc81MwQIgE8_yZuc_1761164801 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 35dy5hm4z6miycgjiz7xthg1u53a3xrp X-Rspamd-Queue-Id: CC19E8000E X-Rspamd-Server: rspam09 X-HE-Tag: 1761164806-768001 X-HE-Meta: U2FsdGVkX1/oEOyyfcmMjai5LMrRm9GuQdGnX6KYN+zeXtF0UUEc+kT8O7GDmV0Gku887yaAwMW9992ycyDsQyHHt8ay7c3Qj3T2e83unaS3002JcGm670ddMH14ig+XsIElwBKWio0xG/HudFD6V7Lkkv00aSurkf9kZQIgoUoyUcxZfj9iCak4qE07BLZFe6/W7xJ1u+4UObVM3cKY4sG39W1m7xev2n62RUcWZywCValQ+jOdaI3O9WT88FDGURsOoo1yrpx/G3jLI3P61pS5nFNM88pEEcgqLmPOcp5mApcwHDvN+DdiVWW5If3r2lsLrzBdT/VTwVsE4wkw+Nm93idWnQ4nBL/n4di+P0bnkTEFiygkOgJD21x2zJUchHmqSYT5y/aa+XwPqPM68sTHqgyRgqxFwxx7WvNRLanOzfeCSn+W9V8bgCLjAvg4LBnWhnIdkNtcS4+eeCq6/mH6SBBzAhUWcKsjSSbQIDhL5zeqm+ZqwEGJaFxJMY3mNxEtrdwnp+3bKG815SLdZLb6C9VXe/NF+KAu5GgBHsG+ou8d6iw2/qkGeCzOyE6Ek7pFAeI4zh1iTluTl7/tHhTOzZosyvdoKHzXNijnF3gn5nczGtqLAvdVjIxSmmP3tI2/CSfLxI7q1TFgLgJJIGa9xk5GlJq2LMV4VKhIzuQEglVdjxgZUh04YbYs77YroRBunkSxL2ITs+FwQaJ+5w86s3/PfJRQ0BdQvJDdSP04N7CNc81EAQIxb0RoENKVqaoKUPY7/OYt55Mt5dOtwDvx0eHw61KzlbU3a04wEjlsU2VzqryHn3tAbp2C/z+1r4z1NgT68G0EcgUctwnzzOsWhpmECzNALjBCmyBjH1mcyaPrfijsmmH5P00GCVQ2alVQKGp4S28+XpbYFpmI2cw7bm8fahDAyNyOFChyCbk1p3XtvjSq0Ea+1LOxqflHHqdtK96Ovjd1AL94N4X vaR5o7DF 0/pYaDb1q3jBHIH3IMrhmkdtzM8oMlR4b23XMFypvxjw3RjDuomr+qG/O2/ZregTMymyH8XR7t5HBVJ8VGiU7YtbNHUjr+VWBHpN4LoKYxymU2RpMAjr//pT12q+dvs6CZj4QndsrVkHUDPp9AZwYYwRxL+eXdmsKry2zH7OcdVo9Z71pnY4mPGodDqaoQs7v5JeERvgiQkwdiXGhfJSXDA33+gJIO7JCD1wqTKGO7i28Yo2VxmCrbBIM7A6dIZFiQcBC+xmFJkiBoGuhNZ7ZWU/UWyHFgopgUzzY4AnCeX6R1ZXTsmnQGyXVjGxgLthOzITzeCD9r9HzBeQk6fLXkWEsVD6PD+AN4KPls0zua1ehlJ0Lio4Q6hHVhnpi8Ycw/AWr3EsXmnK3SDmNDS5Ra/A9Tcrj0dXJk6UY9NAcxMHJhHj3P2tNSjuk9VHdBRMzoQCQN3lpcmgy/kaySo/qSq1XeQnpACIg4WzKvvbQcQ46LzYv7bpvx+tgLeaXdX5Zaj9MHZKy87F5kKgoFP/2N/EwkogD/NZCAVeo6MrEKFvNtS485wB27R+6ifrfDm5kcWBwAJwgpwgDXC8mLluBpLBEVKHzAHRQQ4RXMAPFOcgfGaHqFoWr8wPUE/dOKPIE7da6I7l+sq0ZDSE+PKlwTbItASthscuU4ANIDf1LuK1idaqm9jV3uaYhxGcodTq2QhiPWVKxYM0MUms= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.10.25 23:21, Wei Yang wrote: > The current implementation complicates this process: > > * It iterates over the resulting new folios. > * It uses a flag (@stop_split) to conditionally skip updating the stat > for the folio at @split_at during the loop. > * It then attempts to update the skipped stat on a subsequent failure > path. > > This logic is unnecessarily hard to follow. > > This commit refactors the code to update the folio statistics only after > a successful split. This makes the logic much cleaner and sets the stage > for further simplification of the stat-handling code. > > Signed-off-by: Wei Yang > Cc: Zi Yan > Cc: wang lian > --- This was easier to digest. I hope I didn't miss anything (it's late ...). Acked-by: David Hildenbrand -- Cheers David / dhildenb