From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D53A9C47422 for ; Fri, 19 Jan 2024 02:59:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60E9D6B007D; Thu, 18 Jan 2024 21:59:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BE066B0080; Thu, 18 Jan 2024 21:59:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AE336B0081; Thu, 18 Jan 2024 21:59:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3D30C6B007D for ; Thu, 18 Jan 2024 21:59:49 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F331E160267 for ; Fri, 19 Jan 2024 02:59:48 +0000 (UTC) X-FDA: 81694555656.21.6322CD2 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by imf30.hostedemail.com (Postfix) with ESMTP id 3CDE480005 for ; Fri, 19 Jan 2024 02:59:47 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=anA8kDQA; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705633187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y+Kc2NDnmlkNzK7U+ZErpyTm3v0Dgj/NSpkX/uSwmaM=; b=4C/+duH8hi1nZ5lAHsvW9vnDGx3RkmYX6DHrzwr+12ZbD3Gg3TV3xy8cIT9g1M9OgspZgy PALtGgDT8aBU5DIUWuxTkLZLuhrqlnG/5+ETAs/YNEzQnwMGya1y65owpV0MrdGmP5a2FQ dNvBMk6QTClwhFkcv8Dv5bOiioWOJFQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=anA8kDQA; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705633187; a=rsa-sha256; cv=none; b=xtlrBAsgb8faVQHDbazaNIiEUc8fHcYvGzhrlOhnW5vFxWW/PDa6ewP5mXmzaal1iu8M1o s8lOekE7JT1w2TiGpQJc9kvO7WK39Wn1SnSYRhKO+3ryFYZ9Kp/mHPgbfFh6K47b5ph++Y 1no1b3yA9zkUE//5rKmttEsNMd+75Sk= Message-ID: <10f26c5c-760d-4f1b-abdc-8508971236ed@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705633185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y+Kc2NDnmlkNzK7U+ZErpyTm3v0Dgj/NSpkX/uSwmaM=; b=anA8kDQAnpivlHYD60wp5ZBbUwPiXufJoerQq/zAq6vBLsigfM74QswzqZq3BfqamEdtj9 3x5ldDNPwygvuzhABK0bOBEvfN5st5WJZJgu3xBYdk/xJbMLsSi2UtV8JU4miD7gqY3pNK 7WCX+Gj74hhjmZ/U+8svf/R2VTPvX7g= Date: Fri, 19 Jan 2024 10:59:41 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v4 3/7] padata: dispatch works on different nodes To: Gang Li , David Hildenbrand , David Rientjes , Mike Kravetz , Andrew Morton , Tim Chen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com References: <20240118123911.88833-1-gang.li@linux.dev> <20240118123911.88833-4-gang.li@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240118123911.88833-4-gang.li@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: mck7gn6jq9knpgjfju6t1f4e1fwqzkpq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3CDE480005 X-HE-Tag: 1705633187-271217 X-HE-Meta: U2FsdGVkX1+ocQpLIw/MYo6z3NRL/vGgP4BaMXHSCIosy3WM+r0M8u/aCttSlliq+4/9ySlTFjREyzC/Oz3hzGdhh37VTkFvzPGc2OJXZJB4bMh662JpyRbWI1u2BzQlAAVUrvE6aZN7Vgw3zDBovH5ZDbtRAVSSDH5TQQ4vgqC0nszP23zW9iE7ULYmeHT+mtO1v/MYF6JQmb7idJKxDXKIvZx+ugKZKUwDErKwHUfL0EgJzgc7F/dzLume/DefuyYhw+0YSpBvH6ufobR7W6nr6ApvRW7t9mp/vvFcK3y2UOKz+dRbxcWjSuwA9X4Q1f2ZfW3Tspo9X45IOlGYzV8LkteJgKWX1hNQVnQOR7P9XxCDis9evZDeTPGntVHaS3Dc0uLzNk2CTEN02v/eVHQGIRMFska82Cdjut79BrLFh4hQESq2OFYW+o8exFgVvqaQQcHAgsUwwPrArvXZ7rpTFqbcnMYqb1zHLNIArar4ehyedAo8RQL1q9CL2RD/s21R71axTncrSosfOhjZkr2rNQJpxAODrbvDZoDNT4kCgi4FpRrwQhfl40FdwEcJ6BgqglpWMTLwYKsyJ+9SRy3keXrw65MMlQZ/ZjZWk8OlZcEPdG/A8x1Vxhj5942PW0KSkvgkq9DSN3Qt5j/77R+zMKJG6sDB3IP29EE5vx+l2WEH2gIb/tNnYiUUCmJftSg324kMwWw7tVkYOJl0yfWuB+F8FmyOp69uOTmfoLSfDcEAjXFcMzs+jfY6Ewsrd7A1eKx/6u1bUx/XNQ/L0J/Eyk2edVSbOQEagWQOZdWaRCCK4f/Pld9IGt8usSEuwDcKr00mkfkZUfCanO9xqsL26yxBR3PUhMxKpxkMkEUc2ATHLPDzQqY61HNbT0jz8g/w9tuTGxojOud3tTHR6tP57gtgOZuvNXABe0PXnFnmxeuqxXJQmG9WhGn1+UP+PoKbcK2nIfTepIMGGQj 6WQbJ1Y3 SAmEa8/YP9acJQmQyNESdg2stzO51bIVaj/Wr0V/bY+rV5Q6xmJUnp4KyVvcWKdQpOHOgfm00vnbWWxLNJOhlfpuJDRDJE66+QUX8OKE4z+1lxpQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/18 20:39, Gang Li wrote: > When a group of tasks that access different nodes are scheduled on the > same node, they may encounter bandwidth bottlenecks and access latency. > > Thus, numa_aware flag is introduced here, allowing tasks to be > distributed across different nodes to fully utilize the advantage of > multi-node systems. > > Signed-off-by: Gang Li > Tested-by: David Rientjes > --- > include/linux/padata.h | 3 +++ > kernel/padata.c | 14 ++++++++++++-- > mm/mm_init.c | 1 + > 3 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/include/linux/padata.h b/include/linux/padata.h > index 495b16b6b4d7..f79ccd50e7f4 100644 > --- a/include/linux/padata.h > +++ b/include/linux/padata.h > @@ -137,6 +137,8 @@ struct padata_shell { > * appropriate for one worker thread to do at once. > * @max_threads: Max threads to use for the job, actual number may be less > * depending on task size and minimum chunk size. > + * @numa_aware: Dispatch jobs to different nodes. If a node only has memory but > + * no CPU, dispatch its jobs to a random CPU. > */ > struct padata_mt_job { > void (*thread_fn)(unsigned long start, unsigned long end, void *arg); > @@ -146,6 +148,7 @@ struct padata_mt_job { > unsigned long align; > unsigned long min_chunk; > int max_threads; > + bool numa_aware; > }; > > /** > diff --git a/kernel/padata.c b/kernel/padata.c > index 179fb1518070..10eae3f59203 100644 > --- a/kernel/padata.c > +++ b/kernel/padata.c > @@ -485,7 +485,8 @@ void __init padata_do_multithreaded(struct padata_mt_job *job) > struct padata_work my_work, *pw; > struct padata_mt_job_state ps; > LIST_HEAD(works); > - int nworks; > + int nworks, nid; > + static atomic_t last_used_nid = ATOMIC_INIT(0); last_used_nid is only used during boot time so it could be __init_data. Otherwise, LGTM. Reviewed-by: Muchun Song > > if (job->size == 0) > return; > @@ -517,7 +518,16 @@ void __init padata_do_multithreaded(struct padata_mt_job *job) > ps.chunk_size = roundup(ps.chunk_size, job->align); > > list_for_each_entry(pw, &works, pw_list) > - queue_work(system_unbound_wq, &pw->pw_work); > + if (job->numa_aware) { > + int old_node = atomic_read(&last_used_nid); > + > + do { > + nid = next_node_in(old_node, node_states[N_CPU]); > + } while (!atomic_try_cmpxchg(&last_used_nid, &old_node, nid)); > + queue_work_node(nid, system_unbound_wq, &pw->pw_work); > + } else { > + queue_work(system_unbound_wq, &pw->pw_work); > + } > > /* Use the current thread, which saves starting a workqueue worker. */ > padata_work_init(&my_work, padata_mt_helper, &ps, PADATA_WORK_ONSTACK); > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 2c19f5515e36..549e76af8f82 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2231,6 +2231,7 @@ static int __init deferred_init_memmap(void *data) > .align = PAGES_PER_SECTION, > .min_chunk = PAGES_PER_SECTION, > .max_threads = max_threads, > + .numa_aware = false, > }; > > padata_do_multithreaded(&job);