Re: [PATCH 5/7] Fragmentation Avoidance V16: 005_fallback

Mel Gorman
2005-10-05T17:16:06Z

On Wed, 5 Oct 2005, Dave Hansen wrote:

> On Wed, 2005-10-05 at 15:46 +0100, Mel Gorman wrote:
> >
> > + */
> > +static inline struct free_area *
> > +fallback_buddy_reserve(int start_alloctype, struct zone *zone,
> > + unsigned int current_order, struct page *page,
> > + struct free_area *area)
> > +{
> > + if (start_alloctype != RCLM_NORCLM)
> > + return area;
> > +
> > + area = &(zone->free_area_lists[RCLM_NORCLM][current_order]);
> > +
> > + /* Reserve the whole block if this is a large split */
> > + if (current_order >= MAX_ORDER / 2) {
> > + int reserve_type=RCLM_NORCLM;
>
> -EBADCODINGSTYLE.
>

Changed to;

+static inline struct free_area *
+fallback_buddy_reserve(int start_alloctype, struct zone *zone,
+ unsigned int current_order, struct page *page,
+ struct free_area *area)
+{
+ int reserve_type;
+ if (start_alloctype != RCLM_NORCLM)
+ return area;
+
+ area = &(zone->free_area_lists[RCLM_NORCLM][current_order]);
+
+ /* Reserve the whole block if this is a large split */
+ if (current_order >= MAX_ORDER / 2) {
+ reserve_type=RCLM_NORCLM;

(Ignore the whitespace damage, cutting and pasting just so you can see it)

--
Mel Gorman
Part-time Phd Student Java Applications Developer
University of Limerick IBM Dublin Software Lab