Re: [PATCH 1/7] Fragmentation Avoidance V16: 001_antidefrag_flags

Paul Jackson
2005-10-06T15:11:28Z

Mel wrote:
> +/* Allocation type modifiers, group together if possible */

Isn't that "if possible" bogus. I thought these two bits
_had_ to be grouped together, at least with the current code.

What happened to the comment that Joel added to gpl.h:

+/* Allocation type modifiers, these are required to be adjacent
+ * __GPF_USER: Allocation for user page or a buffer page
+ * __GFP_KERNRCLM: Short-lived or reclaimable kernel allocation
+ * Both bits off: Kernel non-reclaimable or very hard to reclaim
+ * RCLM_SHIFT (defined elsewhere) depends on the location of these bits

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401