Re: vDSO vs. mm : problems with ppc vdso

Nick Piggin
2006-03-01T02:38:49Z

Benjamin Herrenschmidt wrote:
> On Wed, 2006-03-01 at 13:24 +1100, Nick Piggin wrote:

>>mapcount should be reset, to avoid the bug in page_remove_rmap.
>
>
> Can you be more explicit ?
>

reset_page_mapcount() -- if you don't already know that mapcount is
the right value.

It might not be unreasonable to say "bah my arch initialises it to
0, and I didn'tcare for it to be accounted in nr_mapped anyway",
however not using the mapcount accessors means you might break in
future if they change.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com