Re: [PATCH/RFC] Migrate-on-fault prototype 1/5 V0.1 - separate unmap from radix tree replace

Lee Schermerhorn
2006-03-09T19:05:55Z

On Thu, 2006-03-09 at 10:40 -0800, Dave Hansen wrote:
> On Thu, 2006-03-09 at 13:28 -0500, Lee Schermerhorn wrote:
> > @@ -3083,7 +3084,7 @@ int buffer_migrate_page(struct page *new
> > ClearPagePrivate(page);
> > set_page_private(newpage, page_private(page));
> > set_page_private(page, 0);
> > - put_page(page);
> > + put_page(page); /* transfer buf ref to newpage */
> > get_page(newpage);
>
> Is it just me, or do these have some serious whitespace borkage?

<heavy sigh> Probably. I was fighting with the mailer. Took several
attempts to import the text files. Even sent one to myself first,
before sending it out. Looked OK.

>
> Do you have a clean version of them posted anywhere?

I just placed a tarball at:

http://free.linux.hp.com/~lts/Patches/PageMigration/

I took a look at the files in the tar ball. Several of them do seem to
have lines consisting of a single space for what were empty context
lines in the patches. The patches were generated via quilt which
usually complains about trailing white space and I always fix them.

Some of the lines in the discussion above the patches do seem to have
trailing spaces, but that's probably just my fat fingers...

Lee