Re: page migration: Fail with error if swap not setup

Nick Piggin
2006-03-15T12:49:30Z

Christoph Lameter wrote:
> On Tue, 14 Mar 2006, Andrew Morton wrote:
>
>
>>But the operation can still fail if we run out of swapspace partway through
>>- so this problem can still occur. The patch just makes it (much) less
>>frequent.
>>
>>Surely it's possible to communicate -ENOSWAP correctly and reliably?
>
>
> There are a number of possible failure conditions. The strategy of the
> migration function is to migrate as much as possible and return the rest
> without giving any reason. migrate_pages() returns the number of leftover
> pages not the reasons they failed.
>

Could you return the reason the first failing page failed. At least then
the caller can have some idea about what is needed to make further progress.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com